feat(*): remove canvas dependency #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stepancar
commented
Jan 4, 2024
| @@ -36,6 +35,7 @@ | |||
| "@typescript-eslint/eslint-plugin": "^5.59.0", | |||
| "@typescript-eslint/parser": "^5.59.0", | |||
| "@vitest/ui": "^0.29.8", | |||
| "canvas": "^2.9.1", | |||
There was a problem hiding this comment.
we need canvas to run tests, I just moved it to devDeps
stepancar
commented
Jan 4, 2024
| @@ -256,12 +255,12 @@ export class BeamcoderExtractor extends BaseExtractor implements Extractor { | |||
| return null; | |||
| } | |||
| const rawData = this._resizeFrameData(frame); | |||
| const image = createImageData( | |||
There was a problem hiding this comment.
we will create this function in luminary instead
animanathome
approved these changes
Jan 4, 2024
antoineMoPa
reviewed
Jan 4, 2024
| frame.width, | ||
| frame.height | ||
| ) as ImageData; | ||
| return image; |
There was a problem hiding this comment.
It was nice to have ImageData type, but since it comes with complex build requirements, I think it makes sense to remove 😿
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To build electron we need to solve this issue somehow
Automattic/node-canvas#2200
The easiest way to do that is to remove node canvas as a dependency