minor modifications #162
Closed
minor modifications #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiaomx32
commented
Dec 29, 2024
xiaomx32
commented
- add the initialization of the '_default_io' variable to the 'initialization list'
- avoid repeated calls to 'cuDriverGetVersion' or 'cuDeviceGetCount' function
- remove seemingly redundant parameters
- remove unused header files
Mike-Leo-Smith
requested changes
Dec 29, 2024
| // provide a default binary IO | ||
| if (_io == nullptr) { | ||
| _default_io = luisa::make_unique<DefaultBinaryIO>(context()); |
There was a problem hiding this comment.
This change is incorrect. The original implementation only creates _default_io when input io is nullptr, but now it's always created.
| ) noexcept | ||
| : DeviceInterface { std::move(ctx) } | ||
| , _handle { device_id } | ||
| , _default_io { luisa::make_unique<DefaultBinaryIO>(context()) } |
There was a problem hiding this comment.
See comments below.
| @@ -1023,14 +1026,18 @@ static constexpr auto required_cuda_version_major = 11; | |||
| static constexpr auto required_cuda_version_minor = 7; | |||
| static constexpr auto required_cuda_version = required_cuda_version_major * 1000 + required_cuda_version_minor * 10; | |||
|
|
|||
| static void initialize() { | |||
| [[nodiscard]] | |||
| static std::pair<int, int> initialize() { | |||
There was a problem hiding this comment.
This is incorrect. If we create multiple devices, all devices other than the first will receive incorrect driver version and device count.
| @@ -208,7 +208,7 @@ Device Context::create_device( | |||
| interface->_backend_name = std::move(backend_name); | |||
| auto handle = Device::Handle { | |||
| interface, | |||
| [impl = _impl, deleter = m.deleter](auto p) noexcept { | |||
| [deleter = m.deleter](auto p) noexcept { | |||
There was a problem hiding this comment.
_impl is captured to extend its lifetime until device handle is destroyed. You CANNOT remove it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.