Skip to content

Remove black pre-commit hook and update ruff configuration #177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 18, 2024
Merged

Remove black pre-commit hook and update ruff configuration #177

merged 1 commit into from
Jun 18, 2024

Conversation

tr4nt0r
Copy link
Collaborator

@tr4nt0r tr4nt0r commented Jun 17, 2024

  • Updated ruff.toml to include isort configuration:
    • Force sort within sections.
    • Recognize known first-party imports.
    • Combine as imports.
    • Do not split on trailing comma.
  • Removed the black pre-commit hook from .pre-commit-config.yaml. as it conflicts with ruffs imports sorting

@tr4nt0r
Remove black pre-commit hook and update ruff configuration
202a567 
- Updated ruff.toml to include isort configuration:
  - Force sort within sections.
  - Recognize known first-party imports.
  - Combine as imports.
  - Do not split on trailing comma.
- Removed the black pre-commit hook from .pre-commit-config.yaml. as it conflicts with ruffs imports sorting
@codecov Codecov
Copy link

codecov bot commented Jun 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.03%. Comparing base (c1eb208) to head (202a567).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #177   +/-   ##
=======================================
  Coverage   51.03%   51.03%           
=======================================
  Files           7        7           
  Lines         772      772           
=======================================
  Hits          394      394           
  Misses        378      378

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tr4nt0r
Copy link
Collaborator Author

tr4nt0r commented Jun 17, 2024

Habe irgendwie nichts gefunden, wie man blacks isort deaktiviert

@tr4nt0r tr4nt0r requested a review from Ludy87 June 17, 2024 14:28
@Ludy87 Ludy87 merged commit 193472a into Ludy87:main Jun 18, 2024
@tr4nt0r tr4nt0r deleted the imports_sorting branch June 18, 2024 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ludy87 Ludy87 Awaiting requested review from Ludy87 Ludy87 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tr4nt0r @Ludy87