-
-
Notifications
You must be signed in to change notification settings - Fork 6
Fix token response parsing #167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Removed unnecessary rounding in token expiration check. - Updated token parsing to align with API response structure. - Adjusted `GetTokenResponse` typing attributes accordingly.
Always consider compatibility with: https://github.com/Ludy87/ecotrend-ista |
Sure, always trying to keep in mind not to change the public API, that's why i add aliases for backwards-compatibility. Purely internal methods will not need the compatibility layer. By the way, I'm also using this library for a HA core integration that will debut in the 2024.7.0 release 😉 |
Damn, the pytest was not in the commit 🙈 |
Dann kann ich die Integration Archivieren |
Nun, für Core integrationen ist es immer ein längerer Prozess, bis alle features drin sind, also noch sind es nur ein paar Sensoren, re-auth flow fehlt, 2FA Support fehlt. Also ist die custom integration vom Funktionsumfang noh weit voraus. |
- Introduced GitHub Actions workflow for running tests on push and pull requests. - Configured matrix strategy to test with Python versions 3.11 and 3.12. - Installed project dependencies and ran pytest with coverage reporting. - Integrated Codecov for coverage reporting using a GitHub Actions workflow.
fd4d45f
to
d177d0d
Compare
Habe noch ne Github action dran gehängt, die pytest laufen lässt und wenn du Codecov token im repo konfigurierst, sollte es auch den coverage report hochladen |
|
GetTokenResponse
typing attributes accordingly.Add GitHub Actions workflow for pytest