Skip to content

Conversation

tr4nt0r
Copy link
Collaborator

@tr4nt0r tr4nt0r commented Jun 16, 2024

  • Removed unnecessary rounding in token expiration check.
  • Updated token parsing to align with API response structure.
  • Adjusted GetTokenResponse typing attributes accordingly.

Add GitHub Actions workflow for pytest

  • Introduced GitHub Actions workflow for running tests on push and pull requests.
  • Configured matrix strategy to test with Python versions 3.11 and 3.12.
  • Installed project dependencies and ran pytest with coverage reporting.
  • Integrated Codecov for coverage reporting using a GitHub Actions workflow.

- Removed unnecessary rounding in token expiration check.
- Updated token parsing to align with API response structure.
- Adjusted `GetTokenResponse` typing attributes accordingly.
@Ludy87
Copy link
Owner

Ludy87 commented Jun 16, 2024

Always consider compatibility with: https://github.com/Ludy87/ecotrend-ista

@tr4nt0r
Copy link
Collaborator Author

tr4nt0r commented Jun 16, 2024

Always consider compatibility with: https://github.com/Ludy87/ecotrend-ista

Sure, always trying to keep in mind not to change the public API, that's why i add aliases for backwards-compatibility. Purely internal methods will not need the compatibility layer.

By the way, I'm also using this library for a HA core integration that will debut in the 2024.7.0 release 😉

@tr4nt0r
Copy link
Collaborator Author

tr4nt0r commented Jun 16, 2024

Damn, the pytest was not in the commit 🙈

@Ludy87
Copy link
Owner

Ludy87 commented Jun 16, 2024

Always consider compatibility with: https://github.com/Ludy87/ecotrend-ista

Sure, always trying to keep in mind not to change the public API, that's why i add aliases for backwards-compatibility. Purely internal methods will not need the compatibility layer.

By the way, I'm also using this library for a HA core integration that will debut in the 2024.7.0 release 😉

Dann kann ich die Integration Archivieren

@tr4nt0r
Copy link
Collaborator Author

tr4nt0r commented Jun 16, 2024

Always consider compatibility with: https://github.com/Ludy87/ecotrend-ista

Sure, always trying to keep in mind not to change the public API, that's why i add aliases for backwards-compatibility. Purely internal methods will not need the compatibility layer.
By the way, I'm also using this library for a HA core integration that will debut in the 2024.7.0 release 😉

Dann kann ich die Integration Archivieren

Nun, für Core integrationen ist es immer ein längerer Prozess, bis alle features drin sind, also noch sind es nur ein paar Sensoren, re-auth flow fehlt, 2FA Support fehlt. Also ist die custom integration vom Funktionsumfang noh weit voraus.

- Introduced GitHub Actions workflow for running tests on push and pull requests.
- Configured matrix strategy to test with Python versions 3.11 and 3.12.
- Installed project dependencies and ran pytest with coverage reporting.
- Integrated Codecov for coverage reporting using a GitHub Actions workflow.
@tr4nt0r tr4nt0r force-pushed the fix_token_response branch from fd4d45f to d177d0d Compare June 16, 2024 15:32
@tr4nt0r
Copy link
Collaborator Author

tr4nt0r commented Jun 16, 2024

Habe noch ne Github action dran gehängt, die pytest laufen lässt und wenn du Codecov token im repo konfigurierst, sollte es auch den coverage report hochladen

@tr4nt0r tr4nt0r requested a review from Ludy87 June 16, 2024 15:34
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@Ludy87 Ludy87 merged commit 52cff72 into Ludy87:main Jun 16, 2024
@tr4nt0r tr4nt0r deleted the fix_token_response branch June 16, 2024 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants