Changing IRequest to just be a normal Task instead of Task<Unit> #835
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes the following API changes to change
IRequestto useTaskinstead ofTask<Unit>to make void handlers easier:public interface IMediator { + Task Send<TRequest>(TRequest request, CancellationToken cancellationToken = default) + where TRequest : IRequest; }Handlers that implement
IRequestHandler<IRequest>need to change their return types toTaskfromTask<Unit>:public class VoidRequest : IRequest { } public class VoidRequestHandler : IRequestHandler<VoidRequest> { - public Task<Unit> Handle(VoidRequest request, CancellationToken cancellationToken) + public Task Handle(VoidRequest request, CancellationToken cancellationToken) { - return Unit.Task; + return Task.CompletedTask; } }Async version:
public class VoidRequest : IRequest { } public class VoidRequestHandler : IRequestHandler<VoidRequest> { - public async Task<Unit> Handle(VoidRequest request, CancellationToken cancellationToken) + public async Task Handle(VoidRequest request, CancellationToken cancellationToken) { await SomeThing(); - return Unit.Value; + return; } }