Log warning when perpetual license cannot be applied due to missing build date#1163
Merged
Log warning when perpetual license cannot be applied due to missing build date#1163
Conversation
Merged
…error in test Co-authored-by: jbogard <104498+jbogard@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update perpetual licensing pull request based on feedback
Log warning when perpetual license cannot be applied due to missing build date
Feb 24, 2026
jbogard
approved these changes
Feb 24, 2026
This was referenced Mar 3, 2026
This was referenced Mar 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
BuildInfo.BuildDatereturnsnull(assembly metadata not embedded), a perpetual license silently fell through to the standard expiration error with no diagnostic signal.Changes
LicenseValidator.csLogWarningwhenIsPerpetualistruebut_buildDateisnull, indicating that perpetual licensing was attempted but could not be applied due to missingBuildDateUtcassembly metadata??-fallback default parameter into two overloads, allowing explicitnullto be passed independently ofBuildInfo.BuildDateLicenseValidatorTests.csValidate(license, null)(non-existent overload) →Validate(license)with validator constructed using(DateTimeOffset?)nullbool.TrueString("True") →"true"to match the license parser's case-sensitive comparison💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.