Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to fix name tokenization for PascalCase member matching so that consecutive uppercase sequences (acronyms like XML) are handled as a single token, improving convention-based member resolution and flattening scenarios (per #4593).
Changes:
- Update
PascalCaseNamingConvention.Splitto avoid splitting inside consecutive-uppercase runs (acronym-aware splitting). - Add a new unit test intended to validate flattening behavior with acronyms in destination member names.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/AutoMapper/Configuration/INamingConvention.cs |
Adjusts PascalCase splitting logic to treat acronyms as single tokens. |
src/UnitTests/Bug/NamingConventions.cs |
Adds a regression test around flattening an acronym-containing member name. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
jbogard
deleted the
4593-pascalcasenamingconvention-is-splitting-formxml-to-form-x-m-l
branch
This was referenced Mar 4, 2026
This was referenced Mar 13, 2026
This was referenced Mar 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.