Consider member value resolvers and value converters for source valid… #4011
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lbargaoanu
force-pushed
the
source_validation
branch
2 times, most recently
from
be54421 to
9d2dfd9
Compare
lbargaoanu
force-pushed
the
source_validation
branch
from
207185b to
29f1beb
Compare
lbargaoanu
force-pushed
the
source_validation
branch
2 times, most recently
from
ff7603d to
18c7f73
Compare
lbargaoanu
force-pushed
the
source_validation
branch
from
1c753c7 to
704e5ba
Compare
lbargaoanu
force-pushed
the
source_validation
branch
3 times, most recently
from
ffa1268 to
ba60290
Compare
lbargaoanu
force-pushed
the
source_validation
branch
3 times, most recently
from
3891083 to
42ef755
Compare
lbargaoanu
force-pushed
the
source_validation
branch
from
d39b80d to
449a50b
Compare
lbargaoanu
force-pushed
the
source_validation
branch
8 times, most recently
from
7f06d55 to
ddc934f
Compare
lbargaoanu
force-pushed
the
source_validation
branch
4 times, most recently
from
3886592 to
bcd4936
Compare
lbargaoanu
commented
Jul 24, 2022
| CheckDefault(); | ||
| if (Options == null) | ||
| { | ||
| ThrowInvalidMap(); |
There was a problem hiding this comment.
We could simply return null here but I'm guessing people would keep asking why Items is null.
lbargaoanu
force-pushed
the
source_validation
branch
3 times, most recently
from
4ec71d0 to
6024cf3
Compare
jbogard
approved these changes
Jul 29, 2022
|
Ready to go? |
|
Yes, I think so. |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ation