Skip to content

Conversation

@adamralph
Copy link
Contributor

I wanted to test the next major of MinVer on a few repos which consume it, but I was stuck with AutoMapper because it currently only build on Windows.

public class Customer
{
public string Æøå { get; set; }
public string Æøå { get; set; }
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The encoding was wrong on these characters. They were encoded in "Western European (Windows)", but the file is encoded in UTF-8. I can only guess that on Windows, some kind of encoding munging is done to allow it pass through the compiler, but on Linux no such "convenience" is present, so compilation was failing.

@adamralph
Copy link
Contributor Author

adamralph commented Mar 11, 2022

Sorry, I force-pushed a couple of corrections, but it's all good to go now.

@jbogard
Copy link
Contributor

jbogard commented Mar 11, 2022

Does the build actually run locally (build.ps1)?

@adamralph
Copy link
Contributor Author

@jbogard no, but at least now I can run dotnet build, or build the solution in Rider. Before these changes it blows up spectacularly.

@jbogard jbogard merged commit a00e68f into LuckyPennySoftware:master Mar 17, 2022
@adamralph adamralph deleted the linux branch March 17, 2022 22:28
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants