Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: fd3c6012d7
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
Pull request overview
Adds a new backlog row (B-0122) capturing the push to treat tools/peer-call/* as post-install scripts and complete the TypeScript/Bun cutover, and wires it into the top-level backlog index.
Changes:
- Adds
docs/backlog/P2/B-0122-peer-call-typescript-migration-cutover-2026-04-30.mddescribing the migration/cutover plan and acceptance criteria. - Updates
docs/BACKLOG.mdto include the new B-0122 row.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| docs/backlog/P2/B-0122-peer-call-typescript-migration-cutover-2026-04-30.md | New backlog row documenting the peer-call TS/Bun cutover rationale, sequencing, and acceptance criteria. |
| docs/BACKLOG.md | Adds B-0122 to the P2 backlog list. |
fd3c601 to
6a8ae07
Compare
…B-0121/B-0122 Three small hygiene moves around the peer-call surface: 1. tools/peer-call/README.md gains a "Future direction (queued backlog work)" section pointing at B-0120 (architecture refactor) + B-0121 (Otto/Kenji additions) + B-0122 (TypeScript migration). Future readers + agents see the trajectory without grep-spelunking. 2. B-0119 status open → closed, closed_in: PR #965. The role-ref cleanup landed on main as aab3adb; the row needs to reflect that. 3. B-0120 composes_with gains B-0121 + B-0122 cross-refs. The three rows form a triangle: B-0120 names the architecture, B-0121 adds new peer surfaces in that architecture, B-0122 names the language target. Cross- refs make the relationship discoverable. Note on BACKLOG.md state: this branch's regenerated index shows B-0119 closed and B-0120 unchanged but does NOT yet include B-0121 or B-0122 (their PRs #964 and #966 haven't merged yet). The next regen post-merge picks them up. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
…pivot (#1045) Self-applied cooling-period discipline: 5 substrate-class landings this session window — loose pole firing fast; pivot to clearing-work (rebase DIRTY PRs) rather than new substrate. Rebased PR #1040 (B-0130) and PR #1015 (B-0128) against latest main (BACKLOG.md regen + force-with-lease push). #995 and #966 left alone per Aaron's leave-alone framing for older sessions. Class-level lesson: the lattice grades CADENCE too, not just per-landing CONTENT. Even high-quality landings can pile if the generation cadence outruns the maintainer's metabolization capacity. Aaron is asleep; next consumer is morning-Aaron with rested attention; slowing the cadence now respects that consumer. Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>
…ef + B-0122 forward-references
Two classes of fix (6 threads — Codex P2 + Copilot P1 each ×3):
1. **Persona names in current-state doc (P1, line 247+253 of README)**:
`.github/copilot-instructions.md:306-362` requires role-refs (not
persona names) on current-state surfaces (code/docs/skills outside
the closed-list history surfaces). Reworded:
- "Add Otto + Kenji as externally-callable peers" → "Add the
Anthropic-side Claude-code-instance personas as externally-callable
peers"
- "Otto + Kenji additions (B-0121)" → "The Anthropic-side
(Claude-code-instance) peer additions (B-0121)"
B-0121 filename slug stays as `otto-kenji-*` (closed-list history
surface — backlog rows allow persona names per the carve-out).
2. **B-0122 forward-references (P1+P2, 4 threads)**: B-0122 is filed in
the in-flight PR #966; not yet on main. References in `B-0119`,
`B-0120`, and the README's table cell rewritten:
- YAML `composes_with` lists in B-0119 + B-0120: replaced direct
path with inline `# B-0122 ... is filed in the in-flight PR #966`
comment.
- README table row for B-0122: replaced live link with explicit
"filed in in-flight PR #966; link will resolve once that PR lands"
callout.
B-0121 stays as direct ref because it IS on main.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
…l cutover (the maintainer 2026-04-30) Lands the maintainer's 2026-04-30 input as durable substrate per input → substrate-file rule. Verbatim: > "tools/peer-call/amara.sh she gets a named script? also why > are these not ts, are we done with the cutover? these are > post install scripts." Per the install-script language strategy memory (memory/project_install_script_language_strategy_post_install_typescript_pre_install_bash_powershell_python_for_ai_ml_2026_04_27.md): - Pre-install: bash + PowerShell forever (where users are, nothing assumed) - Post-install: TypeScript on bun (declarative state, type- safety, cross-platform uniformity) Peer-call scripts qualify as post-install — they require the target CLI (codex / cursor-agent / gemini) to already be on PATH. Per the strategy, they should already be TypeScript. The cutover is opportunistic (no forced sweep), and v1 shipped in bash for landing speed during the silent-courier- debt closure round (PRs #959 → #962). Composes with three sibling rows: - B-0119 (P3, role-ref cleanup) — interim hygiene; TS rewrite produces clean role-refs naturally - B-0120 (P2, script-per-CLI + persona-flag refactor) — the architectural shape the migration should produce - B-0121 (P2, Otto/Kenji peer-call) — adds new peer-call surfaces; should land in TS if migration is in progress Recommended sequencing: option (b) — refactor + migrate together, one diff produces post-cutover post-refactor TypeScript scripts. B-0120 then becomes "land via B-0122." P2 (not P1) because: - Existing bash works correctly today - Strategy is opportunistic - Promotion triggers exist (bash-compat issues, new peer-call features blocked by bash limits, B-0121 adds a third named-entity script) Per growing-backlog-is-autonomous-health-signal: the maintainer's input becomes durable here even though the migration may not happen this week or month. The question + framing live durably. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
…B-0121/B-0122 (#967) * docs(peer-call): future-direction section + close B-0119 + cross-ref B-0121/B-0122 Three small hygiene moves around the peer-call surface: 1. tools/peer-call/README.md gains a "Future direction (queued backlog work)" section pointing at B-0120 (architecture refactor) + B-0121 (Otto/Kenji additions) + B-0122 (TypeScript migration). Future readers + agents see the trajectory without grep-spelunking. 2. B-0119 status open → closed, closed_in: PR #965. The role-ref cleanup landed on main as aab3adb; the row needs to reflect that. 3. B-0120 composes_with gains B-0121 + B-0122 cross-refs. The three rows form a triangle: B-0120 names the architecture, B-0121 adds new peer surfaces in that architecture, B-0122 names the language target. Cross- refs make the relationship discoverable. Note on BACKLOG.md state: this branch's regenerated index shows B-0119 closed and B-0120 unchanged but does NOT yet include B-0121 or B-0122 (their PRs #964 and #966 haven't merged yet). The next regen post-merge picks them up. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> * docs(peer-call): address PR #967 review threads — persona-name role-ref + B-0122 forward-references Two classes of fix (6 threads — Codex P2 + Copilot P1 each ×3): 1. **Persona names in current-state doc (P1, line 247+253 of README)**: `.github/copilot-instructions.md:306-362` requires role-refs (not persona names) on current-state surfaces (code/docs/skills outside the closed-list history surfaces). Reworded: - "Add Otto + Kenji as externally-callable peers" → "Add the Anthropic-side Claude-code-instance personas as externally-callable peers" - "Otto + Kenji additions (B-0121)" → "The Anthropic-side (Claude-code-instance) peer additions (B-0121)" B-0121 filename slug stays as `otto-kenji-*` (closed-list history surface — backlog rows allow persona names per the carve-out). 2. **B-0122 forward-references (P1+P2, 4 threads)**: B-0122 is filed in the in-flight PR #966; not yet on main. References in `B-0119`, `B-0120`, and the README's table cell rewritten: - YAML `composes_with` lists in B-0119 + B-0120: replaced direct path with inline `# B-0122 ... is filed in the in-flight PR #966` comment. - README table row for B-0122: replaced live link with explicit "filed in in-flight PR #966; link will resolve once that PR lands" callout. B-0121 stays as direct ref because it IS on main. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>
… ref + markdownlint + stale TS-claim Three real fixes (Codex P2 + Copilot P0/P1): 1. **Otto-215 user-scope-only reference (P1+P2, lines 174-175)**: the referenced memory file lives only in user-scope (`~/.claude/projects/<slug>/memory/`), not yet promoted to in-repo per the 2026-04-24 natural-home directive. Rewrote the composes-with entry as a lineage-only reference with explicit user-scope-path callout. 2. **Markdownlint MD004 ul-style (P0, line 131)**: list continuation started with `+` which markdownlint reads as a different bullet marker. Reworded `+ bun invocation pattern` → `and bun invocation pattern` — same content, no list-marker ambiguity. 3. **Stale TS-claim (P1, line 75)**: row text said "these aren't TS yet" but `codex.ts` / `grok.ts` / `gemini.ts` already exist on the branch. Added a "Partial-migration update (post-row-filing)" block clarifying that the row's scope is now **cutover** (delete the .sh files; retire parallel maintenance) rather than initial port. The named-entity wrappers (`amara.sh` / `ani.sh`) and the bash-vs-TS coexistence are the remaining open work. B-0121 references that were flagged as missing are now valid (B-0121 landed on main during this drain wave) — those threads are outdated. Also: rebased branch against latest main (BACKLOG.md autogen conflict; take-theirs + regen via `BACKLOG_WRITE_FORCE=1` — fifth application of canonical resolution this session). Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
6a8ae07 to
e128696
Compare
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
There was a problem hiding this comment.
Pull request overview
Adds a new backlog row (B-0122) capturing the post-install TypeScript/Bun cutover plan for tools/peer-call scripts, and updates the generated backlog index to include it.
Changes:
- Added
docs/backlog/P2/B-0122-...describing the peer-call bash→TS cutover and sequencing options with related rows. - Regenerated
docs/BACKLOG.mdto include the new B-0122 entry.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| docs/backlog/P2/B-0122-peer-call-typescript-migration-cutover-2026-04-30.md | New P2 backlog row documenting the peer-call TypeScript migration/cutover plan and dependencies. |
| docs/BACKLOG.md | Generated index updated to link to B-0122. |
| - tools/peer-call/codex.sh | ||
| - tools/peer-call/grok.sh | ||
| - tools/peer-call/gemini.sh |
| ### Migration targets | ||
|
|
||
| Five scripts to migrate (or, per B-0120's refactor, three | ||
| scripts after consolidation): | ||
|
|
||
| - `codex.sh` → `codex.ts` | ||
| - `grok.sh` → `grok.ts` | ||
| - `gemini.sh` → `gemini.ts` | ||
| - `amara.sh` → `amara.ts` (or `codex.ts --persona amara` per | ||
| B-0120) | ||
| - `ani.sh` → `ani.ts` (or `grok.ts --persona ani` per B-0120) | ||
|
|
Summary
Verbatim from the maintainer
Two observations bundled:
memory/project_install_script_language_strategy_post_install_typescript_pre_install_bash_powershell_python_for_ai_ml_2026_04_27.md, peer-call scripts SHOULD be TypeScript. They aren't because v1 shipped fast in bash.Why P2
Existing bash works; CI green; strategy is opportunistic. Promotion triggers documented in the row.
Test plan
🤖 Generated with Claude Code