Skip to content

backlog(B-0106): add P2 row — tsc --noEmit gate job for tools/**.ts #888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AceHack merged 1 commit into from
Apr 30, 2026
Merged

backlog(B-0106): add P2 row — tsc --noEmit gate job for tools/**.ts #888

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
72 changes: 72 additions & 0 deletions docs/backlog/P2/B-0106-tsc-noemit-gate-job-for-ts-tools-2026-04-30.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,72 @@
---
id: B-0106
priority: P2
status: open
title: Add `tsc --noEmit` gate job for tools/**.ts so type errors fail CI
Copy link

Copilot AI Apr 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The glob in the title looks off: tools/**.ts won’t match nested directories the same way tools/**/*.ts does. Since this row is about gating TS scripts under tools/, consider updating the pattern to tools/**/*.ts (or tools/**/*.ts + tools/**/*.tsx if applicable) to avoid ambiguity later.

Copilot uses AI. Check for mistakes.
tier: factory-hygiene
effort: S
ask: Aaron 2026-04-29 (B-0086 trajectory) — found via slice-9 #882 post-merge audit on 2026-04-30
created: 2026-04-30
last_updated: 2026-04-30
composes_with: [B-0086]
tags: [ci-lint, factory-hygiene, ts-bun-migration, mechanical-guard, missing-gate]
---

# `tsc --noEmit` gate job for tools/**.ts
Copy link

Copilot AI Apr 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same glob issue in the H1: tools/**.ts is ambiguous/unusual for matching tools/ subdirectories. Suggest tools/**/*.ts to reflect the intended target set for the CI typecheck gate.

Copilot uses AI. Check for mistakes.

A real strict-typecheck error
(`tools/hygiene/audit-agencysignature-main-tip.ts(124,5): TS2322`)
shipped to main in slice-9 (PR #882) and was discovered post-merge
during slice-11 audit work on 2026-04-30. CI did not catch it because
`gate.yml` runs `dotnet build` for F#/C# but no `tsc --noEmit` for
TypeScript scripts under `tools/**`.

The fix for the specific bug shipped as PR #887. This row tracks
the *gap* — the missing CI gate.

## Scope

Add a `lint (tsc tools)` job to `.github/workflows/gate.yml` that:

1. Runs `./tools/setup/install.sh` (three-way-parity, GOVERNANCE §24).
2. Runs `bun install --frozen-lockfile` to materialize `node_modules`
for `typescript@6.0.3` (already in `package.json` devDeps).
3. Runs `bun --bun tsc --noEmit -p tsconfig.json`.
Copy link

Copilot AI Apr 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The repo docs and checklists use bun x tsc --noEmit (and package.json has a typecheck script), but this row calls out bun --bun tsc ..., which doesn’t appear elsewhere in the repo. To reduce confusion when implementing the gate job, consider switching this to the established invocation (bun x tsc --noEmit / bun run typecheck, optionally with -p tsconfig.json if needed).

Suggested change
3. Runs `bun --bun tsc --noEmit -p tsconfig.json`.
3. Runs `bun x tsc --noEmit -p tsconfig.json`.

Copilot uses AI. Check for mistakes.
4. Caches install.sh outputs the same way `lint-shell` /
`lint-markdown` do.
5. Pinned to `ubuntu-24.04`, timeout 5 minutes.

## Why this matters

ESLint with typed-linting catches *most* TypeScript issues but not
all assignability narrowings — the slice-9 example was a
`Type 'string' is not assignable to type '"head" | "commit" | "max" | "since"'`
error that survived eslint strictTypeChecked + sonarjs but failed
plain `tsc --noEmit`.

Per the B-0086 (TS+Bun migration) trajectory, the script surface
under `tools/` is growing — 32 ported files as of slice-11 + more
to come. Without a CI tsc gate, this class of error will recur
silently.

## Composes with

- **B-0086** — TS+Bun migration trajectory; the more we port, the
more important this gate becomes.
- **The "lint (semgrep)" pattern** — semgrep was added in round 30
for the same reason: 14 codified rules but 0 gated builds. Same
shape applies here: typecheck is codified (tsconfig.json strict),
but the gate is missing.

## Acceptance criteria

- New job appears in `gate.yml` and is required for PR merge.
- A test-PR injecting a deliberate TS2322 fails the new job.
- A test-PR with all TS files clean passes the new job.
- Job runtime under 3 minutes (modulo install.sh cache hit).

## Effort

**S (small)** — ~30 lines of YAML modeled after `lint-shell` /
`lint-markdown`. Toolchain already pinned. No new external action
to SHA-pin.
Loading