Skip to content

fix(ts): tsc TS2322 in audit-agencysignature-main-tip — narrow ArgStep.key #887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AceHack merged 2 commits into from
Apr 30, 2026
Merged

fix(ts): tsc TS2322 in audit-agencysignature-main-tip — narrow ArgStep.key #887

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1acd7f8
fix(ts): tsc TS2322 in audit-agencysignature-main-tip — narrow ArgSte…
AceHack Apr 30, 2026
d9eec5b
review(#887): derive StringArgKey from MutableArgs per Copilot
AceHack Apr 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 11 additions & 6 deletions tools/hygiene/audit-agencysignature-main-tip.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,11 +76,6 @@ interface ArgParseResult {
readonly errorMessage: string;
}

type ArgStep =
| { readonly kind: "ok"; readonly key: keyof MutableArgs; readonly value: string; readonly setMode: Mode | null; readonly skip: 1 }
| { readonly kind: "error"; readonly message: string }
| { readonly kind: "help" };

interface MutableArgs {
mode: Mode;
commitSha: string;
Expand All @@ -90,8 +85,18 @@ interface MutableArgs {
v1ShipDate: string;
}

// Derived from MutableArgs so adding/removing string fields cannot drift
// from the ArgStep narrowing. `mode` is set via the parallel `setMode`
// channel, never via key/value.
type StringArgKey = Exclude<keyof MutableArgs, "mode">;

type ArgStep =
| { readonly kind: "ok"; readonly key: StringArgKey; readonly value: string; readonly setMode: Mode | null; readonly skip: 1 }
| { readonly kind: "error"; readonly message: string }
| { readonly kind: "help" };

function classifyArg(arg: string, next: string | undefined): ArgStep {
const requiresNext: Record<string, { key: keyof MutableArgs; setMode: Mode | null; missing: string }> = {
const requiresNext: Record<string, { key: StringArgKey; setMode: Mode | null; missing: string }> = {
"--commit": { key: "commitSha", setMode: "commit", missing: "error: --commit requires SHA" },
"--max": { key: "maxN", setMode: "max", missing: "error: --max requires N" },
"--since": { key: "sinceDate", setMode: "since", missing: "error: --since requires DATE (YYYY-MM-DD)" },
Expand Down
Loading