-
Notifications
You must be signed in to change notification settings - Fork 1
absorb: multi-AI feedback on threading + PR-liveness micro-class (Deepseek + Amara, 2026-04-29 packet 2) #815
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
AceHack
merged 4 commits into
main
from
absorb/multi-ai-2026-04-29-deepseek-amara-threading-and-pr-liveness
Apr 29, 2026
Merged
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
1eebc2c
absorb: multi-AI feedback (Deepseek + Amara) on threading docs + PR-l…
AceHack 86ac80b
absorb round-3: convergent reviewer corrections + B-0102/B-0103 harde…
AceHack fa8b381
fix(B-0103): Copilot P0/P1 — drop unverified literal example + handle…
AceHack 5853d54
fix(round-5 reviewer feedback): bash-shebang declared + fenced-code c…
AceHack File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
111 changes: 111 additions & 0 deletions
111
docs/backlog/P2/B-0103-computed-metadata-discipline-unified-lint-2026-04-29.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,111 @@ | ||
| --- | ||
| id: B-0103 | ||
| priority: P2 | ||
| status: open | ||
| title: Computed-metadata-discipline — unified lint consolidating B-0098 + B-0099 + filename-timestamp drift | ||
| tier: factory-hygiene | ||
| effort: M | ||
| ask: Multi-AI synthesis packet 2026-04-29 (Amara filter — promote individual P3 metadata-drift items to single P2) | ||
| created: 2026-04-29 | ||
| last_updated: 2026-04-29 | ||
| composes_with: [B-0098, B-0099, B-0102] | ||
| tags: [ci-lint, factory-hygiene, derived-metadata, manual-drift-class, mechanical-guard, p2-promotion] | ||
| --- | ||
|
|
||
| # Computed-metadata-discipline — unified lint | ||
|
|
||
| The 2026-04-29 session arc surfaced **three** instances of the | ||
| same failure class — agent-authored metadata that drifted from | ||
| derived truth: | ||
|
|
||
| 1. **Tick-ordinal drift** — shard prose claims "twenty-second tick" | ||
| but file order says twenty-first (B-0098). | ||
| 2. **PR-count drift** — shard prose claims "30 PRs total this | ||
| session arc" but git log says 28 (B-0099). | ||
| 3. **Shard-filename-vs-row-timestamp drift** — shard at | ||
| `0613Z.md` has row timestamp `06:12:50Z` (off-by-one minute, | ||
| caught by Codex P1 on PR #809). | ||
|
AceHack marked this conversation as resolved.
Outdated
|
||
|
|
||
| Three instances in one session is enough signal to consolidate | ||
| the family into a single P2 mechanical guard rather than three | ||
| parallel P3 lints. | ||
|
|
||
| ## Canonical rule | ||
|
|
||
| ```text | ||
| Agent-authored metadata must match derived truth. | ||
| If the truth can be computed, compute it or lint it. | ||
| ``` | ||
|
|
||
| ## Examples (the drift-prone metadata claims this lint covers) | ||
|
|
||
| | Claim | Derived from | | ||
| |---|---| | ||
| | filename timestamp (`HHMMZ.md`) | row timestamp's `HH:MM` | | ||
| | tick ordinal ("twenty-second tick") | sorted shard position in directory | | ||
| | session PR total ("30 PRs") | `gh pr list --search` or `git log` count | | ||
| | branch base ("based on main") | explicit ref SHA | | ||
| | "this is the Nth fix" | git log count of similar commits | | ||
|
|
||
| ## Distilled keepers | ||
|
|
||
| ```text | ||
| Events are written. | ||
| Metadata is computed. | ||
| Claims are checked against derived truth. | ||
| ``` | ||
|
|
||
| ## Implementation sketch (single lint, multiple checks) | ||
|
|
||
| ```bash | ||
| # tools/lint/metadata-drift-check.sh | ||
| # Run on PR diffs touching tick-history shards or backlog rows. | ||
|
|
||
| # Check 1 — filename HHMM matches row timestamp HH:MM | ||
| for shard in $(git diff --name-only "$BASE..$HEAD" -- 'docs/hygiene-history/ticks/**/*.md'); do | ||
| filename_hhmm=$(basename "$shard" .md | grep -oE '^[0-9]{4}Z') | ||
| row_hhmm=$(head -1 "$shard" | grep -oE 'T[0-9]{2}:[0-9]{2}' | tr -d 'T:') | ||
| [[ "${filename_hhmm%Z}" == "$row_hhmm" ]] || warn "$shard: filename $filename_hhmm vs row $row_hhmm" | ||
|
AceHack marked this conversation as resolved.
Outdated
|
||
| done | ||
|
AceHack marked this conversation as resolved.
Outdated
|
||
|
|
||
|
AceHack marked this conversation as resolved.
|
||
| # Check 2 — claimed ordinal matches file position (only when prose contains ordinal words) | ||
| # Check 3 — claimed PR count matches gh / git query (only when prose contains "N PRs total") | ||
| # Check 4 — branch-base claims cite explicit SHA | ||
| ``` | ||
|
|
||
| ## Why P2 (vs three separate P3s) | ||
|
|
||
| The pattern recurred 3x in 24 hours — strong signal it would | ||
| recur again. Single P2 lint: | ||
|
|
||
| - Reduces total surface area (one CI check, one set of regex | ||
| rules, one file to maintain). | ||
| - Catches all four drift sub-classes uniformly. | ||
| - Aligns with Amara's framing: "If metadata can be derived, | ||
| do not trust agent-authored prose." | ||
|
|
||
| P2 (factory hygiene, can-be-deferred but desirable) rather than | ||
| P0/P1 (blocking) because the drift is caught manually within | ||
| 1-2 ticks via review pipeline; the lint accelerates detection | ||
| but doesn't unblock anything currently broken. | ||
|
|
||
| ## Composes with | ||
|
|
||
| - B-0098 (tick-ordinal-continuity lint) — subsumed. | ||
| - B-0099 (PR-count-projection-not-narrated) — subsumed. | ||
| - B-0102 (PR-liveness race) — sibling agent-asserted-state | ||
| discipline. | ||
| - `memory/feedback_bare_main_ambiguity_automation_discipline_explicit_refs_required_amara_2026_04_29.md` | ||
| — same computed-vs-narrated rule at the git-ref layer. | ||
|
|
||
| ## Migration path | ||
|
|
||
| When this P2 lands as active work: | ||
|
|
||
| 1. Implement the single `tools/lint/metadata-drift-check.sh` | ||
| covering all 3+ sub-classes. | ||
| 2. Wire into `.github/workflows/gate.yml` (or sibling). | ||
| 3. Mark B-0098 + B-0099 as superseded-by-B-0103 in their | ||
| frontmatter. | ||
| 4. Remove ordinal-word + PR-count-prose from existing tick | ||
| shards if the lint catches them as drift candidates. | ||
112 changes: 112 additions & 0 deletions
112
...backlog/P3/B-0102-pr-liveness-race-merge-cascade-class-refinement-2026-04-29.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,112 @@ | ||
| --- | ||
| id: B-0102 | ||
| priority: P3 | ||
| status: open | ||
| title: PR-liveness race during merge cascade — micro-class rename + mechanical guard + recovery-note format | ||
| tier: research-grade | ||
| effort: S | ||
| ask: Multi-AI synthesis packet 2026-04-29 (Deepseek + Amara filter on Otto's micro-class) | ||
| created: 2026-04-29 | ||
| last_updated: 2026-04-29 | ||
| composes_with: [B-0103] | ||
| tags: [github-platform, force-push, pr-aliveness, merge-cascade, micro-class-refinement] | ||
| --- | ||
|
|
||
| # PR-liveness race during merge cascade — refinement | ||
|
|
||
| The 2026-04-29 autonomous-loop session arc surfaced a real GitHub | ||
| operational trap: PR #806 was unexpectedly auto-closed by GitHub | ||
| 1 second after PR #808 merged, while #806's branch had been | ||
| freshly rebased + force-pushed. The branch still had 476 lines of | ||
| unique unmerged substrate. The original micro-class name | ||
| `force-push-triggers-pr-auto-close` overclaimed GitHub internals. | ||
|
|
||
| ## Better naming (per Amara's filter) | ||
|
|
||
| ```text | ||
| pr-liveness-race-during-merge-cascade | ||
| ``` | ||
|
|
||
| or empirically: | ||
|
|
||
| ```text | ||
| force-push-during-merge-cascade can collapse PR uniqueness | ||
| ``` | ||
|
|
||
| Reason: the dangerous condition is not force-push alone — it's | ||
| `history rewrite + active base movement + GitHub PR | ||
| reachability/diff computation`. GitHub's "indirect merge" | ||
| detection (head reachable from base = auto-merge marker) can | ||
| race with mid-cascade rebases. | ||
|
|
||
| ## Operational rule | ||
|
|
||
| ```text | ||
| Do not rebase or force-push open tick-history PR branches | ||
| while adjacent auto-merge PRs are landing. | ||
|
|
||
| Branch protection "up-to-date" is a merge-readiness gate. | ||
| PR-aliveness is a separate head/base reachability and diff | ||
| invariant. Do not confuse them. | ||
| ``` | ||
|
|
||
| ## Mechanical guard (before any force-push/rebase of an open PR) | ||
|
|
||
| ```bash | ||
| PR=<number> | ||
|
|
||
| gh pr view "$PR" \ | ||
| --json number,state,headRefName,headRefOid,baseRefName,baseRefOid,mergeStateStatus,isDraft,title \ | ||
| > "/tmp/pr-$PR-before.json" | ||
| git log --oneline "origin/main..HEAD" > "/tmp/pr-$PR-unique-commits-before.txt" | ||
| git diff --stat "origin/main...HEAD" > "/tmp/pr-$PR-diff-before.txt" | ||
|
|
||
| # ... do the rebase / force-push ... | ||
|
|
||
| gh pr view "$PR" \ | ||
| --json number,state,headRefName,headRefOid,baseRefName,baseRefOid,mergeStateStatus,isDraft,title \ | ||
| > "/tmp/pr-$PR-after.json" | ||
| git log --oneline "origin/main..HEAD" > "/tmp/pr-$PR-unique-commits-after.txt" | ||
| git diff --stat "origin/main...HEAD" > "/tmp/pr-$PR-diff-after.txt" | ||
|
AceHack marked this conversation as resolved.
Outdated
|
||
| ``` | ||
|
|
||
| ## Enforcement after the action | ||
|
|
||
| ```text | ||
| If PR state != OPEN: | ||
| stop and recover with successor PR. | ||
|
|
||
| If unique commits == 0 and diff == empty: | ||
| do not force-push again; classify as merged/covered/collapsed. | ||
|
|
||
| If unique commits or diff still exist but PR is closed: | ||
| open successor PR and record old→new mapping. | ||
| ``` | ||
|
|
||
| ## Recovery-note format (when opening a successor PR) | ||
|
|
||
| ```text | ||
| old PR: #<num> | ||
| new PR: #<num> | ||
| branch: <name> | ||
| before head SHA: <sha> | ||
| after head SHA: <sha> | ||
| diff-stat proving remaining content: <output> | ||
| reason reopen failed (if applicable): <message> | ||
| ``` | ||
|
|
||
| ## Why P3 (research-grade, not blocking) | ||
|
|
||
| The trap was caught and recovered (PR #811 successor opened | ||
| within minutes). The mechanical guard would prevent future | ||
| recurrence but isn't blocking. Promote when active drain is | ||
| clear AND the same trap recurs (composition signal). | ||
|
|
||
| ## Composes with | ||
|
|
||
| - B-0103 (computed-metadata-discipline) — same family of | ||
| agent-asserted-state vs derived-truth checks. | ||
| - The auto-merge fix in PR #811 + #814 — the safer alternative | ||
| to manual rebase + force-push during cascade. | ||
| - `memory/feedback_outdated_review_threads_block_merge_resolve_explicitly_after_force_push_2026_04_27.md` | ||
| — sibling force-push-affects-PR rule. | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.