Skip to content

fix(codeql): forward-sync AceHack PR #96 — exclude obj/ and bin/ build artifacts (B-0073) — #97 already-covered#701

Merged
AceHack merged 1 commit intomainfrom
forward-sync/codeql-obj-bin-excludes-and-csharp-test-cast-cleanup-acehack-pr-96-97-2026-04-28
Apr 28, 2026
Merged

fix(codeql): forward-sync AceHack PR #96 — exclude obj/ and bin/ build artifacts (B-0073) — #97 already-covered#701
AceHack merged 1 commit intomainfrom
forward-sync/codeql-obj-bin-excludes-and-csharp-test-cast-cleanup-acehack-pr-96-97-2026-04-28

Conversation

@AceHack
Copy link
Copy Markdown
Member

@AceHack AceHack commented Apr 28, 2026

Summary

Forward-sync of AceHack PR #96 (codeql obj/bin excludes) per the authority rule's classification rubric. PR #97 (csharp test cast cleanup) is ALREADY-COVERED on LFG main — cast removals at tests/Tests.CSharp/CircuitTests.cs and tests/Tests.CSharp/ZSetTests.cs already present, no action needed.

Cherry-picked verbatim:

What this adds

.github/codeql/codeql-config.yml paths-ignore: adds **/obj/** and **/bin/** patterns to skip .NET build artifacts (xunit auto-generated test entry points like XunitAutoGeneratedEntry*.cs + compiler intermediates) from CodeQL scanning. Empirically discovered 2026-04-28 (B-0073): two open csharp alerts on obj/Release/net10.0/XunitAutoGenerated*.cs were gating the LFG code_quality:severity=all ruleset on every PR.

#97 ALREADY-COVERED — verification

Verified via git cherry-pick 0f5812d resulting in "nothing to commit, working tree clean" — the 10 ((int, long)) casts on tuple literals at tests/Tests.CSharp/CircuitTests.cs and tests/Tests.CSharp/ZSetTests.cs already exist on LFG in the cleaned-up state. Per Amara's classification rubric: ALREADY-COVERED → no action.

Composes with

Acceptance

Next forward-sync targets (per Amara's rubric)

🤖 Generated with Claude Code

…is (B-0073) (#96)

CodeQL was scanning .NET build artifacts under obj/ and bin/,
including auto-generated xunit test entry points
(`XunitAutoGeneratedEntry*.cs`). Findings on those files ask
us to fix MSBuild's output, not source — wrong dependency
direction.

Empirically discovered 2026-04-28 while diagnosing why all 6
LFG PRs were BLOCKED with all-green CI: two open
`cs/missed-ternary-operator` alerts on
`obj/Release/net10.0/XunitAutoGenerated*.cs` were among 13
total Code Scanning alerts gating the LFG
`code_quality:severity=all` ruleset on every PR.

This config change drops 2 of 13 alerts via a single
structural change with zero source-code risk. Composes with
B-0073 (which covers the remaining 10 source alerts +
1 Scorecard meta-finding) and task #306 (the original
'Analyze (csharp) on PR' workflow-cost concern, which this
helps reduce by limiting scan scope).

Verification: next CodeQL run on main should report 11 (or
fewer) open alerts instead of 13.

Agency-Signature-Version: 1
Agent: otto
Agent-Runtime: claude-code
Agent-Model: claude-opus-4-7
Credential-Identity: AceHack-shared
Credential-Mode: shared-with-aaron
Human-Review: not-implied-by-credential
Human-Review-Evidence: aaron-explicit-ask
Action-Mode: autonomous-fail-open
Task: B-0073-step-1-codeql-exclude-build-artifacts
Copilot AI review requested due to automatic review settings April 28, 2026 23:04
@AceHack AceHack enabled auto-merge (squash) April 28, 2026 23:04
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the repo’s CodeQL configuration to stop analyzing .NET build output directories that produce generated C# sources and false-positive alerts, unblocking CodeQL gating for PRs.

Changes:

  • Extend .github/codeql/codeql-config.yml paths-ignore to exclude **/obj/** and **/bin/**.
  • Document the rationale for excluding these build artifact directories (generated xUnit scaffolding and compiler intermediates).

Comment thread .github/codeql/codeql-config.yml
@AceHack AceHack merged commit 817e59c into main Apr 28, 2026
28 checks passed
@AceHack AceHack deleted the forward-sync/codeql-obj-bin-excludes-and-csharp-test-cast-cleanup-acehack-pr-96-97-2026-04-28 branch April 28, 2026 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants