Conversation
….yml + resume-diff.yml Theme A of the AceHack/LFG 0/0/0 reconciliation map per `docs/0-0-0-readiness/CLASSIFICATION.md`. Substantive change: pure surgical substitution of ubuntu-22.04 → ubuntu-24.04 in 8 locations across 2 workflow files. No structural changes, no other content imported. Aaron 2026-04-28 directive: 'we better not be using that old version of ubuntu' + Otto-247 version-currency rule (ubuntu-latest = 24.04 since Jan 2025). Why surgical not whole-file copy: the AceHack version of resume-diff.yml also REVERTED an LFG-side Codex P1 fix (REST integer comment_id vs GraphQL node ID for PATCH endpoint). Whole-file copy would re-introduce that regression. Per the hard-defect-response rule landed in PR #695: when classification reveals bidirectional content, surgical-extract the wanted change only. Closes Theme A from PR #695's reconciliation map. Two themes remain: Theme B (tick-history continuity) + Theme C (expected snapshot).
There was a problem hiding this comment.
Pull request overview
Updates CI runner labels to Ubuntu 24.04 for the “Theme A” 0/0/0 reconciliation work, keeping the workflows aligned with the repo’s “no -latest” runner pin discipline.
Changes:
- Switches
runs-oningate.ymllint jobs fromubuntu-22.04toubuntu-24.04. - Switches
runs-oninresume-diff.ymlfromubuntu-22.04toubuntu-24.04. - Updates nearby workflow comments that mention the runner version.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| .github/workflows/resume-diff.yml | Updates runner label (and related comment) for the resume-diff helper workflow. |
| .github/workflows/gate.yml | Updates runner labels for multiple lint jobs (and related comments) in the PR gate workflow. |
Two valid Copilot P1 catches: 1. resume-diff.yml line 37: 'digest-pinned' was a misleading security/supply-chain claim — ubuntu-24.04 is just an OS label, not a digest pin. Reworded to 'pinned to ubuntu-24.04 (not -latest, so OS image changes are explicit and tracked)'. 2. gate.yml line 322: my sed substitution propagated ubuntu-22.04 to ubuntu-24.04 in a comment that was specifically describing the OLD runner's behavior (shellcheck pre-installed on ubuntu-22.04). Reverted that specific historical reference to ubuntu-22.04 + added a forward-looking note that the same parity concern applies on ubuntu-24.04. Pure comment fixes — no functional change. The ubuntu-24.04 runner change itself is unaffected. Both findings are pre-existing inaccuracies that my surgical bump propagated without sweeping. Not regressions introduced by this PR (the 'digest-pinned' wording predates), but the fix is right either way per Copilot P1.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Theme A of the AceHack/LFG 0/0/0 reconciliation per
docs/0-0-0-readiness/CLASSIFICATION.md.Pure surgical substitution: ubuntu-22.04 → ubuntu-24.04 in 8 locations across 2 workflow files. No structural changes; no whole-file copy.
Why surgical: the AceHack version of resume-diff.yml also reverted an LFG-side Codex P1 fix (REST integer comment_id vs GraphQL node ID). Whole-file copy would re-introduce that regression. Per the hard-defect-response rule in PR #695, surgical-extract is correct.
Aaron 2026-04-28: 'we better not be using that old version of ubuntu' + Otto-247 version-currency.
Closes Theme A. Themes B + C follow.