Skip to content

ci(gate): macos-26 back to PR cadence (Aaron 2026-04-28)#657

Closed
AceHack wants to merge 2 commits intoLucent-Financial-Group:mainfrom
AceHack:fix/macos-back-to-pr-cadence
Closed

ci(gate): macos-26 back to PR cadence (Aaron 2026-04-28)#657
AceHack wants to merge 2 commits intoLucent-Financial-Group:mainfrom
AceHack:fix/macos-back-to-pr-cadence

Conversation

@AceHack
Copy link
Copy Markdown
Member

@AceHack AceHack commented Apr 28, 2026

Summary

Maintainer 2026-04-28: "mac is less than that too so we might as wel move that back form per merge to per pr, i think that means only low memory is per merge now."

Moves macos-26 from push-to-main-only back to PR cadence. The 25-min duration concern that originally moved it was an outlier (cold-cache from earlier era; current cache pins handle it — last 50 codeql.yml runs all < 5 min total).

Changes

Cadence after this lands

Event Legs
PR + merge_group ubuntu-24.04, ubuntu-24.04-arm, macos-26
Push-to-main + workflow_dispatch + windows-2025, windows-11-arm (continue-on-error: true)
low-memory.yml (separate workflow) ubuntu-slim on push-to-main + nightly

Cost impact

Zero — standard GitHub-hosted runners are free for public repos (Otto-210 / Otto-249).

Test plan

  • markdownlint passes
  • actionlint passes on gate.yml
  • github-settings-drift workflow goes from flagging-gap to passing (expected.json now matches live branch protection's required_status_checks)

🤖 Generated with Claude Code

Maintainer 2026-04-28: "mac is less than that too so we might as
wel move that back form per merge to per pr, i think that means
only low memory is per merge now."

Changes:
- gate.yml matrix-setup: pull_request + merge_group now include
  macos-26 alongside ubuntu legs (was Linux-only). Push-to-main +
  workflow_dispatch unchanged (still get full set + Windows).
- expected.json required_status_checks: add `build-and-test (macos-26)`
  back. Was removed in Lucent-Financial-Group#651 when macOS was on per-merge only;
  now that it's PR-cadence, the gate makes sense again.

Cadence after this lands:
- PR + merge_group: ubuntu-24.04, ubuntu-24.04-arm, macos-26
- Push-to-main / workflow_dispatch: + windows-2025, windows-11-arm
- ubuntu-slim (low-memory.yml): push-to-main + nightly schedule
- Windows experimental: continue-on-error: true (peer-harness pending)

Cost impact: zero — standard GitHub-hosted runners are free for
public repos (Otto-210 / Otto-249).

Duration verification (pre-disable codeql.yml era, last 50 runs
2026-04-28): no codeql.yml run > 5 min total wall-clock; recent
code-PR breakdown was Path gate 52s + 4 Analyze legs 51s-2m58s.
The 25-min concern that originally moved macOS to per-merge was
an outlier (cold-cache from earlier era; current cache pins
handle it).

Branch protection live state untouched (still has macos-26 in
required_status_checks per Lucent-Financial-Group#651's deliberate non-touch). The
github-settings-drift workflow will go from flagging the gap
(expected != live) to passing (both equal) after this lands.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Copilot AI review requested due to automatic review settings April 28, 2026 00:48
AceHack added a commit to AceHack/Zeta that referenced this pull request Apr 28, 2026
… re-enabled + 3 empty-retriggers + LFG Lucent-Financial-Group#657 macOS-PR-cadence

Multi-action tick: disabled default Code Scanning via API,
re-enabled codeql.yml advanced workflow (no more conflict),
pushed empty-commits to retrigger CI on Lucent-Financial-Group#655/Lucent-Financial-Group#656/#72, opened
LFG Lucent-Financial-Group#657 to move macos-26 from per-merge back to PR cadence.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Moves the macos-26 build-and-test leg back into the pre-merge (PR + merge_group) gate cadence and updates the expected branch-protection snapshot to require that status check again.

Changes:

  • Update gate.yml matrix selection so PR + merge_group include macos-26 alongside the Ubuntu legs.
  • Re-add build-and-test (macos-26) to the required status checks snapshot (github-settings.expected.json).

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
.github/workflows/gate.yml Expands the pre-merge build matrix to include macos-26.
tools/hygiene/github-settings.expected.json Updates expected required status checks to include build-and-test (macos-26).

Comment thread .github/workflows/gate.yml
Comment thread .github/workflows/gate.yml Outdated
AceHack added a commit to AceHack/Zeta that referenced this pull request Apr 28, 2026
…anded; Lucent-Financial-Group#657 opened

Aaron surfaced visibility-first principle for autonomous
shared-state changes; clarified org-admin scope is LFG only.
Filed binding memory at user-scope. Also opened LFG Lucent-Financial-Group#657
(macOS-26 back to PR cadence + expected.json sync).

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
… header comments + correct workflow citation

Copilot review on PR Lucent-Financial-Group#657 caught two doc/code-mismatches:

1. The matrix-setup header citation said "~3 min total codeql.yml
   run on recent code-PR" as duration justification for adding
   macos-26 to the gate matrix. But this is gate.yml, not codeql.yml
   — the cited duration is for a different workflow. Replaced with
   gate.yml-specific evidence: "recent build-and-test job durations
   are typically 1-3 min on cached runners."

2. The build-and-test job header still claimed macos-26 "Runs only
   on push-to-main + schedule + workflow_dispatch" + Windows legs
   "same cadence as macos-26 (not on PR)" — both stale after the
   matrix-setup change. Updated to reflect the new cadence:
   - macos-26: PR + merge_group + push-to-main (with note on the
     2026-04-28 duration verification that justified the move)
   - Windows: push-to-main / workflow_dispatch only (unchanged
     from prior, but no longer cross-references macos-26)

Resolves both Copilot threads.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
AceHack added a commit to AceHack/Zeta that referenced this pull request Apr 28, 2026
…review fixes (header sync + workflow-citation correction)

Real Copilot findings on PR Lucent-Financial-Group#657: stale build-and-test header
+ wrong workflow cited in matrix-setup header. Both fixed,
threads resolved. Filed flaky-infra-retry as 8th class in the
thread-resolution taxonomy.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
AceHack added a commit to AceHack/Zeta that referenced this pull request Apr 28, 2026
…isable

Default code-scanning was re-enabled at 2026-04-28T00:55:38Z
(approximately 1 hour after the prior session disabled it),
blocking 3 PRs (Lucent-Financial-Group#658/Lucent-Financial-Group#657/Lucent-Financial-Group#655) with the same advanced-vs-default
conflict. Re-applied disable per earlier full-delegation; CI
rerunning. Surfaces the recurrence pattern + likely root cause
(org-config auto-attachment from duplicate "Code Scanning enabled"
configs 244998/245000/245012, pending per-ID-auth deletion).

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
AceHack added a commit that referenced this pull request Apr 28, 2026
LFG main's gate.yml uses dynamic matrix-setup that excludes macos-26
from pull_request + merge_group events ("Linux production legs
only"). Branch protection on main requires `build-and-test (macos-26)`
as a status check, so every LFG PR is structurally BLOCKED.

Aaron's correction (2026-04-28T16:30Z): "we pull out mac and codeql
to merge to main time instead of per pr, and then moved it back to
per pr, I think you just have some staleness and not update to date
with the move back to per per".

This PR makes the surgical edit: matrix-setup's PR/merge_group
branch now outputs `[ubuntu-24.04, ubuntu-24.04-arm, macos-26]`
(was `[ubuntu-24.04, ubuntu-24.04-arm]`). Comment updated to
reflect the cadence change.

Initial draft full-file copy from AceHack was correctly flagged by
Codex P2: AceHack's gate.yml has the older Semgrep bootstrap
(`pip install semgrep`) while LFG already migrated to mise-pinned
`pipx:semgrep` via three-way-parity install.sh (resolves Scorecard
PinnedDependenciesID #17/#18). LFG's improvement preserved by
basing this surgical patch on LFG main rather than AceHack.

Composes with:
- PR #657 (originally-queued forward-sync — becomes redundant)
- task #306 (cadence-fast revisit)
- BLOCKED LFG queue: #655..#666 awaiting this unblock

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
AceHack added a commit that referenced this pull request Apr 28, 2026
…al) (#666)

LFG main's gate.yml uses dynamic matrix-setup that excludes macos-26
from pull_request + merge_group events ("Linux production legs
only"). Branch protection on main requires `build-and-test (macos-26)`
as a status check, so every LFG PR is structurally BLOCKED.

Aaron's correction (2026-04-28T16:30Z): "we pull out mac and codeql
to merge to main time instead of per pr, and then moved it back to
per pr, I think you just have some staleness and not update to date
with the move back to per per".

This PR makes the surgical edit: matrix-setup's PR/merge_group
branch now outputs `[ubuntu-24.04, ubuntu-24.04-arm, macos-26]`
(was `[ubuntu-24.04, ubuntu-24.04-arm]`). Comment updated to
reflect the cadence change.

Initial draft full-file copy from AceHack was correctly flagged by
Codex P2: AceHack's gate.yml has the older Semgrep bootstrap
(`pip install semgrep`) while LFG already migrated to mise-pinned
`pipx:semgrep` via three-way-parity install.sh (resolves Scorecard
PinnedDependenciesID #17/#18). LFG's improvement preserved by
basing this surgical patch on LFG main rather than AceHack.

Composes with:
- PR #657 (originally-queued forward-sync — becomes redundant)
- task #306 (cadence-fast revisit)
- BLOCKED LFG queue: #655..#666 awaiting this unblock

Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>
@AceHack
Copy link
Copy Markdown
Member Author

AceHack commented Apr 28, 2026

Superseded by PR #666 which landed the same fix (gate.yml: macos-26 back to per-PR cadence) with a surgical patch (15+/14- vs full-file copy). PR #666 merged 2026-04-28T16:16:40Z; this PR's intent is fully delivered. Closing as redundant.

@AceHack AceHack closed this Apr 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants