Conversation
…ded by #623) Per Otto-250 (PR review comments + responses + resolutions are high-quality training signals) + task #268 (backfill drain-logs for this session's drained PRs). #622 was closed/superseded by #623 due to stale-local-main causing immediate DIRTY at PR-open. Substrate fully preserved via clean-reapply pattern (4th use this session). Drain-log captures: - Outcome class: CLOSED-NOT-MERGED (superseded) - Why DIRTY: stale-local-main (sub-rule of Otto-348 verify-substrate-exists; verify-base-is-current-before-branching) - Pattern observation: clean-reapply 4-times-validated this session - Composes-with: Otto-238 / Otto-250 / Otto-348 Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
There was a problem hiding this comment.
Pull request overview
Adds a PR-preservation drain log documenting why PR #622 was closed-not-merged and how its content was preserved via the clean-reapply pattern in #623.
Changes:
- Add
docs/pr-preservation/622-drain-log.mdcapturing outcome class, DIRTY cause (stale local main), and preservation/recovery steps. - Record pattern observations for future “verify base is current before branching” discipline.
| earlier. The verify-before-deferring rule (CLAUDE.md) | ||
| has a sibling: **verify-base-is-current-before-branching**. | ||
| This is implicit in good git workflow but not always | ||
| actively applied by autonomous-loop agents that | ||
| prioritize speed over freshness checks. Worth a memory | ||
| entry as a sub-rule of Otto-348 (verify-substrate-exists). |
There was a problem hiding this comment.
The sibling rule name is introduced here as verify-base-is-current-before-branching, but later in this doc it’s referred to as verify-base-is-current. Pick one canonical name and use it consistently throughout the drain log so future readers don’t treat these as two separate rules.
| `gh pr close` preserves the underlying branch + commit) | ||
| - Otto-250 PR-reviews-are-training-signals (this drain-log is | ||
| the training data persistence layer) | ||
| - Otto-348 verify-substrate-exists (sibling: verify-base-is-current) |
There was a problem hiding this comment.
This bullet references the sibling as "verify-base-is-current", but earlier the same concept is named "verify-base-is-current-before-branching". Align this wording with the earlier mention to avoid creating two near-duplicate rule names in the corpus.
| - Otto-348 verify-substrate-exists (sibling: verify-base-is-current) | |
| - Otto-348 verify-substrate-exists (sibling: verify-base-is-current-before-branching) |
Summary
Single-file drain-log per Otto-250 + task #268. #622 was closed-not-merged this session (superseded by #623 via clean-reapply pattern after stale-local-main bit me).
What this captures
Composes with
Test plan