fix(ci): symmetry test — Windows dispositions for #6123 local-LLM deps (unbreak main)#6127
Merged
AceHack merged 1 commit intoMay 30, 2026
Conversation
…s (unbreak main) #6123 (local-LLM harvest) added zstd/libicu74/libssl3t64/libgssapi-krb5-2/tzdata (apt) + ollama (brew) with no Windows dispositions, so manifest-symmetry.test.ts (merged in Slice 2a) now fails on main — the test correctly catching the OS drift. Add the dispositions: - Linux runtime libs (libicu74/libssl3t64/libgssapi-krb5-2/tzdata/zstd) -> Windows provides them natively (ICU / Schannel / SSPI / OS timezone data / in-box tar zstd) -> exceptions. - ollama -> cross-platform incl. Windows (scoop / winget Ollama.Ollama), but its Windows rollout is a local-LLM-substrate decision -> deferred exception (like hermes-agent). Symmetry test 3/3 + tsc clean. This is the test doing its job (forcing a conscious Windows disposition for each new Unix tool); the fix is additive dispositions, not loosening the test. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
There was a problem hiding this comment.
Pull request overview
Fixes CI breakage in tools/ci/manifest-symmetry.test.ts by adding explicit Windows dispositions (as allowlisted exceptions) for new apt/brew dependencies introduced by #6123, keeping the symmetry test strict while documenting intentional OS differences.
Changes:
- Add Windows exception entries for
zstd,libicu74,libssl3t64,libgssapi-krb5-2,tzdata, andollama. - Document why these dependencies don’t (currently) require entries in
tools/setup/manifests/windows.
AceHack
deleted the
otto-windows/fix-symmetry-exceptions-local-llm-2026-05-30
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#6123 (local-LLM harvest) added
zstd/libicu74/libssl3t64/libgssapi-krb5-2/tzdata(apt) +ollama(brew) with no Windows dispositions, somanifest-symmetry.test.ts(merged in Slice 2a) now fails on main — the test correctly catching the OS drift it was built to catch.Fix = additive dispositions (not loosening the test):
libicu74/libssl3t64/libgssapi-krb5-2/tzdata/zstd) -> Windows provides them natively (ICU / Schannel / SSPI / OS timezone data / in-box tar zstd) -> exceptions.ollama-> cross-platform incl. Windows (scoop/winget Ollama.Ollama), but its Windows rollout is a local-LLM-substrate decision -> deferred exception (likehermes-agent).Symmetry test 3/3 + tsc clean. (Flagging:
ollama+hermes-agentWindows install treatment is an open local-LLM-substrate decision.)🤖 Generated with Claude Code