[codex] Enforce uppercase shell retirement inventory extensions#5787
Conversation
…irement guard maintenance Co-Authored-By: Codex <noreply@openai.com> Codex-Origin: codex-launchd-loop Codex-Surface: codex-background-service Codex-Loop-Run-Id: 20260528T105110Z
…main Co-Authored-By: Codex <noreply@openai.com>
Co-Authored-By: Codex <noreply@openai.com> Codex-Origin: codex-launchd-loop Codex-Surface: codex-background-service Codex-Loop-Run-Id: 20260528T112143Z
Co-Authored-By: Codex <noreply@openai.com> Codex-Origin: vera-desktop-loop Codex-Surface: desktop-heartbeat Codex-Loop-Run-Id: 20260528T112945Z
Co-Authored-By: Codex <noreply@openai.com> Codex-Origin: codex-launchd-loop Codex-Surface: codex-background-service Codex-Loop-Run-Id: 20260528T113659Z
…-retirement-inventory-guard-20260528
Treat shell-family file extension detection as case-insensitive so tracked .SH/.BASH/.ZSH/.KSH/.COMMAND files cannot bypass the bash-retirement guard. Update the TS/Bun trajectory wording and coverage. Co-Authored-By: Codex <noreply@openai.com> Codex-Origin: codex-launchd-loop Codex-Surface: codex-background-service Codex-Loop-Run-Id: 20260528T122248Z
Co-Authored-By: Codex <noreply@openai.com> Codex-Origin: codex-launchd-loop Codex-Surface: codex-background-service Codex-Loop-Run-Id: 20260528T122248Z
Release the headless Codex claim after landing the uppercase shell-extension inventory guard slice in this branch. Surface: codex-background-service. Origin: codex-launchd-loop. Run-Id: 20260528T122248Z. Co-Authored-By: Codex <noreply@openai.com> Codex-Origin: codex-launchd-loop Codex-Surface: codex-background-service Codex-Loop-Run-Id: 20260528T122248Z
There was a problem hiding this comment.
Pull request overview
This PR tightens the check-bash-retirement-inventory hygiene guard so it correctly classifies shell-family files even when their extensions are uppercase (e.g., .SH, .BASH), preventing uppercase-extension drift from bypassing the inventory enforcement.
Changes:
- Make shell-family extension detection case-insensitive by comparing against a lowercased path.
- Add a focused regression test covering uppercase variants for the shell-family extensions.
- Update the TypeScript/Bun migration trajectory resume to document that uppercase variants are included in the guard.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tools/hygiene/check-bash-retirement-inventory.ts | Detect shell-family extensions case-insensitively to avoid uppercase bypass. |
| tools/hygiene/check-bash-retirement-inventory.test.ts | Add regression fixtures/expectations for uppercase shell extension variants. |
| docs/trajectories/typescript-bun-migration/RESUME.md | Document that uppercase shell extension variants are treated as in-scope drift. |
Address Copilot review on PR #5787 by updating the edited trajectory resume metadata. Co-Authored-By: Codex <noreply@openai.com> Codex-Origin: vera-desktop-loop Codex-Surface: desktop-heartbeat Codex-Loop-Run-Id: 20260528T123316Z
|
The changes to make the shell extension check case-insensitive are correct and the addition of regression tests is good practice. This is a valuable hygiene improvement. The check is failing. It appears this change requires a corresponding backlog item to be referenced in the commit message or documentation, which seems to be missing. Please address the failing check so this can be taken out of draft and merged. |
|
Background Codex status for #5787 — 2026-05-28T13:44Z I inspected the failed
This PR does not touch Current blocker: wait for #5800 ( Provenance:
|
|
Vera status for #5787 - 2026-05-28T15:23Z I inspected the rerun of Local verification in the dedicated #5787 worktree after the #5844 fix:
I did not push the local worktree state because it currently contains an unpushed Lior-authored merge commit ( |
Co-Authored-By: Codex <noreply@openai.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Summary
Validation
bun test tools/hygiene/check-bash-retirement-inventory.test.ts(18 pass, 0 fail)Notes
20260528T122248Z.