docs(provisioning): document new interactive zeta-install.sh flow + B-0852 cred-blob substrate + subsequent-boot restore (composes with PRs #5635 + #5637 + #5638 + #5639 + #5640)#5641
Merged
AceHack merged 1 commit intoMay 27, 2026
Conversation
… + B-0852 cred-blob substrate + subsequent-boot restore — reflects PRs #5635 + #5637 + #5638 + #5639 + #5640 substrate now operator-facing Operator pain point context: PROVISIONING.md was written before the B-0852 cred-blob substrate + B-0857.2 cluster-type menu landed; the doc still described the bare HOST free-text prompt + had nothing about the cred-blob substrate. Operators reading this doc had no way to discover the new substrate they were going to encounter on next install. THIS COMMIT adds two new sub-sections to "Step 4: boot the box on the USB": ### Interactive zeta-install.sh flow (Step 4 expansion) Documents the 7 prompts in order that the operator sees when running zeta-install.sh interactively: 1. iter-5.3 initial password (Step 6.55) 2. B-0852.3b cred-blob passphrase (Step 6.56; default-on per B-0852.3c since 2026-05-27) 3. iter-5.2 hostname injection (Step 6.6) 4. iter-5.1 WiFi persistence (Step 6.7) 5. iter-5.4.0 homelab gh-auth (Step 6.8) 6. Cluster-type menu (Step 6 host-attribute selection; B-0857.2 per PR #5635 since 2026-05-27) — numbered menu with lspci-based hardware-detection suggested default 7. Step 6.95-picker cred-blob picker (B-0852.3c default-on with 4-path opt-out) ### Subsequent-boot credential restore (B-0852.4 — operator pain point closure) Documents the systemd-ask-password prompt on tty1 at each boot + the zeta-creds-restore.service flow + per-host opt-out paths (enable=false; passphraseMode=file for headless). Composes with: - PR #5635 (cluster-type menu + lspci hardware detection) - PR #5637 (B-0852.3a-prep USB UUID capture) - PR #5638 (B-0852.3b passphrase prompt + unset-after-picker) - PR #5639 (B-0852.3c picker default-on with 4-path opt-out) - PR #5640 (B-0852.4 restore-service default-on with interactive mode; CLOSES THE LOOP at installed-system-boot scope) - full-ai-cluster/INJECTION-POINTS.md (sibling injection-points catalog; this commit is the operator-facing PROVISIONING-side documentation that the catalog references at architectural scope) Doc-only commit; no code paths touched; no zeta-install.sh edits (stays out of the way of the 3 in-flight zeta-install.sh PRs). Per operator 2026-05-27 multi-message direction: ships during operator-offline window per the autonomous-loop's purpose. Co-Authored-By: Claude <noreply@anthropic.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
There was a problem hiding this comment.
Pull request overview
Doc-only update to full-ai-cluster/PROVISIONING.md adding a 7-step walkthrough of the new interactive zeta-install.sh flow plus a section describing subsequent-boot credential restore behavior, reflecting the B-0852 cred-blob substrate landing across PRs #5635/#5637/#5638/#5639/#5640.
Changes:
- Added "Interactive
zeta-install.shflow" subsection enumerating 7 prompts (password, cred-blob passphrase, hostname, WiFi, gh-auth, cluster-type menu, picker). - Added "Subsequent-boot credential restore (B-0852.4)" subsection describing
zeta-creds-restore.servicebehavior and per-host opt-out paths.
3 tasks
AceHack
added a commit
that referenced
this pull request
May 27, 2026
…inding on #5640 — restore service never fired) (#5644) * fix(b-0852.4): correct cred-blob default path /esp → /boot to match installed-system ESP mount (Copilot finding on #5640) PR #5640 shipped credsRestore.enable=true with blobPath defaulting to `/esp/zeta-creds.enc`. Copilot review flagged the substrate-honest bug: - At INSTALL-TIME (live USB), zeta-install.sh's Step 6.95-picker writes the blob to `/esp/zeta-creds.enc` because the live installer mounts the target ESP at `/esp` - POST-REBOOT, disko (`disko-shapes/2nvme.nix`) mounts the SAME ESP partition at `/boot` per `mountpoint = "/boot"` - The blob is the same physical file on the same ESP partition, but the mount path differs by context The restore service runs POST-REBOOT, where the file is at `/boot/zeta-creds.enc` — NOT `/esp/zeta-creds.enc`. So: - ConditionPathExists = "/esp/zeta-creds.enc" always evaluates FALSE on the installed system (`/esp` doesn't exist post-reboot) - systemd silently skips the unit (condition unmet) - restore-from-cred-blob NEVER FIRES on any installed node - creds are never restored at boot - operator has to manually re-enter every credential each reboot — which is exactly the pain point the whole B-0852 cascade was designed to solve This commit changes the default to `/boot/zeta-creds.enc` so the service can actually find the blob it's supposed to decrypt. Also expands the option description to explain the install-vs-installed mount-path distinction so future maintainers don't reintroduce the same confusion. No changes to zeta-install.sh: the install-time write to `/esp/zeta-creds.enc` is correct for the install-time context; disko's later remount-as-/boot is what makes the file accessible at the new path. Validation: - `nix-instantiate --parse zeta-creds-restore.nix` parses clean (no syntax change; only literal value + description text) - Substrate-honest: this is a single-line semantic fix; the multi-line description expansion is wake-time substrate for the next maintainer who edits this module Composes with #5640 (the row that surfaced the issue), #5643 (passphrase-env supersede), and the B-0852 cred-persistence cascade (#5635 + #5637 + #5638 + #5639 + #5640 + #5641 + #5642). Addresses CRITICAL Copilot finding on #5640. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com> * fixup(b-0852.4): producer-side /esp → /mnt/boot + clean option doc (Copilot threads on #5644) P1 — producer-side path mismatch ALSO needs fixing Prior commit fixed CONSUMER (restore service) but PRODUCER (Step 6.95-picker) was writing to /esp/zeta-creds.enc — which doesn't correspond to any mount. Target ESP is mounted at /mnt/boot during install (zeta-install.sh:226). Blob was landing on live USB rootfs, not target ESP. Reboot lost it. Fix: picker --output /esp/zeta-creds.enc → /mnt/boot/zeta-creds.enc. Producer now writes to target ESP mount, disko remounts as /boot post-reboot. Same physical file at two mount paths bridges the install-vs-installed boundary. P2 — option doc style: strip PR-review history attribution Prior commit included "caught by Copilot review on PR #5640" in option doc. Repo convention: code/current-state docs use role-neutral present-tense contract text; PR-review history lives in commit messages + history surfaces. Fix: rewrite doc as present-tense contract for the option (what it configures + install-vs-installed mount convention for operators using non-default ESP layouts). Validation: bash -n OK. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com> --------- Co-authored-by: Lior <lior@zeta.dev> Co-authored-by: Claude <noreply@anthropic.com>
AceHack
pushed a commit
that referenced
this pull request
May 27, 2026
…D018 fix (Copilot 6 threads on #5648) Comprehensive accuracy rewrite addressing all 6 Copilot findings: 1. "no more re-entering" overclaim — passphraseMode=interactive DOES prompt every boot via systemd-ask-password. Reframed accurately: N per-tool login flows → ONE cred-blob passphrase. The improvement is atomicity, not zero typing. 2. Install log lines mismatch — restored to match actual zeta-install.sh output (Step 6.56 + Step 6.95-picker actual strings). 3. /boot path correctness — preserved (#5644 already fixed producer/consumer alignment to /mnt/boot ↔ /boot). 4. Manifest coverage — included gemini + codex paths (~/.gemini/oauth_creds.json, ~/.codex/auth.json) plus the full default-manifest table. 5. Second-reboot expectation — corrected: interactive mode prompts every boot by design. Operator who wants no-prompt-at-boot can switch to passphraseMode="file" (with security tradeoff named). 6. Filename reference — zeta-creds-cli.ts → zeta-creds-manifest.ts (actual canonical location of defaultManifest). Also fixes MD018 lint failure: line "#5639 + #5640 + #5643 + #5644 +" was being parsed as an ATX heading because # was at column 1. Replaced the line-wrapped PR-number prose with the default-manifest table (more useful + no MD018 trigger). Composes with: - B-0852 cred-persistence cascade (PRs that ACTUALLY ship: #5635, #5637, #5639, #5640, #5641, #5642, #5644, #5645, #5646, #5648, #5649, #5650; #5638 + #5643 were superseded → closed without merge) - common.nix passphraseMode=interactive default (PR #5640) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
AceHack
added a commit
that referenced
this pull request
May 27, 2026
…o-end verification checklist for operator) (#5648) * docs(provisioning): add cred-restore smoke-test section — first-boot + post-reboot + second-reboot verification + troubleshooting table (B-0852 end-to-end) The B-0852 cred-persistence cascade (PRs #5635 + #5637 + #5638 + #5639 + #5640 + #5643 + #5644 + #5646) closes the operator's 'don't re-enter creds over and over' pain point. This docs addition gives operators a concrete checklist to verify the full path works after a fresh USB install: - First-boot verification: what install log lines to look for - Post-reboot verification: systemctl + ls + auth-status commands - Second-reboot verification: confirm no re-entry needed - Troubleshooting table: 4 common symptoms with likely causes Closes the gap between 'cascade is shipped' and 'operator can confirm cascade works on their hardware'. The operator no longer has to figure out which systemd unit to query or which paths to check — the checklist names them. Composes with: - PROVISIONING.md (existing operator-facing install doc) - B-0852 cred-persistence substrate - The audit-extension PR (separate; catches drift at CI time) Substrate-honest scope: this is operator docs, not a TS tool. A follow-on TS smoke-test runner (run on the installed system to auto-verify the checklist) is a candidate for follow-up work but out of scope for this commit. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com> * fixup(docs): rewrite cred-restore smoke-test section for accuracy + MD018 fix (Copilot 6 threads on #5648) Comprehensive accuracy rewrite addressing all 6 Copilot findings: 1. "no more re-entering" overclaim — passphraseMode=interactive DOES prompt every boot via systemd-ask-password. Reframed accurately: N per-tool login flows → ONE cred-blob passphrase. The improvement is atomicity, not zero typing. 2. Install log lines mismatch — restored to match actual zeta-install.sh output (Step 6.56 + Step 6.95-picker actual strings). 3. /boot path correctness — preserved (#5644 already fixed producer/consumer alignment to /mnt/boot ↔ /boot). 4. Manifest coverage — included gemini + codex paths (~/.gemini/oauth_creds.json, ~/.codex/auth.json) plus the full default-manifest table. 5. Second-reboot expectation — corrected: interactive mode prompts every boot by design. Operator who wants no-prompt-at-boot can switch to passphraseMode="file" (with security tradeoff named). 6. Filename reference — zeta-creds-cli.ts → zeta-creds-manifest.ts (actual canonical location of defaultManifest). Also fixes MD018 lint failure: line "#5639 + #5640 + #5643 + #5644 +" was being parsed as an ATX heading because # was at column 1. Replaced the line-wrapped PR-number prose with the default-manifest table (more useful + no MD018 trigger). Composes with: - B-0852 cred-persistence cascade (PRs that ACTUALLY ship: #5635, #5637, #5639, #5640, #5641, #5642, #5644, #5645, #5646, #5648, #5649, #5650; #5638 + #5643 were superseded → closed without merge) - common.nix passphraseMode=interactive default (PR #5640) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com> --------- Co-authored-by: Lior <lior@zeta.dev> Co-authored-by: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Doc-only commit that updates PROVISIONING.md to reflect the cred-blob substrate landing today. Adds 7-step interactive flow walkthrough + subsequent-boot restore section + per-host opt-out paths. No code paths touched; no zeta-install.sh edits (stays out of the way of the 3 in-flight zeta-install.sh PRs). Composes with PR #5635/#5637/#5638/#5639/#5640.
🤖 Generated with Claude Code