Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,68 @@
---
pr_number: 5617
title: "docs(archive): Batch archive of 20 PRs"
author: "AceHack"
state: "MERGED"
created_at: "2026-05-27T19:38:16Z"
merged_at: "2026-05-27T19:42:24Z"
closed_at: "2026-05-27T19:42:24Z"
head_ref: "lior/batch-archive-2026-05-27-14"
base_ref: "main"
archived_at: "2026-05-27T20:03:55Z"
archive_tool: "tools/pr-preservation/archive-pr.ts"
---

# PR #5617: docs(archive): Batch archive of 20 PRs

## PR description

Automated batch archival of 20 PRs to preserve discussion and context, and to reduce PR queue noise.

## Reviews

### COMMENTED — @copilot-pull-request-reviewer (2026-05-27T19:40:46Z)

## Pull request overview

This PR adds a batch of archived PR discussion transcripts under `docs/pr-discussions/` (generated by `tools/pr-preservation/archive-pr.ts`) to preserve PR context outside GitHub and reduce queue noise.

**Changes:**
- Adds 20 new `docs/pr-discussions/PR-<number>-<slug>.md` archive files.
- Each archive includes YAML frontmatter (PR metadata) plus the PR body and review-thread/general-comment snapshots.

### Reviewed changes

Copilot reviewed 20 out of 20 changed files in this pull request and generated no comments.

<details>
<summary>Show a summary per file</summary>

| File | Description |
| ---- | ----------- |
| docs/pr-discussions/PR-5255-docs-shadow-add-lesson-about-otto-and-riven-paralysis.md | Adds the preserved discussion archive for PR #5255. |
| docs/pr-discussions/PR-5251-fix-postmerge-5235-3-copilot-findings-iso-workflow-path-trig.md | Adds the preserved discussion archive for PR #5251. |
| docs/pr-discussions/PR-5243-docs-tick-1731z-otto-bg-pr-triage-forward-signal-3-peer-lior.md | Adds the preserved discussion archive for PR #5243. |
| docs/pr-discussions/PR-5242-feat-b-0825-time-modeled-dependencies-for-helm-temporal-axis.md | Adds the preserved discussion archive for PR #5242. |
| docs/pr-discussions/PR-5241-feat-b-0824-ace-as-pm-of-pms-n-d-dependency-space-holographi.md | Adds the preserved discussion archive for PR #5241. |
| docs/pr-discussions/PR-5235-fix-b-0823-iso-audit-accepts-nixpkgs-25-11-kernel-initrd-var.md | Adds the preserved discussion archive for PR #5235. |
| docs/pr-discussions/PR-5234-feat-b-0822-diamond-resolution-namespace-cardinality-multi-t.md | Adds the preserved discussion archive for PR #5234. |
| docs/pr-discussions/PR-5231-fix-riven-resolve-merge-conflict-in-riven-loop-tick-ts.md | Adds the preserved discussion archive for PR #5231. |
| docs/pr-discussions/PR-5230-feat-b-0821-file-zeta-as-dependency-graph-on-top-of-helm-str.md | Adds the preserved discussion archive for PR #5230. |
| docs/pr-discussions/PR-5229-fix-b-0820-land-derivability-asymmetry-finding-helm-tricks-f.md | Adds the preserved discussion archive for PR #5229. |
| docs/pr-discussions/PR-5228-docs-shadow-add-lesson-log-for-stale-claude-lock.md | Adds the preserved discussion archive for PR #5228. |
| docs/pr-discussions/PR-5227-feat-b-0820-file-flux-as-second-engine-row-with-flag-toggle.md | Adds the preserved discussion archive for PR #5227. |
| docs/pr-discussions/PR-5226-fix-b-0818-iso-build-audit-glob-accepts-nixpkgs-25-11-defaul.md | Adds the preserved discussion archive for PR #5226. |
| docs/pr-discussions/PR-5225-fix-b-0816-feat-b-0819-flux-helm-convergence-point-force-mul.md | Adds the preserved discussion archive for PR #5225. |
| docs/pr-discussions/PR-5224-fix-postmerge-5221-b-0817-4-copilot-findings-link-contradict.md | Adds the preserved discussion archive for PR #5224. |
| docs/pr-discussions/PR-5223-fix-b-0816-enrich-empirical-anchor-with-lexisnexis-github-us.md | Adds the preserved discussion archive for PR #5223. |
| docs/pr-discussions/PR-5222-fix-p0-iter-6-0-race-merge-recovery-glxinfo-mesa-demos-25-11.md | Adds the preserved discussion archive for PR #5222. |
| docs/pr-discussions/PR-5221-backlog-b-0817-p2-tools-cluster-register-node-ts-operator-in.md | Adds the preserved discussion archive for PR #5221. |
| docs/pr-discussions/PR-5220-backlog-b-0816-p1-architectural-principle-maximize-argocd-sc.md | Adds the preserved discussion archive for PR #5220. |
| docs/pr-discussions/PR-5219-docs-agentic-org-add-phased-development-plan.md | Adds the preserved discussion archive for PR #5219. |
</details>

## General comments

### @chatgpt-codex-connector (2026-05-27T19:38:21Z)

You have reached your Codex usage limits for code reviews. You can see your limits in the [Codex usage dashboard](https://chatgpt.com/codex/cloud/settings/usage).
101 changes: 101 additions & 0 deletions docs/pr-discussions/PR-5618-docs-archive-batch-archive-of-20-prs.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,101 @@
---
pr_number: 5618
title: "docs(archive): Batch archive of 20 PRs"
author: "AceHack"
state: "MERGED"
created_at: "2026-05-27T19:40:19Z"
merged_at: "2026-05-27T19:43:35Z"
closed_at: "2026-05-27T19:43:35Z"
head_ref: "lior/batch-archive-2026-05-27-15"
base_ref: "main"
archived_at: "2026-05-27T20:03:55Z"
archive_tool: "tools/pr-preservation/archive-pr.ts"
---

# PR #5618: docs(archive): Batch archive of 20 PRs

## PR description

Automated batch archival of 20 PRs to preserve discussion and context, and to reduce PR queue noise.

## Reviews

### COMMENTED — @copilot-pull-request-reviewer (2026-05-27T19:44:06Z)

## Pull request overview

This PR mechanically adds 20 preserved PR-discussion archives under `docs/pr-discussions/`, extending the repository’s historical PR context record.

**Changes:**
- Adds archived markdown records for merged PRs #5137–#5218.
- Preserves PR metadata, descriptions, review summaries, review threads, and general comments.
- Uses the existing `tools/pr-preservation/archive-pr.ts` frontmatter schema across all new files.

### Reviewed changes

Copilot reviewed 20 out of 20 changed files in this pull request and generated 5 comments.

<details>
<summary>Show a summary per file</summary>

| File | Description |
| ---- | ----------- |
| docs/pr-discussions/PR-5137-tick-1202z-cold-boot-empirical-anchor-github-actions-outage.md | Adds archive for PR #5137. |
| docs/pr-discussions/PR-5138-docs-archive-preserve-prs-5130-5134.md | Adds archive for PR #5138. |
| docs/pr-discussions/PR-5171-docs-shadow-add-lesson-on-preservation-blob-drift.md | Adds archive for PR #5171. |
| docs/pr-discussions/PR-5174-docs-archive-preserve-pr-discussions-batch-1.md | Adds archive for PR #5174. |
| docs/pr-discussions/PR-5177-docs-shadow-add-lesson-on-agent-paralysis-and-state-inconsis.md | Adds archive for PR #5177. |
| docs/pr-discussions/PR-5178-feat-ai-cluster-add-local-dev-cluster-bootstrap-from-4979.md | Adds archive for PR #5178. |
| docs/pr-discussions/PR-5182-tick-0526-1408z-otto-cli-cold-boot-visibility-shard-6h-gap-d.md | Adds archive for PR #5182. |
| docs/pr-discussions/PR-5191-docs-archive-decomposed-preservation-from-4804.md | Adds archive for PR #5191. |
| docs/pr-discussions/PR-5192-revert-restore-cursor-bin-riven-loop-tick-ts.md | Adds archive for PR #5192. |
| docs/pr-discussions/PR-5193-fix-docs-correct-relative-links-in-1202z-tick-shard.md | Adds archive for PR #5193. |
| docs/pr-discussions/PR-5199-docs-shadow-add-lesson-log-for-lior-metadata-churn.md | Adds archive for PR #5199. |
| docs/pr-discussions/PR-5206-docs-archive-preserve-discussion-for-pr-5134.md | Adds archive for PR #5206. |
| docs/pr-discussions/PR-5210-feat-iter-5-4-0-b-0794-homelab-gh-auth-login-operator-pubkey.md | Adds archive for PR #5210. |
| docs/pr-discussions/PR-5211-backlog-b-0812-p1-iter-5-4-1-self-registration-commit-push-t.md | Adds archive for PR #5211. |
| docs/pr-discussions/PR-5212-backlog-b-0813-p1-iter-5-4-2-argocd-app-watches-maintainers.md | Adds archive for PR #5212. |
| docs/pr-discussions/PR-5213-docs-shadow-add-lesson-log-for-human-decomposition-and-criti.md | Adds archive for PR #5213. |
| docs/pr-discussions/PR-5214-fix-postmerge-5210-5-copilot-findings-prompt-copy-comment-ac.md | Adds archive for PR #5214. |
| docs/pr-discussions/PR-5216-feat-b-0814-backlog-b-0815-ts-deregister-node-tool-heartbeat.md | Adds archive for PR #5216. |
| docs/pr-discussions/PR-5217-feat-b-0805-sub-target-1-audit-dep-currency-ts-dep-pin-inven.md | Adds archive for PR #5217. |
| docs/pr-discussions/PR-5218-feat-b-0800-iter-6-0-bump-nixpkgs-nix-darwin-24-11-25-11-xan.md | Adds archive for PR #5218. |
</details>

## Review threads

### Thread 1: docs/pr-discussions/PR-5137-tick-1202z-cold-boot-empirical-anchor-github-actions-outage.md:44 (unresolved)

**@copilot-pull-request-reviewer** (2026-05-27T19:44:05Z):

P1/xref: These archived GitHub PR-page links still use `../blob/main/...`; from `docs/pr-discussions/` they resolve under `docs/blob/main/...` instead of the repository root and will 404. Rewrite them to archive-relative repo paths such as `../../.claude/rules/...` (or full GitHub blob URLs), matching the preservation fixes recorded in prior archives.

### Thread 2: docs/pr-discussions/PR-5137-tick-1202z-cold-boot-empirical-anchor-github-actions-outage.md:44 (unresolved)

**@copilot-pull-request-reviewer** (2026-05-27T19:44:06Z):

P1/xref: This `../blob/main/...` link has the same archive-depth problem: when rendered from `docs/pr-discussions/`, it points at `docs/blob/main/...` and is not navigable. Convert it to `../../.claude/rules/...` or a full GitHub URL so the preserved citation works from the archive.

### Thread 3: docs/pr-discussions/PR-5137-tick-1202z-cold-boot-empirical-anchor-github-actions-outage.md:55 (unresolved)

**@copilot-pull-request-reviewer** (2026-05-27T19:44:06Z):

P1/xref: This preserved rule link still targets `../blob/main/...`, which is only valid from a GitHub PR page. In this archive file it resolves to a nonexistent `docs/blob/main/...` path; use `../../.claude/rules/...` or a full GitHub URL instead.

### Thread 4: docs/pr-discussions/PR-5137-tick-1202z-cold-boot-empirical-anchor-github-actions-outage.md:60 (unresolved)

**@copilot-pull-request-reviewer** (2026-05-27T19:44:06Z):

P1/xref: This archived link uses the GitHub PR-page-relative `../blob/main/...` form, so it will 404 when clicked from `docs/pr-discussions/`. Please rewrite it to the correct archive-relative path (`../../.claude/rules/...`) or an absolute GitHub URL.

### Thread 5: docs/pr-discussions/PR-5137-tick-1202z-cold-boot-empirical-anchor-github-actions-outage.md:118 (unresolved)

**@copilot-pull-request-reviewer** (2026-05-27T19:44:06Z):

P1/xref: The closing citation also uses `../blob/main/...`, which is broken from the archive location because it resolves under `docs/blob/main`. Convert it to `../../.claude/rules/...` (or a full GitHub URL) to keep the preserved discussion self-auditable.

## General comments

### @chatgpt-codex-connector (2026-05-27T19:40:24Z)

You have reached your Codex usage limits for code reviews. You can see your limits in the [Codex usage dashboard](https://chatgpt.com/codex/cloud/settings/usage).
Original file line number Diff line number Diff line change
@@ -0,0 +1,97 @@
---
pr_number: 5620
title: "feat(b-0857.2): install.sh NixOS routing \u2014 full state with 3 Copilot findings addressed (supersedes #5606)"
author: "AceHack"
state: "MERGED"
created_at: "2026-05-27T19:41:52Z"
merged_at: "2026-05-27T19:47:17Z"
closed_at: "2026-05-27T19:47:17Z"
head_ref: "feat/b-0857-2-install-sh-nixos-routing-resubmit-with-3-copilot-fixes-2026-05-27"
base_ref: "main"
archived_at: "2026-05-27T20:03:55Z"
archive_tool: "tools/pr-preservation/archive-pr.ts"
---

# PR #5620: feat(b-0857.2): install.sh NixOS routing — full state with 3 Copilot findings addressed (supersedes #5606)

## PR description

## Summary

Supersedes [#5606](https://github.com/Lucent-Financial-Group/Zeta/pull/5606) (which had 3 valid Copilot findings + 1 false-positive). Fresh branch off origin/main; no force-push (policy-respected new-branch path per the autonomous-loop force-push discipline).

PR #5606 will be closed with cross-reference to this PR.

## Routing matrix (unchanged from #5606)

| Environment | Detection | Routes to |
|---|---|---|
| macOS | \`uname -s = Darwin\` | \`setup/macos.sh\` |
| Linux non-NixOS | no \`/etc/NIXOS\` | \`setup/linux.sh\` |
| NixOS installed | \`/etc/NIXOS\` + no \`/.dockerenv\` + no \`/iso\` + no \`/run/initramfs\` | \`setup/linux.sh\` |
| NixOS docker test harness | \`/etc/NIXOS\` + \`/.dockerenv\` (B-0849 harness) | \`setup/linux.sh\` (discriminator-2 short-circuit) |
| NixOS live-USB | \`/etc/NIXOS\` + (\`/iso\` OR \`/run/initramfs\`) | \`exit 2\` + message pointing to \`zeta-install.sh\` |

## Copilot findings addressed (from PR #5606)

### Finding 1 (P1, line 16) — exit-code contract reconciled

**Was**: \"Exit 0 on success. Any failure is a dev-experience bug\" but live-USB branch intentionally exit 2.

**Fixed**: expanded exit-code documentation to 3 codes (0 success; 1 error; 2 intentional routing guard for NixOS live-USB — NOT a dev-experience bug). Clarified that CI \`gate.yml\` asserts exit 0 in its tested environments (none of which are NixOS live-USB).

### Finding 2 (P1, line 36) — name attribution

**Was**: \"Per B-0857 operator framing (Aaron 2026-05-27):\"

**Fixed**: \"Per B-0857 operator framing (2026-05-27):\" per name-attribution convention.

### Finding 3 (P1, line 111) — relative path

**Was**: \"sudo bash full-ai-cluster/usb-nixos-installer/zeta-install.sh\" (relative; fails if user not in repo root).

**Fixed**: resolves \`\$REPO_ROOT\`-rooted absolute path before printing the message; also resolves \`\$INJECTION_POINTS_ABS\` absolute path; both paths now work regardless of caller cwd.

### Finding 4 (P0, line 114) — FALSE POSITIVE

Copilot flagged \"\`full-ai-cluster/INJECTION-POINTS.md\` does not exist in the repo\" but the file DID land on origin/main at \`976b3521a\` (PR #5601, merged before PR #5606 CI ran). Verified via \`git ls-tree origin/main full-ai-cluster/INJECTION-POINTS.md\`. Copilot's review-base predated #5601 merge.

## Local validation

- \`bash -n\` syntax PASS
- \`bash tools/setup/install.sh\` on Darwin: routes to \`setup/macos.sh\` as expected
- \`bun tools/ci/docker-nixos-install-sh-test.ts\`: SUCCESS in 108s — B-0849 docker harness validates the \`/.dockerenv\` discriminator-2 short-circuit preserves existing harness behavior

## Why new-branch path (not force-push)

Per autonomous-loop force-push discipline: force-push requires explicit operator authorization. Earlier rebase rewrote PR #5606's branch SHAs locally; pushing those would have required force-push. The policy-respected alternative is the new-branch path (this PR).

## Test plan

- [x] Branch guard checked before commit
- [x] Tree-count canary 61 (no corruption)
- [x] Local docker harness PASS in 108s
- [x] All 3 valid Copilot findings addressed
- [x] False-positive (line 114) confirmed via direct \`git ls-tree origin/main\` inspection
- [ ] CI: build-ai-cluster-iso (triggered on merge by tools/setup/** path)

🤖 Generated with [Claude Code](https://claude.com/claude-code)

## Reviews

### COMMENTED — @copilot-pull-request-reviewer (2026-05-27T19:42:42Z)

## Pull request overview

Adds NixOS-aware environment routing to `tools/setup/install.sh`, distinguishing macOS, non-NixOS Linux, NixOS installed, NixOS docker test harness, and NixOS live-USB. Live-USB now exits 2 with a guidance message pointing to the existing `zeta-install.sh`. Supersedes #5606 with three Copilot findings addressed (exit-code contract, name attribution, absolute paths).

**Changes:**
- New `detect_linux_flavor` helper with 4-step discriminator (NIXOS marker → docker → live-USB markers → installed default).
- Linux case dispatches by flavor; live-USB prints an absolute-path-rooted message and exits 2.
- Header documents 3 exit codes and the B-0857.2 routing matrix.

## General comments

### @chatgpt-codex-connector (2026-05-27T19:41:58Z)

You have reached your Codex usage limits for code reviews. You can see your limits in the [Codex usage dashboard](https://chatgpt.com/codex/cloud/settings/usage).
Loading
Loading