Skip to content

docs(archive): Preserve discussion for PR #5557 #5557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
AceHack wants to merge 1 commit into from
Closed

docs(archive): Preserve discussion for PR #5557 #5557

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 45 additions & 0 deletions docs/pr-discussions/PR-5455-fix-require-executable-gcc-path-in-docker-harness.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,45 @@
---
pr_number: 5455
title: "fix: require executable gcc path in Docker harness"
author: "AceHack"
state: "MERGED"
created_at: "2026-05-27T13:43:50Z"
merged_at: "2026-05-27T13:47:27Z"
closed_at: "2026-05-27T13:47:28Z"
head_ref: "claim/codex-docker-cc-path-executable-check-20260527"
base_ref: "main"
archived_at: "2026-05-27T17:56:25Z"
archive_tool: "tools/pr-preservation/archive-pr.ts"
---

# PR #5455: fix: require executable gcc path in Docker harness

## PR description

## Summary
- tighten the Docker NixOS install-sh harness gcc path guard from non-empty to executable
- keep the existing command -v lookup while failing earlier if PATH resolves a non-executable gcc path

## Checks
- git diff --check origin/main...HEAD
- codex loop health: ok, no lock before push

Co-Authored-By: Codex <noreply@openai.com>

## Reviews

### COMMENTED — @copilot-pull-request-reviewer (2026-05-27T13:45:10Z)

## Pull request overview

This PR tightens the NixOS Docker install harness so the `gcc` path used to create `/usr/local/bin/cc` must resolve to an executable, preventing a broken compiler shim from being created.

**Changes:**
- Replaces the non-empty `gcc` path check with an executable check.
- Keeps the existing `command -v gcc` lookup and symlink behavior unchanged.

## General comments

### @chatgpt-codex-connector (2026-05-27T13:43:56Z)

You have reached your Codex usage limits for code reviews. You can see your limits in the [Codex usage dashboard](https://chatgpt.com/codex/cloud/settings/usage).
Loading