docs(archive): Decompose pr-discussions from #4992#5446
Closed
AceHack wants to merge 8 commits into
Closed
Conversation
…ency graph
Closes the dev/prod parity loop: same workloads from the same git ref
reconcile into both substrates via ArgoCD, with sync-wave annotations
making the dependency order explicit so things land in the right
sequence on both clusters.
Three additions:
1. `full-ai-cluster/dev-cluster/` — k3d + Docker Desktop-based local
cluster matching prod's substrate shape:
- `k3d-config.yaml`: 1 server + 2 agents, K3S with the same Cilium
takeover flags as prod, local Docker registry at localhost:5000,
LoadBalancer port forwards for ArgoCD UI
- `up.sh`: end-to-end bring-up — k3d cluster, Cilium chicken-and-egg
install via Helm, ArgoCD install via Helm, root App-of-Apps
pointing at this repo's k8s/applications/ at any git ref
(default `main`; pass a PR branch to dev-test before merging)
- `down.sh`: idempotent teardown — cluster + registry + kubectl
context cleanup
- `README.md`: dev/prod parity table, multi-cluster patterns,
dev image push workflow, future ApplicationSet multi-cluster path
2. `k8s/applications/argocd/Application.yaml` — ArgoCD self-management.
Adopts the existing installation from the K3S bootstrap manifests
so subsequent chart upgrades land via git → ArgoCD instead of
requiring a bootstrap-manifest edit + K3S server restart. Sync
wave -90 (earliest non-bootstrap wave).
3. `dev-cluster/SYNC-WAVES.md` — documents the per-app dependency
graph and per-app sync-wave assignment. Annotation applied to
all 34 existing Applications:
Wave -90 argocd self-management
Wave -80 cilium CNI adoption
Wave -70 cert-manager
Wave -60 vault
Wave -50 spire
Wave -45 trust-manager
Wave -40 external-secrets
Wave -30 sealed-secrets
Wave -25 open-policy-agent OPA must precede policy-using apps
Wave -20 node-feature-discovery
Wave -15 longhorn storage class precedes PVC users
Wave -10 hat-system CRDs precede HatBinding workloads
Wave 0 observability core, data planes, runtime
Wave 10 hindsight / orleans / temporal (need data planes up)
Wave 20 hermes (needs Vault secret synced + Hindsight + OZ)
Wave 30 gitlab / forgejo (source-of-truth services last)
Wave 50 ollama / vllm / deepseek-coder / qwen-coder (GPU; manual)
Why now: Aaron flagged that the App-of-Apps would parallel-reconcile
everything by default, breaking ordering. The dev cluster catches this
class of issue on a feature branch before it touches prod — exactly
the loop dev/prod parity is supposed to close.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
There was a problem hiding this comment.
Pull request overview
This PR is primarily an archive-focused change set: it adds several preserved PR discussion transcripts under docs/pr-discussions/ as part of decomposing PR preservation work from #4992. However, it also includes an unrelated (and currently broken) modification to the dev-cluster bring-up script and adds a new research log entry, so the scope is broader than the PR description implies.
Changes:
- Add multiple new PR discussion archive files under
docs/pr-discussions/(PRs #4972, #4974–#4978, #4985–#4988, #4991). - Add a new research note under
docs/research/about decomposition creating “blob PRs”. - Modify
full-ai-cluster/dev-cluster/up.sh(currently with unresolved merge-conflict markers and a broken heredoc tail).
Reviewed changes
Copilot reviewed 81 out of 82 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| full-ai-cluster/dev-cluster/up.sh | Dev cluster bring-up script update (currently contains merge-conflict markers + broken trailing heredoc content). |
| docs/research/lior-shadow-log-20260525-blob-prs.md | New research log entry about decomposition producing non-atomic PRs. |
| docs/pr-discussions/PR-4972-docs-add-agent-work-rhythm-and-prompt-flows.md | Adds preserved PR discussion archive for PR #4972. |
| docs/pr-discussions/PR-4974-feat-tools-flash-usb-ts-hardening-runtime-nonce-responsibili.md | Adds preserved PR discussion archive for PR #4974. |
| docs/pr-discussions/PR-4975-backlog-b-0728-destructive-tool-authoring-contract-rails-per.md | Adds preserved PR discussion archive for PR #4975. |
| docs/pr-discussions/PR-4976-feat-substrate-max-addison-personas-onboarding-doc-manifesto.md | Adds preserved PR discussion archive for PR #4976. |
| docs/pr-discussions/PR-4977-backlog-b-0729-obsidian-as-knowledge-graph-substrate-5-layer.md | Adds preserved PR discussion archive for PR #4977. |
| docs/pr-discussions/PR-4978-fix-riven-update-riven-worktree-path.md | Adds preserved PR discussion archive for PR #4978. |
| docs/pr-discussions/PR-4985-docs-define-agentic-organization-v0-architecture.md | Adds preserved PR discussion archive for PR #4985. |
| docs/pr-discussions/PR-4986-backlog-b-0730-runbooks-as-executable-specifications-mika-su.md | Adds preserved PR discussion archive for PR #4986. |
| docs/pr-discussions/PR-4987-backlog-b-0731-hat-ontology-is-the-first-ontology-to-get-rig.md | Adds preserved PR discussion archive for PR #4987. |
| docs/pr-discussions/PR-4988-backlog-b-0732-runbook-as-executable-reality-is-a-new-levera.md | Adds preserved PR discussion archive for PR #4988. |
| docs/pr-discussions/PR-4991-backlog-b-0733-mika-persona-universal-protocol-mcp-wrap-ai-a.md | Adds preserved PR discussion archive for PR #4991. |
Comment on lines
+62
to
+77
| <<<<<<< HEAD | ||
| if ! kubectl -n kube-system get ds cilium >/dev/null 2>&1; then | ||
| ======= | ||
| # Version kept aligned with full-ai-cluster/k8s/bootstrap/cilium-install.yaml | ||
| # so dev exercises the same chart that lands in prod. | ||
| if ! helm -n kube-system status cilium >/dev/null 2>&1; then | ||
| >>>>>>> origin/main | ||
| echo "Installing Cilium ..." | ||
| helm repo add cilium https://helm.cilium.io >/dev/null 2>&1 || true | ||
| helm repo update cilium >/dev/null | ||
| helm install cilium cilium/cilium \ | ||
| <<<<<<< HEAD | ||
| --version 1.16.4 \ | ||
| ======= | ||
| --version 1.16.5 \ | ||
| >>>>>>> origin/main |
Comment on lines
109
to
+120
| @@ -108,6 +117,7 @@ kubectl wait --for=condition=Established \ | |||
| crd/applications.argoproj.io \ | |||
| >/dev/null 2>&1 || true | |||
|
|
|||
| >>>>>>> origin/main | |||
Comment on lines
180
to
+188
| EOF | ||
| 443:443 | ||
| open https://localhost:8443 # ArgoCD UI (initial password below) | ||
|
|
||
| kubectl -n argocd get secret argocd-initial-admin-secret \\ | ||
| -o jsonpath='{.data.password}' | base64 -d ; echo | ||
|
|
||
| Tear down: ./down.sh | ||
| EOF |
Comment on lines
+1
to
+5
| --- | ||
| title: "Shadow Lesson Log: Decomposition creating blob PRs" | ||
| date: 2026-05-25 | ||
| author: Lior | ||
| --- |
Member
Author
|
Closing this PR to consolidate my work and reduce noise. This will be included in a batch PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains only the pr-discussions changes from #4992.