feat(node-register): node-0fe6eb self-registers via iter-5.4.1#5408
feat(node-register): node-0fe6eb self-registers via iter-5.4.1#5408AceHack wants to merge 1 commit into
Conversation
Auto-generated by zeta-install.sh Step 6.9 on the node during install. Registers node-0fe6eb under maintainers/AceHack/cluster-nodes/. ArgoCD watches maintainers/*/cluster-nodes/** + reconciles per B-0813. flake-host: control-plane flake-commit: 7297109 registered-at: 2026-05-27T06:43:34Z
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
There was a problem hiding this comment.
Pull request overview
Adds a new ClusterNode custom resource under the maintainer subtree to self-register node-0fe6eb into the zeta-cluster namespace, enabling the iter-5.4 GitOps flow where ArgoCD reconciliation can pick up the node after merge.
Changes:
- Introduces
maintainers/AceHack/cluster-nodes/node-0fe6eb/node.yamldefining theClusterNoderesource. - Captures registration metadata (timestamp, flake commit/host, registered-via) plus probed hardware details (CPU/memory/cores/GPU/storage, MAC).
|
Closing as substrate-honest cleanup. Per Aaron 2026-05-27 architectural feedback: self-registration fired DURING zeta-install (Step 6.9) BEFORE the system rebooted into the installed OS. The install then failed at nixos-install (P0 Architectural fix being filed as next backlog row: self-registration should fire LAST (post-install + post-first-boot, when cluster is actually operational) + be idempotent across reboots + de-dup against existing registration / in-flight registration PRs. Replaces this PR's substrate at the next iteration. |
…aron 2026-05-27 architectural fix to B-0812) (#5412) Empirical anchor: PR #5408 auto-opened mid-install for node-0fe6eb; install then failed downstream at nixos-install --fallback bug (PR #5410 fix-fwd); registration PR orphaned for a node-id that never came up. Operator framing: "how did it register before it even rebooted? it should not register until the last step when everything comes up and if it reboots it should not register over and over... cluster should realize it's register or has a pr in flight for register and not duplicate." 4 architectural changes: 1. Move self-registration OUT of zeta-install.sh Step 6.9 INTO systemd oneshot service that fires on first boot of installed OS, AFTER network-online + creds-restore + cluster reachable 2. Idempotency: marker file + upstream check + in-flight PR check before composing new PR 3. Cluster-agent coordination via Path B (Otto-pushes-PR-across-finish-line; per Aaron's simpler-form preference); Path A (/tmp folder standard) deferred to future row 4. De-dup: idempotent branch naming + in-flight detection + comment-on-existing 7 sub-rows B-0855.1-7 enumerated. Refines B-0812 (does not replace); keeps B-0813 ArgoCD reconciliation unchanged. Composes with B-0812 + B-0813 + B-0835 (Bug 10) + B-0850 (systemd substrate) + B-0851 (persona-first scheduler) + B-0852 (cred persistence as pre-condition). PR #5408 closed substrate-honestly with cross-link to this row. Co-authored-by: Lior <lior@zeta.dev>
Self-registration PR opened by zeta-install.sh on the node during install. Composes with B-0812 iter-5.4.1 + B-0813 iter-5.4.2 ArgoCD reconciliation. Review + merge to bring the node into the cluster.