Skip to content

hygiene(bash-retirement): check stale category metadata#5407

Merged
AceHack merged 3 commits into
mainfrom
claim/codex-loop-bash-retirement-category-map-integrity-20260527
May 27, 2026
Merged

hygiene(bash-retirement): check stale category metadata#5407
AceHack merged 3 commits into
mainfrom
claim/codex-loop-bash-retirement-category-map-integrity-20260527

Conversation

@AceHack
Copy link
Copy Markdown
Member

@AceHack AceHack commented May 27, 2026

Summary

  • Validate that the retained-shell category map has no stale entries outside EXPECTED_RETAINED_SHELL.
  • Surface stale category metadata in the bash-retirement inventory report.
  • Add focused coverage for stale category detection and report rendering.

Checks

  • PASS: bun test tools/hygiene/check-bash-retirement-inventory.test.ts
  • PASS: bun tools/hygiene/check-bash-retirement-inventory.ts --enforce
  • PASS: git diff --check and git diff --cached --check
  • BLOCKED locally: bun run typecheck (tsc is not installed in this worktree environment)
  • BLOCKED locally: bunx eslint tools/hygiene/check-bash-retirement-inventory.ts tools/hygiene/check-bash-retirement-inventory.test.ts (ESLint 10 requires jiti for TypeScript config loading)

Lior and others added 2 commits May 27, 2026 02:28
Co-Authored-By: Codex <noreply@openai.com>
Co-Authored-By: Codex <noreply@openai.com>
Copilot AI review requested due to automatic review settings May 27, 2026 06:37
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds an integrity check to the bash-retirement inventory guard to detect stale entries in the retained-shell category map (category metadata that references files no longer in EXPECTED_RETAINED_SHELL), and surfaces these errors in both the rendered report and tests.

Changes:

  • Extend allowlist integrity inspection to flag stale category-map entries.
  • Render stale category-map drift in the human-readable inventory report (including a new summary counter).
  • Add targeted tests covering stale category detection and report rendering.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
tools/hygiene/check-bash-retirement-inventory.ts Adds stale category-map detection to allowlist integrity checks and report output.
tools/hygiene/check-bash-retirement-inventory.test.ts Adds coverage for stale category detection and report rendering.
docs/claims/codex-loop-bash-retirement-category-map-integrity-20260527.md Introduces a claim file documenting the work scope (should be released/removed when landing).

Comment thread docs/claims/codex-loop-bash-retirement-category-map-integrity-20260527.md Outdated
Comment thread tools/hygiene/check-bash-retirement-inventory.ts
… PR #5407

Co-Authored-By: Codex <noreply@openai.com>
@AceHack AceHack marked this pull request as ready for review May 27, 2026 06:47
Copilot AI review requested due to automatic review settings May 27, 2026 06:47
@chatgpt-codex-connector
Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

@AceHack AceHack merged commit 118614c into main May 27, 2026
53 checks passed
@AceHack AceHack deleted the claim/codex-loop-bash-retirement-category-map-integrity-20260527 branch May 27, 2026 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants