feat(B-0849): docker-based NixOS install.sh test harness — fast iteration (~30 sec) complementing B-0831 QEMU full-install (~15 min); 'easy dockerfile' (Aaron 2026-05-27)#5390
Merged
AceHack merged 1 commit intoMay 27, 2026
Conversation
…tion (~30 sec) complementing B-0831 QEMU full-install (~15 min); "easy dockerfile" per operator framing (Aaron 2026-05-27) Operator framing 2026-05-27 (verbatim): > "we should add docker based nixos install.sh testing so we can > iterate quick that's an easy dockerfile" Direct response after PR #5389 (iter-5.5.1 alignment fix-fwd for PR #5388) where the operator named the iteration-cost problem: every install.sh / linux.sh / mise.sh change today requires a full ISO build + USB flash + physical install (~30 min cycle); Docker testing of just the script on NixOS userspace gives seconds-per- iteration. 3-phase plan: - Phase 1: tools/ci/dockerfiles/nixos-install-sh-test/Dockerfile (10-line FROM nixos/nix + touch /etc/NIXOS + COPY . . + RUN tools/setup/install.sh) + TS wrapper bun tools/ci/docker-nixos-install-sh-test.ts per Rule 0 - Phase 2: GitHub Actions integration with path-filter scoped to tools/setup/** + full-ai-cluster/nixos/modules/common.nix - Phase 3: documented Docker-vs-QEMU coverage matrix; both run on install-substrate PRs (Docker fast, QEMU end-to-end) Empirical case for the substrate: iter-5.4 cascade has produced 8 distinct bugs (Bug 1-8) all caught only after operator USB flash; Docker harness would have caught Bug 5 (gh not in systemPackages), Bug 7 (NetBIOS conflict with smbd), Bug 8 (credential persistence gap) AT WRITE TIME. Composes with: B-0831 cascade #6 (complementary; full-VM scope at minutes-per-cycle); B-0835 install bug cluster (this row catches future Bug-N at write-time); B-0848 (node-local Claude install validation); B-0824 (Ace package-manager — Docker NixOS test is one slice of three-way-parity); GOVERNANCE §24 (three-way parity extended to NixOS-via-Docker validation surface). 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Operator (verbatim):
Direct response after PR #5389 (iter-5.5.1 alignment fix-fwd) — operator named the iteration-cost problem: every install.sh / linux.sh / mise.sh change today requires full ISO build + USB flash + physical install (~30 min cycle). Docker testing of just the script on NixOS userspace gives seconds-per-iteration.
Empirical case
iter-5.4 cascade produced 8 distinct bugs (Bug 1-8) ALL caught only after operator USB flash. Docker harness would have caught Bug 5 (gh not in systemPackages), Bug 7 (NetBIOS conflict with smbd), Bug 8 (credential persistence gap) at write time.
3-phase plan
Composes with
B-0831 (QEMU full-install — complementary) · B-0835 (install bug cluster) · B-0848 (node-local Claude) · B-0824 (Ace) · GOVERNANCE §24 (three-way parity extended to NixOS-via-Docker)
🤖 Generated with Claude Code