Skip to content

ci(B-0831 layer-1): extend audit-installer-substrate with iter-5.4 sentinels #5365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AceHack merged 2 commits into from
May 27, 2026
Merged

ci(B-0831 layer-1): extend audit-installer-substrate with iter-5.4 sentinels #5365

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
730f70c
ci(B-0831 layer-1): extend audit-installer-substrate with iter-5.4 se…
May 27, 2026
550947d
fix(#5365 Copilot): reflow iter-5.4.1 YAML schema sentinels comment s…
May 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 23 additions & 1 deletion tools/ci/audit-installer-substrate.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,8 +85,30 @@ const REQUIRED_SENTINELS: readonly SentinelAssertion[] = [
"Step 6.7: iter-5.1 wifi persistence", // iter-5.1 NM-profile persist
"iter-5.2.2", // iter-5.2.2 install-time auto-gen marker
"/dev/urandom", // install-time hostname generator
// ── iter-5.4 sentinels (PR #5364 + #5352 + #5354 substrate) ──
"Step 6.8: iter-5.4.0 homelab gh-auth + operator pubkey copy", // iter-5.4.0 anchor
"Step 6.9: iter-5.4.1 self-registration commit+push", // iter-5.4.1 self-reg anchor
"gh auth login", // device-flow auth invocation
"gh auth setup-git", // B-0835 Bug 2a fix — wires git credential helper to gh token
"gh ssh-key list", // iter-5.4.0 operator-authorized-keys path
"SSH_KEY_ERR_FILE", // B-0835 Bug 2b fix — stderr capture for discrimination
"admin:public_key", // B-0835 Bug 2b fix — scope-error recovery guidance
"gh repo clone Lucent-Financial-Group/Zeta", // iter-5.4.1 cluster repo clone
"register-${NODE_HOSTNAME}-", // iter-5.4.1 registration branch shape
// iter-5.4.1 YAML schema sentinels. Each catches a specific Copilot
// finding on PR #5352: spec.role was scalar (should be array),
// spec.maintainer was at flat path (should nest under spec.registration),
// spec.storage was a sibling of hardware (should nest under spec.hardware).
"apiVersion: zeta.lucent-financial-group.com/v1", // ClusterNode CRD apiVersion
"kind: ClusterNode", // CRD kind
" roles:", // spec.roles is ARRAY (NOT scalar spec.role) per B-0813 schema
" registration:", // spec.registration block (NOT spec.maintainer flat) per B-0813
" hardware:", // spec.hardware block (storage nests inside) per B-0813
// iter-5.4.1 hardware-probe sentinels (catches MAC parsing regression from #5352).
"/proc/cpuinfo", // CPU_MODEL extraction
"link/ether", // MAC_ADDR parses field AFTER link/ether (not before)
],
rationale: "iter-4.2 + iter-5.1 + iter-5.2 + iter-5.2.2 substrate must be present in installer script",
rationale: "iter-4.2 + iter-5.1 + iter-5.2 + iter-5.2.2 + iter-5.4.0 + iter-5.4.1 (incl. B-0835 Bug 2a/2b fixes) substrate must be present in installer script",
},
{
path: "full-ai-cluster/usb-nixos-installer/zeta-first-boot.sh",
Expand Down
Loading