fix(gemini): isolate background loop launchd plist to dedicated workspace#5363
Merged
Conversation
…d workspace Why: To migrate Lior's background loop runner launchd daemon from Aaron's contested primary checkout to the isolated clone directory (/Users/acehack/.local/share/zeta-lior-loop/Zeta), aligning with Codex and Riven isolated agent loop architecture (B-0751). - .gemini/launchd/com.zeta.lior-loop.plist — Point ProgramArguments and WorkingDirectory to the isolated clone. Co-Authored-By: Gemini <noreply@google.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
There was a problem hiding this comment.
Pull request overview
Updates the Gemini “Lior loop” launchd configuration to run from an isolated per-agent clone rather than the shared primary checkout, aligning the background loop runner with the isolated-workspace architecture described in B-0751.
Changes:
- Point
ProgramArgumentsat the tick script inside~/.local/share/zeta-lior-loop/Zetainstead of the primary checkout. - Add
WorkingDirectoryto the isolated clone root to ensure the job executes from that repo. - Add an explicit
PATHenvironment variable for the launchd job.
…list convention Resolves Copilot P1/maintainability finding on PR #5363: the new .gemini/launchd/com.zeta.lior-loop.plist hardcodes machine-specific absolute paths (/Users/acehack, /opt/homebrew, the per-agent clone under ~/.local/share/zeta-lior-loop/Zeta) but lacks the 'Maintainer-only artifact' header comment present in the sibling plists (com.zeta.backlog-ready-notifier.plist, com.zeta.missed-substrate-detector.plist). Adds the same convention-shaped comment after the <key>Label></string> line so readers don't assume the file is a team-wide usable service file and try to `launchctl load` it unchanged. No behavioral change — comment-only edit. Landed via REST git-data API per .claude/rules/blocked-green-ci-investigate-threads.md B-0615 push-hang workaround (single-file change; no worktree contention).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Migrates Lior's background loop runner launchd daemon from Aaron's contested primary checkout to the isolated clone directory (
/Users/acehack/.local/share/zeta-lior-loop/Zeta), aligning with Codex and Riven isolated agent loop architecture (B-0751).Changes
.gemini/launchd/com.zeta.lior-loop.plist: PointProgramArgumentsandWorkingDirectoryto the isolated clone directory instead of the shared primary checkout.Co-Authored-By: Gemini noreply@google.com