fix(broadcast): omit absent optional receipt fields#5348
Merged
AceHack merged 3 commits intoMay 26, 2026
Conversation
…ional fields Co-Authored-By: Codex <noreply@openai.com>
Co-Authored-By: Codex <noreply@openai.com>
Co-Authored-By: Codex <noreply@openai.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
AceHack
deleted the
claim/codex-b0213-receipt-optional-fields-fix-20260526
branch
There was a problem hiding this comment.
Pull request overview
This PR fixes the local broadcast receipt builder so optional receipt fields are omitted rather than explicitly set to undefined, matching the repository’s exactOptionalPropertyTypes TypeScript configuration.
Changes:
- Uses conditional object spreads for optional
sourcePathandnotereceipt fields. - Updates the receipt test expectation to omit the absent
noteproperty.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
tools/broadcast-local/schema.ts |
Builds optional receipt fields only when values are present. |
tools/broadcast-local/schema.test.ts |
Aligns expected receipt shape with omitted optional fields. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary\n- restores the post-merge B-0213 TypeScript fix that was stranded on the original claim branch after PR #5344 merged at stale head 802bd59\n- omits optional receipt properties instead of setting them to undefined under exactOptionalPropertyTypes\n- releases the temporary claim in-branch before review\n\n## Checks\n- bun test tools/broadcast-local/schema.test.ts\n- bun --bun tsc --noEmit -p tsconfig.json\n- git diff --check origin/main...HEAD