Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix(pr-preservation): DECOMPOSED - add archived files to git (from #4857) #4967
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
fix(pr-preservation): DECOMPOSED - add archived files to git (from #4857) #4967
Changes from all commits
99fd13bd22951454d5b53282ffc8File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new staging step calls
spawnSync("git", ["add", path])but never checks whether it succeeded, andmainstill returns0. Ifgit addfails (for example due to an index lock, permissions, or missing git on PATH), the script reports success while leaving the archive unstaged, which defeats the preservation guarantee this change is meant to add. Please validate the spawn result and return a non-zero exit code on failure.Useful? React with 👍 / 👎.
Uh oh!
There was an error while loading. Please reload this page.