feat(persona): DECOMPOSED - remove sensitive information from Lior's persona from #4854 (from #4882)#4948
feat(persona): DECOMPOSED - remove sensitive information from Lior's persona from #4854 (from #4882)#4948AceHack wants to merge 4 commits into
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3635746ff5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| <ProjectReference Include="..\..\src\Core\Core.fsproj" /> | ||
| <ProjectReference Include="..\..\src\Core.CSharp.ZetaId\Zeta.Core.CSharp.ZetaId.csproj" /> | ||
| </ItemGroup> |
There was a problem hiding this comment.
tests/Tests.CSharp/Tests.CSharp.csproj now keeps only the Core.fsproj reference, but the default-included files in tests/Tests.CSharp/ZetaId/ still import both Zeta.Core.CSharp.ZetaId and YamlDotNet.Serialization (for example CrossVerifyTests.cs and FlatVector.cs). With those references removed, the C# test project cannot compile, so dotnet test/solution builds that include this project will fail with missing namespace/type errors.
Useful? React with 👍 / 👎.
| if k <> n then | ||
| invalidOp "Circuit has a cycle that does not pass through a strict operator" | ||
| // Sink-terminality enforcement. The `ISinkOperator` docstring | ||
| // (PluginApi.fs) promises *"the scheduler enforces terminal | ||
| // placement (a sink may not feed another operator inside a | ||
| // relational path)"*. PR 2 makes that promise load-bearing: | ||
| // any operator whose `Inputs` contains a sink is rejected | ||
| // with a diagnostic naming both endpoints, the sink's | ||
| // position in the DAG, and a pointer to the algebra-tag | ||
| // contract. Sinks are retraction-lossy by design (e.g. | ||
| // BayesianRateOp aggregates state that doesn't un-accumulate); | ||
| // letting a downstream operator read from a sink would | ||
| // violate the relational composition laws Z-set algebra | ||
| // depends on. | ||
| // | ||
| // Defensive ordering: this runs AFTER the topo-sort succeeds | ||
| // so the error message can reference op IDs that are stable. | ||
| // O(N + E) — each edge checked exactly once. | ||
| for op in ops do | ||
| for dep in op.Inputs do | ||
| if dep.IsSink then | ||
| invalidOp | ||
| (sprintf | ||
| "Sink-terminality violation: operator '%s' (id=%d) reads from \ | ||
| sink operator '%s' (id=%d). Sinks are terminal — they may not \ | ||
| feed other operators in a relational path because sink state is \ | ||
| retraction-lossy and breaks Z-set composition laws. See \ | ||
| PluginApi.fs:ISinkOperator for the contract." | ||
| op.Name op.Id dep.Name dep.Id) | ||
| schedule <- order |
There was a problem hiding this comment.
After cycle detection, Circuit.Build() now assigns schedule <- order immediately without checking for sink-to-downstream edges. This removes enforcement of the ISinkOperator contract (sinks are terminal) and allows circuits where a sink output feeds another operator to build successfully, which can leak retraction-lossy state into relational paths and produce incorrect incremental results in sink-using graphs.
Useful? React with 👍 / 👎.
| - name: Run audit-backlog-items (--enforce-parent-child-status) | ||
| run: bun tools/hygiene/audit-backlog-items.ts --enforce-parent-child-status | ||
|
|
||
| lint-no-empty-dirs: |
There was a problem hiding this comment.
This section now jumps directly from lint-archive-header-section33 to lint-no-empty-dirs, and the workflow no longer runs previously wired checks (audit-section-33-migration-xrefs --enforce, audit-tick-shard-relative-paths --enforce --baseline, backlog duplicate/parent-child enforcement, and no-python-files). Those controls are still present as scripts but are no longer executed in CI, so new violations in these classes will merge undetected.
Useful? React with 👍 / 👎.
|
This PR is a blob and contains multiple unrelated changes. Please decompose this PR into smaller, atomic PRs. |
This PR is a decomposition of #4882, containing only the persona update.