Skip to content

fix(installer): refresh embedded runbook (Addison)#4903

Merged
AceHack merged 1 commit into
mainfrom
fix/addison-installer-runbook-stale-comment
May 25, 2026
Merged

fix(installer): refresh embedded runbook (Addison)#4903
AceHack merged 1 commit into
mainfrom
fix/addison-installer-runbook-stale-comment

Conversation

@AceHack
Copy link
Copy Markdown
Member

@AceHack AceHack commented May 25, 2026

Summary

The runbook baked onto the USB at `/etc/zeta-install.md` was authored before per-host configs landed and still said "Today: installer only; per-host configs land in follow-up PRs". Those per-host configs (control-plane, worker-gpu-01, worker-gpu-02) are on main now — the runbook just hadn't caught up.

Changes

Section Before After
Step 6 (hardware config) Just ran `nixos-generate-config --root /mnt` Now also copies the result into the per-host dir the flake reads — otherwise the install picks up the placeholder hardware-configuration.nix and the target boots wrong
Step 7 (install) Said only `installer` host existed Lists all 4 hosts on main + marks `installer` as not-for-target

Cosmetic only. No code change.

Test plan

  • markdownlint passes (embedded markdown in a Nix multi-line string isn't directly linted, but the surrounding Nix file is)
  • On a fresh USB build, `cat /etc/zeta-install.md` shows the corrected runbook

Co-Authored-By: Claude Opus 4.7 (1M context) noreply@anthropic.com

…are-config copy step

The runbook baked onto the ISO at /etc/zeta-install.md was authored
before the per-host configs landed (PR #4898 stack), so it still said
"Today: installer only; per-host configs land in follow-up PRs."
Those configs have been on main since 02:53:15Z — the runbook just
hadn't been updated to match.

Changes to the embedded text:

- Step 6 now shows the cp command that moves hardware-configuration.nix
  from where nixos-generate-config writes it (/mnt/etc/nixos/) into the
  per-host directory the flake actually reads (/mnt/etc/zeta/infra/
  nixos/hosts/<host>/). Without this step, nixos-install builds against
  the placeholder hardware-configuration.nix shipped in the repo and the
  target boots with wrong fileSystems/kernel modules.

- Step 7 now enumerates the actual nixosConfigurations on main:
  installer, control-plane, worker-gpu-01, worker-gpu-02. Marks
  `installer` as not-for-target-install so a future user doesn't
  pick it by accident.

Cosmetic-only fix; no code change. Surfaces the right install
workflow for the first real cluster bootstrap from this ISO.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Copilot AI review requested due to automatic review settings May 25, 2026 02:58
@AceHack AceHack enabled auto-merge (squash) May 25, 2026 02:58
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the NixOS installer ISO’s embedded offline runbook (/etc/zeta-install.md) so it matches the current flake layout with per-host NixOS configurations and avoids accidentally installing with placeholder hardware configuration.

Changes:

  • Step 6 now instructs copying the generated hardware-configuration.nix into the selected per-host directory under infra/nixos/hosts/<host>/.
  • Step 7 now lists the current flake.nix nixosConfigurations hostnames and clarifies installer is ISO-only (not a target install).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants