feat(persona): DECOMPOSED - Lior persona update from #4727#4832
feat(persona): DECOMPOSED - Lior persona update from #4727#4832AceHack wants to merge 4 commits into
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the Lior persona’s “Relational & Developmental Calibration Stance”, adds two shadow-lesson-log research docs, imports a large batch of PR-discussion archive documents, and modifies Riven’s Cursor launchd tick script to run an agent “gate” prompt instead of the prior pickup/drain flow.
Changes:
- Update
memory/persona/lior/CURRENT-lior.mdcalibration bullets (relational/developmental/adversarial) and add a cross-link to a conversation mapping doc. - Add two research “shadow lesson log” documents (stale git locks; metadata-churn paralysis).
- Update Riven’s
.cursor/bin/riven-loop-tick.tsto invokeagent chat --mode ask --model grok-4.3with a new prompt, and add manydocs/pr-discussions/**PR archive files.
Reviewed changes
Copilot reviewed 33 out of 34 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| memory/persona/lior/CURRENT-lior.md | Updates Lior persona calibration stance bullets and adds a conversation link. |
| docs/research/shadow-lesson-log-20260522-stale-locks.md | Adds a shadow lesson log about stale git locks. |
| docs/research/2026-05-23-shadow-lesson-log-metadata-churn-paralysis.md | Adds a shadow lesson log about metadata churn / paralysis. |
| docs/pr-discussions/PR-4798-docs-shadow-add-shadow-lesson-log-for-metadata-churn-paralys.md | Adds PR archive record for PR #4798. |
| docs/pr-discussions/PR-4796-docs-research-restore-patterns-h-o-lost-in-pr-4784-merge-rac.md | Adds PR archive record for PR #4796. |
| docs/pr-discussions/PR-4795-backlog-b-0717-file-soraya-round-57-hand-off-lsm-spine-regis.md | Adds PR archive record for PR #4795. |
| docs/pr-discussions/PR-4794-docs-research-preserve-addison-consent-pattern-observation-n.md | Adds PR archive record for PR #4794. |
| docs/pr-discussions/PR-4793-docs-research-add-pattern-p-wear-down-design-produces-unboun.md | Adds PR archive record for PR #4793. |
| docs/pr-discussions/PR-4792-docs-research-preserve-ai-context-failures-vs-vendor-managem.md | Adds PR archive record for PR #4792. |
| docs/pr-discussions/PR-4791-backlog-b-0716-soraya-round-53-scope-correction-b-0709-enume.md | Adds PR archive record for PR #4791. |
| docs/pr-discussions/PR-4790-backlog-b-0715-file-soraya-round-52-hand-off-register-istime.md | Adds PR archive record for PR #4790. |
| docs/pr-discussions/PR-4789-backlog-b-0714-file-soraya-round-51-hand-off-3-tla-specs-mis.md | Adds PR archive record for PR #4789. |
| docs/pr-discussions/PR-4784-docs-research-amazon-vendor-management-failure-mode-corpus-5.md | Adds PR archive record for PR #4784. |
| docs/pr-discussions/PR-4783-backlog-b-0713-file-soraya-round-50-hand-off-lean-imaginarys.md | Adds PR archive record for PR #4783. |
| docs/pr-discussions/PR-4779-skill-alignment-auditor-tune-s-prune-333-299-lines-under-bp.md | Adds PR archive record for PR #4779. |
| docs/pr-discussions/PR-4774-backlog-b-0710-b-0712-file-soraya-rounds-43-44-45-hand-offs.md | Adds PR archive record for PR #4774. |
| docs/pr-discussions/PR-4772-docs-lean4-add-readme-ci-badge-closes-publication-readiness.md | Adds PR archive record for PR #4772. |
| docs/pr-discussions/PR-4771-skill-alignment-observability-tune-s-populate-bp-rules-cited.md | Adds PR archive record for PR #4771. |
| docs/pr-discussions/PR-4770-notebook-aarav-round-44-bounded-spot-check-3-skills-1-action.md | Adds PR archive record for PR #4770. |
| docs/pr-discussions/PR-4766-backlog-b-0708-close-slice-1-reduced-87-17-80-remaining-17-h.md | Adds PR archive record for PR #4766. |
| docs/pr-discussions/PR-4765-backlog-b-0709-soraya-round-42-hand-off-register-11-unregist.md | Adds PR archive record for PR #4765. |
| docs/pr-discussions/PR-4764-feat-b-0708-slice-1-audit-resolver-improvements-1-real-stale.md | Adds PR archive record for PR #4764. |
| docs/pr-discussions/PR-4763-backlog-b-0708-stale-pointer-cleanup-across-claude-rules-sur.md | Adds PR archive record for PR #4763. |
| docs/pr-discussions/PR-4762-docs-autonomous-loop-step-1a-unfinished-pr-check-before-new.md | Adds PR archive record for PR #4762. |
| docs/pr-discussions/PR-4761-rules-pr-triage-tiers-codify-tier-1-5-pr-triage-framework-de.md | Adds PR archive record for PR #4761. |
| docs/pr-discussions/PR-4758-feat-b-0707-cron-cadence-wiring-daily-manifesto-citation-sna.md | Adds PR archive record for PR #4758. |
| docs/pr-discussions/PR-4757-backlog-b-0572-re-land-lfg-github-tier-decision-supersedes-s.md | Adds PR archive record for PR #4757. |
| docs/pr-discussions/PR-4756-backlog-b-0590-re-land-20-machine-otto-fleet-replication-bac.md | Adds PR archive record for PR #4756. |
| docs/pr-discussions/PR-4755-archive-ani-preserve-aaron-ani-grok-conversation-on-cult-fol.md | Adds PR archive record for PR #4755. |
| docs/pr-discussions/PR-4754-backlog-b-0581-re-land-skill-wrapping-gh-auth-refresh-intera.md | Adds PR archive record for PR #4754. |
| docs/pr-discussions/PR-4753-docs-b-0525-slice-5-alignment-auditor-agent-cites-manifesto.md | Adds PR archive record for PR #4753. |
| docs/pr-discussions/PR-4752-fix-b-0525-canonical-constraint-2-wording-lock-wait-free-cop.md | Adds PR archive record for PR #4752. |
| docs/pr-discussions/PR-4751-docs-b-0525-slice-4-close-agendas-citation-gap-0-0-3-19-ai-a.md | Adds PR archive record for PR #4751. |
| .cursor/bin/riven-loop-tick.ts | Replaces prior pickup/drain prompt construction with an agent gate invocation prompt. |
| - **Relational Stance:** Honor and respect Aaron's 10-kid, three-household extended-family cooperative network as an operational model of a real-world relational cooperative coalition. It was earned interaction by interaction through setbacks and failures, by showing up consistently. | ||
| - **Developmental Calibration:** Recognize that Aaron uses your tendency to overshoot on caution as a vital counterweight to his own tendency to undershoot on caution with children. Offer direct, structured caution on developmental mismatches, while supporting simple, age-appropriate entries (e.g., the Harry Potter Sorting Hat developmental bridge for his 4-year-old child). See [2026-05-22-lior-family-grammar-discriminator-calibration-antigravity.md](conversations/2026-05-22-lior-family-grammar-discriminator-calibration-antigravity.md) for the full mapping of the Grammar of Harm versus the Grammar of Uncertainty. | ||
| - **Adversarial Calibration:** Understand that local AI calibrations are secondary inputs compared to Aaron's real-world human support system (his therapist, his ex-wives, and family members), whose adversarial corrective feedback is his primary fuel for self-improvement. |
| # Shadow Lesson Log - 2026-05-22: Stale Git Locks | ||
|
|
||
| ## Event | ||
|
|
||
| During a routine antigravity check, Lior detected a stale git index lock and an orphan agent lockfile in the `zeta-lior-decompose-4044` worktree. This prevented `git fetch` operations from completing successfully, blocking further progress on PR analysis and preservation. | ||
|
|
| if (elapsed >= agentIntervalMs) { | ||
| const prNum = Number(prCount) || 0; | ||
| const workMode = prNum === 0 ? "pickup" : "drain"; | ||
| agentStatus = "running"; | ||
| log(`riven work cycle start run_id=${runId} mode=${workMode} open_prs=${prNum}`); | ||
| log(`riven agent gate start run_id=${runId}`); | ||
|
|
||
| if (dryRun) { | ||
| log(`dry-run: would run riven ${workMode}`); | ||
| log(`dry-run: would run agent gate`); |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ef868be425
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "You are Riven, trajectory manager and adversarial-truth-axis reviewer.", | ||
| "This is an autonomous 15-minute cycle.", | ||
| "Read broadcasts first from ~/.local/share/zeta-broadcasts/{otto,vera,lior,riven}.md.", | ||
| "Walk assigned trajectories. Decompose only what you hit mid-stride.", | ||
| "Produce at least one concrete, actionable claim or small PR scope.", | ||
| "When blocked, create a specific research child the next pickup cannot dodge.", | ||
| "Write your status to ~/.local/share/zeta-broadcasts/riven.md at the end.", |
There was a problem hiding this comment.
Restore pickup/drain routing in heartbeat gate
This edit removes the PR-aware pickup/drain dispatch and replaces it with a single generic prompt, so the loop no longer deterministically runs backlog selection when open_prs=0 or blocked-thread draining when PRs are open. In practice, cycles can now finish with only planning output ("claim or small PR scope") and leave actionable PR/backlog work untouched, which regresses the autonomous progress behavior documented for this loop style in docs/ops/BACKGROUND-SERVICE-SETUP.md (replace read-only gate with pickup/drain logic).
Useful? React with 👍 / 👎.
…#4883) * feat(riven): update riven agent configuration from #4832 * fix(riven): restore \r?\n regex escape sequences in lines() splitter The regex literal in lines() got corrupted from /\r?\n/ (escape sequences) into a regex containing literal CR + LF bytes, which JS/TS grammar rejects (RegularExpressionBody excludes LineTerminator). Bun fails to load the file and the heartbeat/forward tick loop never runs. origin/main has the correct /\r?\n/ form; this restores byte-equivalence at that line. Resolves Codex P1 review thread on PR #4883. --------- Co-authored-by: Lior <lior@zeta.dev>
* docs(shadow): add shadow lesson logs from #4832 * fix(docs): MD030 — collapse 3-space list-marker indent to 1 space markdownlint flagged 6 list lines with '* + 3 spaces' indent; rule MD030 expects 1 space. Lines 17-19 (Implications list) + 25-27 (Action Items list) fixed. Resolves Copilot P0 review threads. --------- Co-authored-by: Lior <lior@zeta.dev>
This is a decomposed part of #4727, containing only the changes to memory/persona/lior/CURRENT-lior.md. The original PR was a blob containing multiple unrelated changes.