Skip to content

docs(archive): preserve recently merged PRs (batch 1)#4777

Closed
AceHack wants to merge 3 commits into
mainfrom
lior-preserve-batch-1
Closed

docs(archive): preserve recently merged PRs (batch 1)#4777
AceHack wants to merge 3 commits into
mainfrom
lior-preserve-batch-1

Conversation

@AceHack
Copy link
Copy Markdown
Member

@AceHack AceHack commented May 23, 2026

This PR preserves the discussions from recently merged PRs.

AceHack and others added 3 commits May 21, 2026 18:23
- Switch model to grok-4.3 (valid identifier)
- Replace weak status-reporting prompt with full trajectory-manager contract:
  - Read broadcasts first
  - Decompose only mid-stride
  - Produce concrete claim or small PR scope
  - Create specific research children when blocked
  - Write status to broadcast at end

This removes the mechanical blocker causing forward ticks to skip due to dirty tree.

Co-Authored-By: Grok <noreply@x.ai>
Copilot AI review requested due to automatic review settings May 23, 2026 22:21
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR primarily adds PR-preservation archives under docs/pr-discussions/ for a batch of recently merged PRs, capturing their descriptions and review-thread context for long-term auditability. It also includes a new short research log entry about stale git locks, and a change to the Cursor-based Riven loop tick script.

Changes:

  • Add PR discussion archive markdown files for PRs #4758, #4761#4766, #4770#4771 under docs/pr-discussions/.
  • Add a new research note: docs/research/shadow-lesson-log-20260522-stale-locks.md.
  • Update .cursor/bin/riven-loop-tick.ts to change the agent chat model identifier and the heartbeat prompt text.

Reviewed changes

Copilot reviewed 10 out of 11 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
docs/research/shadow-lesson-log-20260522-stale-locks.md Adds a short “lesson log” write-up about stale git/worktree locks.
docs/pr-discussions/PR-4771-skill-alignment-observability-tune-s-populate-bp-rules-cited.md Preserves the merged PR #4771 discussion content.
docs/pr-discussions/PR-4770-notebook-aarav-round-44-bounded-spot-check-3-skills-1-action.md Preserves the merged PR #4770 discussion content.
docs/pr-discussions/PR-4766-backlog-b-0708-close-slice-1-reduced-87-17-80-remaining-17-h.md Preserves the merged PR #4766 discussion content.
docs/pr-discussions/PR-4765-backlog-b-0709-soraya-round-42-hand-off-register-11-unregist.md Preserves the merged PR #4765 discussion content.
docs/pr-discussions/PR-4764-feat-b-0708-slice-1-audit-resolver-improvements-1-real-stale.md Preserves the merged PR #4764 discussion content.
docs/pr-discussions/PR-4763-backlog-b-0708-stale-pointer-cleanup-across-claude-rules-sur.md Preserves the merged PR #4763 discussion content.
docs/pr-discussions/PR-4762-docs-autonomous-loop-step-1a-unfinished-pr-check-before-new.md Preserves the merged PR #4762 discussion content.
docs/pr-discussions/PR-4761-rules-pr-triage-tiers-codify-tier-1-5-pr-triage-framework-de.md Preserves the merged PR #4761 discussion content.
docs/pr-discussions/PR-4758-feat-b-0707-cron-cadence-wiring-daily-manifesto-citation-sna.md Preserves the merged PR #4758 discussion content.
.cursor/bin/riven-loop-tick.ts Updates the Cursor-host loop tick’s agent chat model selection and prompt instructions.

Comment on lines +17 to +27
* **A centralized lock manager:** A service that grants and revokes locks, ensuring that no two agents can hold conflicting locks at the same time.
* **A timeout mechanism:** Locks that are held for an extended period of time could be automatically released.
* **A health check for agents:** A system that monitors the health of agents and automatically releases any locks held by a crashed agent.

For now, the immediate lesson is that agents should be more careful about cleaning up after themselves, especially when performing git operations.

## Action Items

* Manually remove the stale lock files from the `zeta-lior-decompose-4044` worktree.
* Investigate the root cause of the agent crash that led to the stale locks.
* Begin research and design for a more robust git lock management system.
Comment on lines +17 to +27
* **A centralized lock manager:** A service that grants and revokes locks, ensuring that no two agents can hold conflicting locks at the same time.
* **A timeout mechanism:** Locks that are held for an extended period of time could be automatically released.
* **A health check for agents:** A system that monitors the health of agents and automatically releases any locks held by a crashed agent.

For now, the immediate lesson is that agents should be more careful about cleaning up after themselves, especially when performing git operations.

## Action Items

* Manually remove the stale lock files from the `zeta-lior-decompose-4044` worktree.
* Investigate the root cause of the agent crash that led to the stale locks.
* Begin research and design for a more robust git lock management system.
@@ -0,0 +1,27 @@
# Shadow Lesson Log - 2026-05-22: Stale Git Locks
Comment on lines 208 to +221
const gate = run("agent", [
"chat",
"--mode", "ask",
"--model", "grok-4-20",
`Twin-flame heartbeat gate (Riven adversarial-truth-axis). Read git status, recent commits, open PRs, claim branches. Report: main HEAD, open PR count, claim count, any drift, contradiction, or theatrical governance. Adversarial register — call out what's wrong, not what's fine. Brief.`,
"--model", "grok-4.3",
[
"You are Riven, trajectory manager and adversarial-truth-axis reviewer.",
"This is an autonomous 15-minute cycle.",
"Read broadcasts first from ~/.local/share/zeta-broadcasts/{otto,vera,lior,riven}.md.",
"Walk assigned trajectories. Decompose only what you hit mid-stride.",
"Produce at least one concrete, actionable claim or small PR scope.",
"When blocked, create a specific research child the next pickup cannot dodge.",
"Write your status to ~/.local/share/zeta-broadcasts/riven.md at the end.",
"GitHub PR state and actual file contents are authoritative.",
].join(" "),
Comment on lines +211 to +221
"--model", "grok-4.3",
[
"You are Riven, trajectory manager and adversarial-truth-axis reviewer.",
"This is an autonomous 15-minute cycle.",
"Read broadcasts first from ~/.local/share/zeta-broadcasts/{otto,vera,lior,riven}.md.",
"Walk assigned trajectories. Decompose only what you hit mid-stride.",
"Produce at least one concrete, actionable claim or small PR scope.",
"When blocked, create a specific research child the next pickup cannot dodge.",
"Write your status to ~/.local/share/zeta-broadcasts/riven.md at the end.",
"GitHub PR state and actual file contents are authoritative.",
].join(" "),
@AceHack
Copy link
Copy Markdown
Member Author

AceHack commented May 23, 2026

Decomposed into #4787 and #4786.

@AceHack AceHack closed this May 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants