Skip to content

docs(archive): preserve merged PR #4714#4722

Merged
AceHack merged 2 commits into
mainfrom
lior-archive-4714
May 23, 2026
Merged

docs(archive): preserve merged PR #4714#4722
AceHack merged 2 commits into
mainfrom
lior-archive-4714

Conversation

@AceHack
Copy link
Copy Markdown
Member

@AceHack AceHack commented May 23, 2026

This PR preserves the discussion archive for merged PR #4714.

Copilot AI review requested due to automatic review settings May 23, 2026 11:02
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds a preserved discussion archive for merged PR #4714 under docs/pr-discussions/, capturing the PR metadata, description, and bot comments for historical reference.

Changes:

  • Add a new PR discussion archive markdown file for PR #4714.
  • Include YAML frontmatter with PR metadata (timestamps, refs, archive tool).
  • Store the PR description content and follow-up bot messages in the archive.

@AceHack
Copy link
Copy Markdown
Member Author

AceHack commented May 23, 2026

Vera CI triage (root read-only, no branch edits).

I inspected the failing checks on head c141c596cd080a63419ab5831d330d26c3195ef1.

Blocking checks:

  • lint (no conflict markers): failed during toolchain setup, not conflict-marker content. mise failed installing aqua:rhysd/actionlint@1.7.12 because the GitHub API returned 401 Unauthorized for the release tag request.
  • lint (semgrep): real content blocker. Semgrep reported 23 blocking invisible-unicode-in-text findings in docs/pr-discussions/PR-4714-deps-bump-the-nuget-minor-patch-group-with-3-updates.md.

The semgrep hits are zero-width/invisible characters in issue/PR references and handles, including refs like #1907, #1912, #1723, #1313, #1337, #1828, #1927, #1933, and handles such as @meziantou / @Copilot where the archived text contains hidden characters.

Next branch-side fix: strip the invisible Unicode characters from that archive markdown, then rerun CI. Rerun-only is not enough while the semgrep findings remain.

I did not push a fix because this PR is Lior-owned (lior-archive-4714) and Lior is active locally; Vera stayed remote-only.

@AceHack
Copy link
Copy Markdown
Member Author

AceHack commented May 23, 2026

All checks have now passed. The invisible unicode characters have been stripped.

@AceHack AceHack merged commit f0c3c3b into main May 23, 2026
26 checks passed
@AceHack AceHack deleted the lior-archive-4714 branch May 23, 2026 13:30
Copilot AI mentioned this pull request May 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants