Conversation
- L139: 'CommonMark MD032' → 'markdownlint MD032' (MD032 is the markdownlint rule ID 'blanks-around-lists', not a CommonMark identifier; the trigger uses CommonMark-style list markers but the lint rule itself is markdownlint's). - L145: '#280' citation reframed — there's no docs/pr-preservation/280-drain-log.md in the corpus. The #280 fix landed at write-time (commit cce1df2) before any drain log was filed for it. Cite the fix-commit rather than a per-PR log so the observation is verifiable from the stated corpus. - L170: 'Pre-commit-lint candidate' wording was vague about whether detection exists. The repo already has tools/hygiene/audit-md032-plus-linestart.sh covering the '+'-at-line-start case. Update to point at the existing audit + state the new work clearly: extend to '- '/'* ' or promote to pre-commit enforcement. Drop 'Class A' label (this doc doesn't use that label; replace with the actual prior heading 'Inline-code-span line-wrap rendering bug').
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
There was a problem hiding this comment.
Pull request overview
This PR is a follow-up hygiene update to docs/pr-preservation/_patterns.md, correcting terminology and making the documented “Line-leading list-marker confusion” pattern more verifiable and actionable by citing real artefacts already in the repo.
Changes:
- Renames the pattern heading from “CommonMark MD032” to “markdownlint MD032” to correctly attribute the rule ID.
- Replaces the non-existent PR #280 drain-log citation with a verifiable fix-commit citation.
- Clarifies the “pre-commit-lint candidate” note by pointing to the existing
tools/hygiene/audit-md032-plus-linestart.shand specifying the remaining work (extend to-/*or promote to enforcement).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Three Copilot post-merge findings on the freshly-landed Class H entry in `docs/pr-preservation/_patterns.md`:
Test plan
🤖 Generated with Claude Code