Skip to content

hygiene(#470 follow-up): fix MD032 naming + citation drift on patterns class#471

Merged
AceHack merged 1 commit intomainfrom
drain/470-followup-md032-naming-and-citations
Apr 25, 2026
Merged

hygiene(#470 follow-up): fix MD032 naming + citation drift on patterns class#471
AceHack merged 1 commit intomainfrom
drain/470-followup-md032-naming-and-citations

Conversation

@AceHack
Copy link
Copy Markdown
Member

@AceHack AceHack commented Apr 25, 2026

Summary

Three Copilot post-merge findings on the freshly-landed Class H entry in `docs/pr-preservation/_patterns.md`:

Test plan

  • Three findings are pattern instances of classes the same doc names: citation drift (Class B-ish), terminology accuracy (markdownlint vs CommonMark surface-class confusion), and pre-existing-tool-not-cited (similar to Otto-114 forward-mirror compounding).
  • Same shape as PR hygiene(_patterns.md): document Otto-250-canonical vs Otto-268-abbreviated shape divergence #467 self-correction (`_patterns.md` shape divergence corrected its own template snippet) — substrate doc continues to refine itself.

🤖 Generated with Claude Code

- L139: 'CommonMark MD032' → 'markdownlint MD032' (MD032 is the
  markdownlint rule ID 'blanks-around-lists', not a CommonMark
  identifier; the trigger uses CommonMark-style list markers but
  the lint rule itself is markdownlint's).
- L145: '#280' citation reframed — there's no
  docs/pr-preservation/280-drain-log.md in the corpus. The #280
  fix landed at write-time (commit cce1df2) before any drain log
  was filed for it. Cite the fix-commit rather than a per-PR log
  so the observation is verifiable from the stated corpus.
- L170: 'Pre-commit-lint candidate' wording was vague about
  whether detection exists. The repo already has
  tools/hygiene/audit-md032-plus-linestart.sh covering the
  '+'-at-line-start case. Update to point at the existing audit +
  state the new work clearly: extend to '- '/'* ' or promote to
  pre-commit enforcement. Drop 'Class A' label (this doc doesn't
  use that label; replace with the actual prior heading
  'Inline-code-span line-wrap rendering bug').
Copilot AI review requested due to automatic review settings April 25, 2026 09:20
@AceHack AceHack enabled auto-merge (squash) April 25, 2026 09:20
@chatgpt-codex-connector
Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR is a follow-up hygiene update to docs/pr-preservation/_patterns.md, correcting terminology and making the documented “Line-leading list-marker confusion” pattern more verifiable and actionable by citing real artefacts already in the repo.

Changes:

  • Renames the pattern heading from “CommonMark MD032” to “markdownlint MD032” to correctly attribute the rule ID.
  • Replaces the non-existent PR #280 drain-log citation with a verifiable fix-commit citation.
  • Clarifies the “pre-commit-lint candidate” note by pointing to the existing tools/hygiene/audit-md032-plus-linestart.sh and specifying the remaining work (extend to -/* or promote to enforcement).

@AceHack AceHack merged commit bfb2466 into main Apr 25, 2026
17 checks passed
@AceHack AceHack deleted the drain/470-followup-md032-naming-and-citations branch April 25, 2026 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants