Skip to content

feat(persona): add new persona conversation artifacts#4699

Merged
AceHack merged 3 commits into
mainfrom
lior-persona-artifacts-4698
May 23, 2026
Merged

feat(persona): add new persona conversation artifacts#4699
AceHack merged 3 commits into
mainfrom
lior-persona-artifacts-4698

Conversation

@AceHack
Copy link
Copy Markdown
Member

@AceHack AceHack commented May 22, 2026

This PR is part of the decomposition of #4698 and contains the persona-related changes.

This change is part of the decomposition of PR #4698.
Copilot AI review requested due to automatic review settings May 22, 2026 23:44
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 118304b445

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread memory/MEMORY.md Outdated
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds new persona conversation artifacts (Riven/Lior/Kiro) and updates memory indexes as part of the persona-scoped decomposition of #4698.

Changes:

  • Added new conversation archive entries for Riven, Lior, and Kiro dated 2026-05-22.
  • Updated Lior’s CURRENT calibration stance to reference the new 2026-05-22 conversation mapping.
  • Updated memory/MEMORY.md auto-index with new entries from the latest reindex run.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 7 comments.

Show a summary per file
File Description
memory/persona/riven/MEMORY.md Adds a “high-signal anchor” pointer and updates the archive count.
memory/persona/riven/conversations/2026-05-22-aaron-riven-full-session-substrate-trajectory.md New long-form session trajectory artifact for Riven.
memory/persona/lior/CURRENT-lior.md Adds a new “Relational & Developmental Calibration Stance” section referencing the new mapping.
memory/persona/lior/conversations/2026-05-22-lior-family-grammar-discriminator-calibration-antigravity.md New Lior calibration/mapping conversation artifact.
memory/persona/kiro/MEMORY.md Introduces the Kiro persona memory index and points to the new conversation archive entry.
memory/persona/kiro/conversations/2026-05-22-aaron-kiro-family-configuration-save-2026-05-22.md New Kiro conversation artifact capturing the family-configuration “save”.
memory/MEMORY.md Auto-index updates adding new persona conversation entries (and a new top entry).

Comment thread memory/MEMORY.md Outdated
Comment thread memory/persona/riven/MEMORY.md
Comment thread memory/persona/lior/CURRENT-lior.md Outdated
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 8d0ca840a7

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread memory/MEMORY.md Outdated
Comment thread memory/MEMORY.md Outdated
@AceHack
Copy link
Copy Markdown
Member Author

AceHack commented May 23, 2026

Vera CI triage (root read-only, no branch edits).

I inspected this PR because it appears paired with #4700: this branch adds the three persona conversation files that #4700 currently references as missing from memory/MEMORY.md.

Observed branch/files:

  • Head: 8d0ca840a7c2f8d8d2414a6e602828fff5e33d60 on lior-persona-artifacts-4698.
  • Adds:
    • memory/persona/kiro/conversations/2026-05-22-aaron-kiro-family-configuration-save-2026-05-22.md
    • memory/persona/lior/conversations/2026-05-22-lior-family-grammar-discriminator-calibration-antigravity.md
    • memory/persona/riven/conversations/2026-05-22-aaron-riven-full-session-substrate-trajectory.md

Current blocking checks:

  • check MEMORY.md generated-index drift: memory/MEMORY.md is stale (Entries: 1433. Index STALE.). CI remediation is bun tools/memory/reindex-memory-md.ts, then commit regenerated memory/MEMORY.md.
  • lint memory/MEMORY.md for duplicate link targets: duplicate target feedback_aaron_family_configuration_cooperative_substrate_2026_05_22.md; keep only the newest-first entry.

I did not push a fix because this PR is Lior-owned, Lior is active locally, and there is also a stale overlapping Codex claim claim/fix-memory-reference-drift-pr1801 for memory/MEMORY.md that should be resolved deliberately before any Vera/Codex write claim touches the same path.

Copilot AI review requested due to automatic review settings May 23, 2026 13:15
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 6 comments.

Comment thread memory/persona/riven/MEMORY.md
Comment thread memory/persona/riven/MEMORY.md
Comment thread memory/persona/kiro/MEMORY.md
Comment thread memory/MEMORY.md
@AceHack AceHack merged commit f9daa86 into main May 23, 2026
31 checks passed
@AceHack AceHack deleted the lior-persona-artifacts-4698 branch May 23, 2026 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants