refactor(riven): update riven loop tick (decomposed from #4670)#4688
refactor(riven): update riven loop tick (decomposed from #4670)#4688AceHack wants to merge 1 commit into
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1dc00a61df
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "-p", | ||
| const gate = run("agent", [ | ||
| "chat", | ||
| "--mode", "ask", |
There was a problem hiding this comment.
The gate now invokes agent chat --mode ask, but Ask mode is read-only, so the loop cannot perform the write actions it is supposed to own (claim/PR work, branch updates, and fixes). This creates a false-green path where the command can exit 0 and set riven=ok while no actionable repository changes are made, effectively stalling autonomous progress that previously ran through a writable agent invocation.
Useful? React with 👍 / 👎.
AceHack
left a comment
AceHack
left a comment
There was a problem hiding this comment.
This PR has potential drift. It removes the explicit and Determining projects to restore...
Restored /Users/acehack/zeta-lior-ops/samples/FactoryDemo.Api.CSharp/FactoryDemo.Api.CSharp.csproj (in 1.39 sec).
Restored /Users/acehack/zeta-lior-ops/samples/FactoryDemo.Api.FSharp/FactoryDemo.Api.FSharp.fsproj (in 1.44 sec).
Restored /Users/acehack/zeta-lior-ops/samples/CrmSample/CrmSample.fsproj (in 1.67 sec).
Restored /Users/acehack/zeta-lior-ops/src/Core/Core.fsproj (in 1.67 sec).
Restored /Users/acehack/zeta-lior-ops/src/Core.CSharp/Core.CSharp.csproj (in 1.67 sec).
Restored /Users/acehack/zeta-lior-ops/samples/Demo/Demo.fsproj (in 1.67 sec).
Restored /Users/acehack/zeta-lior-ops/tools/substrate-discovery/Zeta.SubstrateDiscovery.fsproj (in 1.67 sec).
Restored /Users/acehack/zeta-lior-ops/src/Bayesian/Bayesian.fsproj (in 1.67 sec).
Restored /Users/acehack/zeta-lior-ops/bench/Benchmarks/Benchmarks.fsproj (in 3.59 sec).
Restored /Users/acehack/zeta-lior-ops/bench/Feldera.Bench/Feldera.Bench.fsproj (in 3.59 sec).
Restored /Users/acehack/zeta-lior-ops/tests/Bayesian.Tests/Bayesian.Tests.fsproj (in 3.9 sec).
Restored /Users/acehack/zeta-lior-ops/tests/Tests.CSharp/Tests.CSharp.csproj (in 3.91 sec).
Restored /Users/acehack/zeta-lior-ops/tests/Tests.FSharp/Tests.FSharp.fsproj (in 3.91 sec).
Restored /Users/acehack/zeta-lior-ops/tests/Core.CSharp.Tests/Core.CSharp.Tests.csproj (in 3.91 sec).
FactoryDemo.Api.FSharp -> /Users/acehack/zeta-lior-ops/samples/FactoryDemo.Api.FSharp/bin/Debug/net10.0/FactoryDemo.Api.FSharp.dll
Core -> /Users/acehack/zeta-lior-ops/src/Core/bin/Debug/net10.0/Zeta.Core.dll
Tests.CSharp -> /Users/acehack/zeta-lior-ops/tests/Tests.CSharp/bin/Debug/net10.0/Tests.CSharp.dll
Core.CSharp -> /Users/acehack/zeta-lior-ops/src/Core.CSharp/bin/Debug/net10.0/Zeta.Core.CSharp.dll
FactoryDemo.Api.CSharp -> /Users/acehack/zeta-lior-ops/samples/FactoryDemo.Api.CSharp/bin/Debug/net10.0/FactoryDemo.Api.CSharp.dll
Core.CSharp.Tests -> /Users/acehack/zeta-lior-ops/tests/Core.CSharp.Tests/bin/Debug/net10.0/Core.CSharp.Tests.dll
CrmSample -> /Users/acehack/zeta-lior-ops/samples/CrmSample/bin/Debug/net10.0/CrmSample.dll
Feldera.Bench -> /Users/acehack/zeta-lior-ops/bench/Feldera.Bench/bin/Debug/net10.0/Feldera.Bench.dll
Demo -> /Users/acehack/zeta-lior-ops/samples/Demo/bin/Debug/net10.0/Demo.dll
Bayesian -> /Users/acehack/zeta-lior-ops/src/Bayesian/bin/Debug/net10.0/Zeta.Bayesian.dll
Zeta.SubstrateDiscovery -> /Users/acehack/zeta-lior-ops/tools/substrate-discovery/bin/Debug/net10.0/Zeta.SubstrateDiscovery.dll
Benchmarks -> /Users/acehack/zeta-lior-ops/bench/Benchmarks/bin/Debug/net10.0/Benchmarks.dll
Bayesian.Tests -> /Users/acehack/zeta-lior-ops/tests/Bayesian.Tests/bin/Debug/net10.0/Bayesian.Tests.dll
Tests.FSharp -> /Users/acehack/zeta-lior-ops/tests/Tests.FSharp/bin/Debug/net10.0/Tests.FSharp.dll
Build succeeded.
0 Warning(s)
0 Error(s)
Time Elapsed 00:00:57.33 steps, which could lead to the agent working with stale data and a lack of quality checks. Please clarify the reasoning for removing these steps and consider re-introducing them.
|
Substrate-honest close per stale-armed-PR resolution case 1 (close-as-redundant). The |
This PR contains only the Riven agent changes from #4670.