hygiene(#268+): pr-preservation drain-log for #421 (#409 follow-up)#459
Merged
hygiene(#268+): pr-preservation drain-log for #421 (#409 follow-up)#459
Conversation
Otto-268 follow-on: drain-log for the multi-class cascade PR #421 (post-merge follow-up to #409). Captures four finding classes in one follow-up: A. Node provisioning correctness (P1, CI/runtime): cross-file node-version pin drift; CI-vs-local divergence. B. Companion version alignment (P2, consistency): downstream stale-version reference. C. Otto-279 INVERSE — role-ref correction on current-state surface (operational substrate; NOT history-class). D. Downstream prose typos. Pattern observations: - Cross-file version-pin drift is a recurring CI-correctness class. Fix template: single canonical pin; all references read from it. Pre-commit-lint candidate: cross-file version-string compare. - Otto-279 INVERSE: history-class preserves names; current-state surfaces replace with role-refs. Both halves of the rule need uniform application. - Multi-finding-class cascades benefit from explicit per-class grouping in the drain-log. - Node provisioning is a high-leverage substrate-fix surface; same shape as Otto-114 forward-mirror compounding fix. URL → PR-number defensive pattern: capture URL from gh-pr-create output before arming auto-merge to avoid Dependabot-PR-number- collision (lesson from #454/#455 hazard earlier this tick).
There was a problem hiding this comment.
Pull request overview
Adds a PR-preservation drain log documenting the post-merge finding cascade for PR #421 (follow-up to #409), capturing the threads, outcomes, and recurring patterns for future drain-runners.
Changes:
- Added a new drain-log entry for PR #421 under
docs/pr-preservation/. - Organized preserved findings by class (node provisioning, version alignment, role-refs, typos) and recorded outcomes.
- Captured pattern observations intended as Otto-250 training-signal material.
Comment on lines
+5
to
+6
| Drain session: 2026-04-25 (Otto, sustained-drain-wave during maintainer- | ||
| asleep window; pre-summary-checkpoint earlier in this session) |
There was a problem hiding this comment.
The manual line wrap splits a hyphenated phrase across lines ("maintainer-" + "asleep"), which will render as "maintainer- asleep" in Markdown. Reflow this so the phrase is continuous (e.g., wrap after a space instead of inserting a hyphen at line end).
Suggested change
| Drain session: 2026-04-25 (Otto, sustained-drain-wave during maintainer- | |
| asleep window; pre-summary-checkpoint earlier in this session) | |
| Drain session: 2026-04-25 (Otto, sustained-drain-wave during | |
| maintainer-asleep window; pre-summary-checkpoint earlier in this session) |
Comment on lines
+106
to
+109
| gets blocked until the mismatch is resolved. Single-source-of- | ||
| truth pinning eliminates this class entirely. Same shape as the | ||
| Otto-114 forward-mirror substrate-compounding fix: structural | ||
| change converts per-PR fix-toil into never-recurring. |
There was a problem hiding this comment.
This line wrap splits the hyphenated phrase "Single-source-of-truth" across lines, which will render as "Single-source-of- truth". Reflow to keep the hyphenated phrase unbroken (or remove the hard hyphenation and wrap at a word boundary).
Suggested change
| gets blocked until the mismatch is resolved. Single-source-of- | |
| truth pinning eliminates this class entirely. Same shape as the | |
| Otto-114 forward-mirror substrate-compounding fix: structural | |
| change converts per-PR fix-toil into never-recurring. | |
| gets blocked until the mismatch is resolved. | |
| Single-source-of-truth pinning eliminates this class entirely. | |
| Same shape as the Otto-114 forward-mirror substrate-compounding | |
| fix: structural change converts per-PR fix-toil into | |
| never-recurring. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Otto-268 follow-on: drain-log for PR #421 — multi-class cascade follow-up to #409 (node provisioning + version + role-refs + typos in one PR).
Per Otto-250 (PR review comments + responses + resolutions are high-quality training signals).
Coverage — four finding classes
Pattern observations
Test plan
docs/pr-preservation/*-drain-log.mdtemplate.🤖 Generated with Claude Code