Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(core): PR 4 of 8 — IncrementalAuto capability-aware dispatcher #4564
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
feat(core): PR 4 of 8 — IncrementalAuto capability-aware dispatcher #4564
Changes from all commits
274455a30fb398File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IncrementalAutodecides the strategy fromprobedOutput.Op.IsLinear, which only describes the final operator inq, not the wholeqgraph. This misclassifies composite queries such asq = map ∘ distinct: the terminalmapis linear, so the dispatcher returnsq(delta)even thoughdistinctupstream is non-linear and requiresD∘Q∘I. In that case the second duplicate delta is emitted incorrectly instead of being suppressed, so incremental results diverge from the true query delta.Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
DelayOpis markedIsLinear = trueunconditionally, butDelay(s, initial)is affine wheninitialis non-zero (delay(0)emitsinitialon the first tick). WithIncrementalAuto, any query containingDelaywith a non-empty initial Z-set can be routed down the linear fast path (Q^Δ = Q) and produce wrong deltas on the first tick. The capability should only be linear when the initial value is the group zero.Useful? React with 👍 / 👎.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.