-
Notifications
You must be signed in to change notification settings - Fork 1
hygiene(#268+): pr-preservation drain-log for #424 (4-parent cascade) #453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -0,0 +1,121 @@ | ||||||
| # PR #424 drain log — drain follow-up to #405 + #411 + #413 + #415: empty-cone safeguard + GITHUB_TOKEN header + grammar + Otto-279 policy reply | ||||||
|
|
||||||
| PR: <https://github.com/Lucent-Financial-Group/Zeta/pull/424> | ||||||
| Branch: `drain/405-411-413-415-followup` | ||||||
| Drain session: 2026-04-25 (Otto, sustained-drain-wave during maintainer- | ||||||
| asleep window; pre-summary-checkpoint earlier in this session) | ||||||
| Thread count at drain: 4-parent cascade with mixed real-fix + | ||||||
| surface-class findings. | ||||||
| Rebase context: clean rebase onto `origin/main`; no conflicts. | ||||||
|
|
||||||
| Per Otto-250 (PR review comments + responses + resolutions are | ||||||
| high-quality training signals): full record of the post-merge | ||||||
| findings spanning four parent PRs simultaneously — record-breaking | ||||||
| multi-parent cascade in this drain wave. | ||||||
|
Comment on lines
+11
to
+14
|
||||||
|
|
||||||
| This PR is the **maximum-multi-parent cascade** observed in this | ||||||
| drain wave: a follow-up to FOUR parent PRs simultaneously | ||||||
| (#405 + #411 + #413 + #415), batching the post-merge findings | ||||||
| into a single commit + single merge gate rather than serializing | ||||||
| into four separate cascades. | ||||||
|
|
||||||
| --- | ||||||
|
|
||||||
| ## Threads — by parent | ||||||
|
|
||||||
| ### Parent #405 — empty-cone safeguard | ||||||
|
|
||||||
| #### Thread 1.1 — fail-YELLOW vs fail-RED on empty-cone | ||||||
|
|
||||||
| - Severity: P1 (CI safety) | ||||||
| - Finding: parent #405 had a script that on empty-cone (zero | ||||||
| qualifying commits in the audit window) would fail-RED and | ||||||
| block the merge gate; safer behavior is fail-YELLOW (warn | ||||||
| but don't block) since empty-cone is structurally normal in | ||||||
| certain windows (right after main resync, or during quiet | ||||||
| periods). | ||||||
| - Outcome: **FIX** — empty-cone behavior changed to fail-YELLOW | ||||||
| (exit 0 with warning to stderr) rather than fail-RED. CI still | ||||||
| fires on real findings; doesn't block on empty-cone. | ||||||
|
|
||||||
| ### Parent #411 — GITHUB_TOKEN header doc | ||||||
|
|
||||||
| #### Thread 2.1 — `Authorization: Bearer` vs `Authorization: token` | ||||||
|
|
||||||
| - Severity: P2 (docs) | ||||||
| - Finding: parent #411 docs cited `Authorization: Bearer | ||||||
| $GITHUB_TOKEN` as the canonical header; current `gh` CLI + | ||||||
| GitHub Actions API examples use `Authorization: token | ||||||
| $GITHUB_TOKEN` (Bearer is also accepted but `token` is the | ||||||
| GitHub-canonical example shape). | ||||||
| - Outcome: **FIX** — header doc updated to use `token` form | ||||||
| matching GitHub-canonical examples; note that Bearer is also | ||||||
|
||||||
| matching GitHub-canonical examples; note that Bearer is also | |
| matching GitHub-canonical examples, with the note that Bearer is also |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: “Thread count at drain” is describing the parent-cascade shape rather than the numeric thread count. Since this drain has 4 threads (1.1–4.1), consider rewording to something like “Thread count at drain: 4 threads across 4 parents …” for consistency with other drain logs (e.g., #422).