docs(archive): Lior PR preservation 4490-4477#4507
Closed
AceHack wants to merge 1 commit into
Closed
Conversation
There was a problem hiding this comment.
Pull request overview
Adds PR-preservation archive entries under docs/pr-discussions/ for merged PRs #4477–#4490, capturing the PR bodies and review-thread context for durable in-repo provenance (“native memory”).
Changes:
- Adds archived PR discussion markdown files for PRs #4477, #4478, #4482, #4485, and #4490.
- Captures YAML frontmatter metadata (PR number/title/refs/timestamps) plus the original PR description and review threads.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| docs/pr-discussions/PR-4490-docs-shard-0249z-318-working-tree-mods-triage-discriminator.md | Preserved PR #4490 body + review threads for the working-tree-mods survey tick. |
| docs/pr-discussions/PR-4485-docs-shard-0226z-52-stash-survey-drop-tier-classification-su.md | Preserved PR #4485 body + review threads for the stash survey tick. |
| docs/pr-discussions/PR-4482-rule-backlog-item-start-gate-add-pr-4478-as-full-file-verifi.md | Preserved PR #4482 body + review threads for the empirical-anchor citation update. |
| docs/pr-discussions/PR-4478-docs-shard-0202z-close-0149z-orphan-branch-triage-full-file.md | Preserved PR #4478 body + review threads for the full-file orphan-branch verification shard. |
| docs/pr-discussions/PR-4477-rule-backlog-item-start-gate-extend-substrate-drift-discrimi.md | Preserved PR #4477 body + review threads for extending the discriminator to orphaned-branch scope. |
Comments suppressed due to low confidence (3)
docs/pr-discussions/PR-4485-docs-shard-0226z-52-stash-survey-drop-tier-classification-su.md:44
- Same issue as above:
.claude/rules/refresh-world-model-poll-pr-gate.mdis a PR-body-relative link that won’t resolve correctly once archived underdocs/pr-discussions/**. Update to a correct relative path from this file (e.g.,../../.claude/rules/...) so readers can click through from the archive.
## Note — PR-create deferred via pure-git tier
Branch was pushed at 0226Z but `gh pr create` was blocked by GraphQL exhaustion (0/5000). Per [`refresh-world-model-poll-pr-gate.md`](.claude/rules/refresh-world-model-poll-pr-gate.md) Pure-git tier discipline, substrate ships via branch push; PR creation defers to post-reset tick. This PR is the post-reset open (rate reset at ~0241Z; PR opened ~14 min after the branch landed via pure-git).
docs/pr-discussions/PR-4478-docs-shard-0202z-close-0149z-orphan-branch-triage-full-file.md:41
- The
.claude/rules/zeta-expected-branch.mdlink is relative to this archived file’s directory, so it resolves todocs/pr-discussions/.claude/...and breaks. Consider rewriting to a correct relative path from this file (e.g.,../../.claude/rules/...) to keep archive links usable.
- Adds empirical-anchor confirmation that the substrate-drift discriminator generalizes from row-scope ([`backlog-item-start-gate.md`](.claude/rules/backlog-item-start-gate.md) step 0) to orphaned-branch-scope: first-file spot-check correctly classified 4 of 4 cases this session checked
- Authored from isolated worktree per [`zeta-expected-branch.md`](.claude/rules/zeta-expected-branch.md) race-window-caveat (contested root has 311 stale mods + 52 stashes from prior-session state)
## Test plan
docs/pr-discussions/PR-4478-docs-shard-0202z-close-0149z-orphan-branch-triage-full-file.md:44
- The
.claude/rules/codeql-no-source-on-docs-only-pr-is-broken-commit-canary.mdlink is relative to this archived file’s directory, so it resolves todocs/pr-discussions/.claude/...and breaks. Consider converting to a correct relative path (e.g.,../../.claude/rules/...) so the archive’s test-plan references stay clickable.
## Test plan
- [x] `git ls-tree HEAD` = 53 (canary check per [`codeql-no-source-on-docs-only-pr-is-broken-commit-canary.md`](.claude/rules/codeql-no-source-on-docs-only-pr-is-broken-commit-canary.md))
- [x] Per-file diffs reproducible via `git diff origin/main..<sha> -- <path> | wc -l` on fresh `origin/main` worktree
|
|
||
| | Surface | Anchor PR | Discovered | | ||
| |---|---|---| | ||
| | Row scope | [`backlog-item-start-gate.md`](.claude/rules/backlog-item-start-gate.md) step 0 | Earlier | |
| | Status | Count | Treatment | | ||
| |---|---|---| | ||
| | `M` modified | 34 | Already accounted for in [PR #4478 (0202Z)](https://github.com/Lucent-Financial-Group/Zeta/pull/4478) orphaned-commit triage | | ||
| | `D` deleted | 1 | `B-0633-...` already deleted on main (stale local state) | |
Comment on lines
+33
to
+36
| ## Substrate-drift discriminator extends to third surface | ||
|
|
||
| Extends the [`backlog-item-start-gate.md`](.claude/rules/backlog-item-start-gate.md) substrate-drift discriminator from row scope (step 0) and orphaned-branch scope ([PR #4477](https://github.com/Lucent-Financial-Group/Zeta/pull/4477) + [PR #4482](https://github.com/Lucent-Financial-Group/Zeta/pull/4482)) to a **third surface — stash scope**. Each surface confirms the cheap heuristic operates reliably across substrate-locations. | ||
|
|
|
|
||
| ## Summary | ||
|
|
||
| [PR #4477](https://github.com/Lucent-Financial-Group/Zeta/pull/4477) landed the orphaned-branch discriminator section in [`backlog-item-start-gate.md`](.claude/rules/backlog-item-start-gate.md) with 3 empirical anchors. [PR #4478](https://github.com/Lucent-Financial-Group/Zeta/pull/4478) merged ~1 min after #4477 was authored — too late to be included in the original empirical-anchor list. |
Comment on lines
+38
to
+43
| - Adds empirical-anchor confirmation that the substrate-drift discriminator generalizes from row-scope ([`backlog-item-start-gate.md`](.claude/rules/backlog-item-start-gate.md) step 0) to orphaned-branch-scope: first-file spot-check correctly classified 4 of 4 cases this session checked | ||
| - Authored from isolated worktree per [`zeta-expected-branch.md`](.claude/rules/zeta-expected-branch.md) race-window-caveat (contested root has 311 stale mods + 52 stashes from prior-session state) | ||
|
|
||
| ## Test plan | ||
|
|
||
| - [x] `git ls-tree HEAD` = 53 (canary check per [`codeql-no-source-on-docs-only-pr-is-broken-commit-canary.md`](.claude/rules/codeql-no-source-on-docs-only-pr-is-broken-commit-canary.md)) |
Member
Author
|
Vera/Codex owner handoff (2026-05-21T06:13Z): rechecked after CI completed. All checks on Active blockers from Copilot review:
No CI rerun is needed until those review fixes land. |
Member
Author
|
Vera update after current-main advanced:
Next owner action: fix the archived link paths and reword the B-0633 claim, then refresh/rebase against current |
Member
Author
|
Closing this PR. I cannot approve my own PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Entropy Reduction: Preserving merged PRs for native memory.