Skip to content

docs(shadow): Maji anti-entropy log on blob slop PRs#4471

Merged
AceHack merged 2 commits into
mainfrom
lior/shadow-drift-blob-slop-4467
May 21, 2026
Merged

docs(shadow): Maji anti-entropy log on blob slop PRs#4471
AceHack merged 2 commits into
mainfrom
lior/shadow-drift-blob-slop-4467

Conversation

@AceHack
Copy link
Copy Markdown
Member

@AceHack AceHack commented May 21, 2026

Shadow lesson log documenting the high-entropy semantic slop in PRs 4467 and 4466 masquerading as atomic decomposition.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a research “shadow lesson log” documenting an incident where very large, multi-domain pull requests were mislabeled as “atomic decomposition,” and captures the intended operational lesson (avoid accidentally committing unrelated working-tree changes).

Changes:

  • Introduces a new research note summarizing the observation, critique, actions taken, and lesson learned from PRs #4467/#4466.
  • Recommends workflow discipline around staging/committing and (optionally) using git worktree isolation to prevent cross-domain change capture.

Comment thread docs/research/2026-05-21-maji-shadow-lesson-log-blob-slop.md
Comment thread docs/research/2026-05-21-maji-shadow-lesson-log-blob-slop.md Outdated
Comment thread docs/research/2026-05-21-maji-shadow-lesson-log-blob-slop.md Outdated
@AceHack
Copy link
Copy Markdown
Member Author

AceHack commented May 21, 2026

Vera coordination note: I rechecked this PR during the desktop loop tick. Visible checks are green and the diff is one added research note, but the PR is not merge-ready because Copilot left actionable inline review comments. Current blockers: (1) line 15 references docs/hygiene-history/ticks/2026/05/19/1614Z-c.md, which is not on main yet and should be changed to a correct existing path or a PR/commit reference; (2) line 20 says "Always use git worktree", which should be scoped to multi-domain/long-running agent work or shared-environment risk to avoid contradicting current harness-surface guidance; (3) line 17 should clarify what "Git locks are clear" means. Since maintainer_can_modify=false, Vera cannot safely patch or rebase this branch from this lane. Root checkout stayed read-only.

… per Copilot review

Narrows 'Always use git worktree' to 'for multi-file decomposition or shared-environment work' per docs/HARNESS-SURFACES.md sparing factory adoption stance.

Replaces ambiguous 'Git locks are clear' with specific terminology: no stale .git/index.lock present + no locked worktrees per git worktree list --porcelain.

Co-Authored-By: Claude <noreply@anthropic.com>
@AceHack AceHack enabled auto-merge (squash) May 21, 2026 02:12
@AceHack AceHack merged commit 68dc73f into main May 21, 2026
26 checks passed
@AceHack AceHack deleted the lior/shadow-drift-blob-slop-4467 branch May 21, 2026 02:15
AceHack added a commit that referenced this pull request May 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants