hygiene(#268): pr-preservation drain-log for #85 (per-row-file ADR)#446
Merged
hygiene(#268): pr-preservation drain-log for #85 (per-row-file ADR)#446
Conversation
…cture ADR) Otto-268 backfill: drain-log for PR #85 covering 11 threads (10 IDs + 1 dup) across 7 distinct fixes + 1 surface-class. High density of internal-consistency findings (5 of 7) — tier-scheme vs directory-tree gap, id-vs-filename inconsistency, "never edit / hand-append" contradiction, `tools/migrations/` claimed-vs-actual, PR-description vs ADR directory name. Per Otto-250 training-signal discipline. Pattern observations capture four load-bearing patterns: 1. Internal-consistency-finding density on draft ADRs (5 of 7) — draft ADRs evolve their own self-references during authoring; reviewers catch the accumulated inconsistencies. 2. Otto-279 surface-class for ADRs as history-class preserved provenance — stripping decision-maker names would break audit chain. 3. Live-count vs frozen-count drift as findings class; fix template is order-of-magnitude approximation + drift-tolerance note. 4. Stale-merge-commit-on-PR-head needed force-push reconciliation; rebase + force-push sometimes appears to "lose content" against a stale merge-commit head, actually fixes content equivalence.
There was a problem hiding this comment.
Pull request overview
Adds a PR-preservation drain log for PR #85 to archive review threads, responses, and resolutions per the Otto-250 training-signal/audit-trail discipline.
Changes:
- Added
docs/pr-preservation/85-drain-log.mddocumenting outcomes for 11 review threads on PR #85. - Captured summary “pattern observations” and final resolution metadata for the drained PR.
Merged
4 tasks
AceHack
added a commit
that referenced
this pull request
Apr 25, 2026
…iated shape divergence (#467) * hygiene(_patterns.md): document Otto-250-canonical vs Otto-268-abbreviated drain-log shape divergence Multiple post-merge reviewer threads on the Otto-268-wave drain-logs (#437-#465) flagged that the abbreviated inline shape doesn't match the canonical Otto-250 multi-section format used in older drain-logs (#108, #247, etc.). The findings are correct: the shapes ARE different, and the abbreviated shape compresses verbatim reviewer/reply text into short prose. Documenting both shapes here in `_patterns.md` as a known divergence + three maintainer-decision options: (a) Rewrite — high churn, highest faithfulness. (b) Accept divergence — document both as valid. (c) Hybrid — canonical for substantive logs (math / crypto / algorithms / ADRs); abbreviated for low-substance. Until maintainer decides, drain-runners writing future logs default to canonical; existing Otto-268-wave logs stay abbreviated with this known-divergence pointer. This is the right place for the documentation per the synthesis- over-history surface-class declaration: `_patterns.md` reflects current corpus state including known shape divergences, separate from the per-log records. Composes with the per-PR drain-log threads currently flagging the shape-conformance gap on #437/#441/#442/#444/#445/#446/#447/#449/ #460/#461/#464/#466 — those threads can now reply with a one-line pointer to this section instead of repeating the maintainer- decision-pending framing. * hygiene(#467): fix 4 Copilot findings on shape-divergence section Four Copilot catches converging on the same root cause: the shape-divergence section was citing drain-log PR-numbers (#437-#465) when readers will look for #437-drain-log.md etc. and not find them — drain-log FILE numbers reference the PRESERVED PR (e.g., #421/#422/#423), not the drain-log PR itself. The current file corpus ends at #434. Fixes: - :374 + :394 — drop the misleading "#437-#465" PR-range citation; cite the actual in-repo abbreviated-shape examples (#421/#422/#423) by file path; drop the unsupported "22+" numeric estimate in favour of "the 2026-04-25 backfill wave". - :380 — abbreviated template snippet now matches what the in-repo abbreviated logs actually use: `Finding:` bullet included, `Thread ID:` and `:LINE` placeholders dropped (those are canonical-shape fields, not abbreviated-shape). Reader can now copy/paste the template accurately. - :388 — soften the "Substance is preserved" overstatement to the objective claim: key metadata (reviewer/severity/outcome/ commit) is preserved; verbatim original-comment + verbatim reply text are NOT preserved; multi-section structure + file:line locator + Thread ID are also typically omitted. The fixes are themselves Class A (count-vs-list cardinality on "#437-#465" range) + truth-drift on a freshly-landed doc — appropriate self-application of the discipline this section documents.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Otto-268 backfill: drain-log for PR #85 (Round 44 batch 5: BACKLOG-per-row-file restructure ADR draft), covering 11 threads.
Per Otto-250 (PR review comments + responses + resolutions are high-quality training signals).
Coverage — high internal-consistency-fix density
docs/backlog-rows/vsdocs/backlog/), id-vs-filename ambiguity (<id>≡<slug>-<YYYY-MM-DD>stem), tier-scheme vs directory-tree gap (addeddeclined/folder), "never edit / hand-append" contradiction,tools/migrations/claimed-as-existing (now "Proposed convention"), line-count drift (5,957 → ~6k with drift-tolerance note), trailing+continuation reformatted.docs/DECISIONS/is history-class; ADRs preserve decision-maker provenance.Pattern observations
eae7a37); actually brought current main PLUS the fixes into linear history atd38e109. PR view sync took a few seconds.Test plan
docs/pr-preservation/*-drain-log.mdtemplate.🤖 Generated with Claude Code