Skip to content

fix(bg-notifier-test): platform-independent path assertions #4450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AceHack merged 1 commit into from
May 20, 2026
Merged

fix(bg-notifier-test): platform-independent path assertions #4450

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions tools/bg/backlog-ready-notifier.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import { describe, expect, test } from "bun:test";
import { join } from "node:path";
import {
DEFAULT_CONFIG,
defaultHistoryFile,
Expand Down Expand Up @@ -469,12 +470,15 @@ title: only a title

describe("assignment-history cooldown (slice 5a)", () => {
test("defaultHistoryFile honors ZETA_BUS_DIR env var when set", () => {
// Use `path.join` for expected values so the assertion is platform-
// independent (PR #4449 review finding: hard-coded forward slashes
// would fail on Windows where path.join returns backslashes).
const before = process.env.ZETA_BUS_DIR;
try {
process.env.ZETA_BUS_DIR = "/var/zeta-test";
expect(defaultHistoryFile()).toBe("/var/zeta-test/assignment-history.json");
expect(defaultHistoryFile()).toBe(join("/var/zeta-test", "assignment-history.json"));
delete process.env.ZETA_BUS_DIR;
expect(defaultHistoryFile()).toBe("/tmp/zeta-bus/assignment-history.json");
expect(defaultHistoryFile()).toBe(join("/tmp/zeta-bus", "assignment-history.json"));
} finally {
if (before === undefined) delete process.env.ZETA_BUS_DIR;
else process.env.ZETA_BUS_DIR = before;
Expand Down
Loading