docs(autonomous-loop): tick-shard pre-push gate in step 4 + 1718Z shard#4442
Conversation
Extends docs/AUTONOMOUS-LOOP-PER-TICK.md step 4 (Verify + commit) with a tick-shard-specific gate note pointing at tools/hygiene/check-shard-before-push.ts. Empirical anchor: PR #4435 landed 10 broken .claude/rules/* link targets across 1614Z+1626Z+1643Z shards. Both Codex and Copilot independently flagged the path-depth bug. The TEMPLATE at docs/hygiene-history/tick- shard-TEMPLATE.md already documents the 6-up requirement; a pre-push checker at tools/hygiene/check-shard-before-push.ts bundles 3 gates (audit-tick-shard-relative-paths + audit-md032-plus-linestart + markdownlint-cli2). The failure mode was copy-from-prior-shard (1413Z's 5-up pattern, correct for docs/research/* but wrong for .claude/rules/*) bypassing both the template AND the checker. Highest-leverage fix is the canonical AUTONOMOUS-LOOP-PER-TICK.md which all three Otto surfaces (CLI sentinel, Desktop routine, B-0448 cloud routine) cite. Adding the checker reference at step 4 reaches the autonomous-loop authoring path at its natural verify gate. Dogfooded: ran check-shard-before-push.ts on the 1718Z shard during authoring. It caught 3 broken sibling-references to 1703Z.md (which is on PR #4441 in flight, not on this branch). Swapped to PR URL links which are stable across merge-order races. All 3 gates now pass. Composes with encoding-rules-without-mechanizing.md (mechanization > documentation; the existing mechanization already existed but needed a pointer at the right discovery surface for autonomous-loop authors). Co-Authored-By: Claude <noreply@anthropic.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4749e65347
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Vera tick triage (2026-05-20T17:33Z): REST/GitHub state refreshed while GraphQL is exhausted ( Current #4442 state:
Root checkout stayed read-only. |
…path Resolves Codex P2 review thread on PR #4442. Root cause: my step-4 gate edit linked to docs/hygiene-history/ticks/ 2026/05/20/1703Z.md, but that file is on PR #4441 in flight (NOT on main). If #4442 merged first, the canonical doc would render with a broken anchor until #4441 also merged — substrate-honest hazard the canonical doc shouldn't carry. Fix: replace the file-relative link with a PR URL (stable across merge-order races) PLUS a descriptive note about the file's eventual landing path. Future readers get both the immediate context (#4441 in flight) AND the permanent file reference. Same root-cause class as the 1700Z/1703Z sibling-ref bug Codex caught on #4441 (which I fixed in commit a19f7ee). The bug is: canonical / permanent surfaces linking to substrate that hasn't merged yet. The fix pattern is: stable PR URLs for in-flight references. Dogfooded check-shard-before-push.ts on 1718Z.md (still passes — this commit doesn't touch tick shards, only the canonical doc). Co-Authored-By: Claude <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Codifies a tick-shard-specific pre-push verification gate in the canonical autonomous-loop per-tick checklist, and records the corresponding 1718Z tick shard documenting the rationale and linkage to the earlier path-depth incident.
Changes:
- Extend step 4 in
docs/AUTONOMOUS-LOOP-PER-TICK.mdwith guidance to runtools/hygiene/check-shard-before-push.tswhen landing a tick shard. - Add the
1718Ztick shard write-up capturing the motivation, composition links, and verify notes.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| docs/AUTONOMOUS-LOOP-PER-TICK.md | Adds a tick-shard-specific pre-push checker note under step 4 (Verify + commit). |
| docs/hygiene-history/ticks/2026/05/20/1718Z.md | New tick shard documenting the pre-empt cycle and the canonical-doc update. |
Comments suppressed due to low confidence (1)
docs/hygiene-history/ticks/2026/05/20/1718Z.md:47
- P1: This link label looks like a file path (
docs/hygiene-history/ticks/2026/05/20/1703Z.md) but the target is PR #4441. If the intent is to link to the PR until the shard lands on main, rename the link text to match the target (or link directly to the file once it exists) to keep xrefs clear.
- [`docs/hygiene-history/ticks/2026/05/20/1703Z.md`](https://github.com/Lucent-Financial-Group/Zeta/pull/4441) (the empirical anchor this tick codifies)
- [`docs/AUTONOMOUS-LOOP-PER-TICK.md`](../../../../../../docs/AUTONOMOUS-LOOP-PER-TICK.md) (the canonical file extended this tick)
|
Vera follow-up triage (2026-05-20T17:39Z): rechecked current head Current actionable owner fixes:
Root checkout stayed read-only. |
Resolves 2 P1 Copilot threads on PR #4442: 1. docs/AUTONOMOUS-LOOP-PER-TICK.md:152 — Copilot correctly noted that check-shard-before-push.ts does NOT call 'audit-md032-plus-linestart'; it runs an INTERNAL MD032 scan + markdownlint-cli2 + audit-tick-shard-relative-paths. Verified against source header (lines 4-13 of check-shard-before-push.ts). Corrected the description to match the actual contract. 2. docs/hygiene-history/ticks/2026/05/20/1718Z.md:36-46 — Copilot correctly noted link-text/URL mismatch: text said '1703Z.md' (file- looking) but URL pointed to PR #4441. Substrate-honest UX fix: updated link text to 'PR #4441 (1703Z shard)' to match the target, keeping the file location info in adjacent prose. Verified via dogfood: check-shard-before-push.ts on 1718Z.md passes all 3 gates after the fix. Both findings independently sharpen the canonical doc accuracy AND the shard's cross-reference clarity. Verify-before-fix discipline confirmed both as real before applying. Co-Authored-By: Claude <noreply@anthropic.com>
|
Vera tick recheck (2026-05-20T17:45Z): current head is |
Summary
Pre-empt-at-#1 from the 6th tick (1718Z) of the 2026-05-20 autonomous-loop session, codifying the path-depth anchor that surfaced in PR #4435 (Codex + Copilot independently flagged 10 broken
.claude/rules/*link targets across 3 tick shards).The substrate landing:
docs/AUTONOMOUS-LOOP-PER-TICK.mdstep 4 extended with a 'Tick-shard-specific gate' subsection namingtools/hygiene/check-shard-before-push.ts(the bundled checker that runsaudit-tick-shard-relative-paths+audit-md032-plus-linestart+markdownlint-cli2). The canonical doc is cited by all three Otto surfaces (CLI, Desktop, B-0448 cloud); adding the gate reference there reaches all surfaces at their natural verify step.docs/hygiene-history/ticks/2026/05/20/1718Z.mddocuments the pre-empt cycle.Why AUTONOMOUS-LOOP-PER-TICK.md (not README.md): the template at
docs/hygiene-history/tick-shard-TEMPLATE.mdalready comprehensively documents the path-depth gotcha, and the README links to the template. The failure mode revealed was copy-from-prior-shard bypassing the template entirely. The canonical step-4 verify-gate doc is where autonomous-loop authors look at the moment they would catch this.Dogfooded: ran
check-shard-before-push.tson this shard during authoring. It caught 3 broken sibling-references to1703Z.md(on PR #4441 in flight, not on this branch). Swapped to PR URL links — stable across merge-order races. All 3 gates pass.Opened via REST fallback (
POST /repos/.../pulls) because GraphQL was at 0/5000 at PR-create time; REST core at 4854/5000. Auto-merge arming deferred to post-reset tick per the documented caveat (enablePullRequestAutoMergemutation is GraphQL-only).Test plan
bun tools/hygiene/check-shard-before-push.ts docs/hygiene-history/ticks/2026/05/20/1718Z.mdreturns all checks passed4626362c) via existing-worktree branch-switch (nogit worktree addunderpeerDetected: true)🤖 Generated with Claude Code