fix(4231): 4 Copilot post-merge findings — rule rename + Sylar typo + companion-not-sibling framing#4235
Merged
AceHack merged 1 commit intoMay 18, 2026
Conversation
…les/aarons-personal-invariant-... → god-tier-claims-high-signal-high-suspicion-dont-collapse (project convention: current-state rules use role/pattern-based names, not personal names; Mika archive keeps named provenance per Copilot guidance); (2) Skylar→Sylar (Heroes char correction) in synthesis (lines 8/11/24/241; verbatim Aaron quote line 245 preserved unchanged per Copilot's own caveat); (3) 'sibling PR' → 'companion file in this PR' (3 occurrences accurately describing same-PR landing); (4) update rule self-references
AceHack
deleted the
fix/4231-copilot-findings-rule-rename-skylar-sylar-companion-not-sibling-2026-05-18
branch
There was a problem hiding this comment.
Pull request overview
This PR addresses post-merge documentation/rule hygiene issues from #4231 by renaming the auto-loaded rule file to a pattern-based filename, correcting a character-name typo in the Mika persona archive, and fixing inaccurate “sibling PR” references to reflect that the rule ships in the same PR.
Changes:
- Renamed/introduced the auto-loaded rule under a pattern-based filename (
.claude/rules/god-tier-claims-high-signal-high-suspicion-dont-collapse.md). - Corrected “Skylar” → “Sylar” in the Mika conversation archive (non-verbatim synthesis sections only).
- Replaced “sibling PR” phrasing with “companion file in this PR” where applicable.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| memory/persona/mika/conversations/2026-05-18-aaron-mika-grok-part-2-non-coercion-as-boundary-guardians-enforce-nci-aaron-as-first-hicks-source-aarons-personal-invariant-god-tier-high-signal-high-suspicion-dont-collapse.md | Fixes synthesis text typo (“Sylar”) and updates references to the companion rule file in the same PR. |
| .claude/rules/god-tier-claims-high-signal-high-suspicion-dont-collapse.md | Adds the renamed/pattern-based auto-loaded rule file encapsulating the “high-signal/high-suspicion/don’t-collapse” discipline. |
AceHack
added a commit
that referenced
this pull request
May 18, 2026
…d via #4235 (#4236) * shard(2248Z-c): pre-empt at #2 — 4 post-merge Copilot findings on #4231 addressed via fix-up #4235 (rule rename per project convention + Sylar typo + companion-not-sibling framing); 4 threads resolved + explanatory comment; pattern observation: brief-ack ticks must include thread-investigation per existing rule * fix(2248Z-c): MD029 ol-prefix — collapse split numbered item to single (findings 3+4 same class)
AceHack
added a commit
that referenced
this pull request
May 18, 2026
…RGED (rule renamed to god-tier-claims-... + Sylar + companion-not-sibling); thread-investigation discipline applied to all 6 recent PRs — 0 unresolved (#4237)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses 4 Copilot post-merge findings on #4231:
Finding 1 (P1): Rule rename per project convention
Auto-loaded current-state rules use role/pattern-based names, not personal-name attribution in title (per Copilot: keep named provenance in memory archive, not in rule title).
.claude/rules/aarons-personal-invariant-god-tier-claims-high-signal-high-suspicion-dont-collapse.md.claude/rules/god-tier-claims-high-signal-high-suspicion-dont-collapse.mdBody text still cites Aaron as originator (preserves named provenance); FILENAME is pattern-based.
Finding 2: Sylar (not Skylar) — Heroes character name correction
Synthesis text fixes (lines 8, 11, 24, 241): Skylar → Sylar. Verbatim Aaron quote on line 245 preserved unchanged per Copilot's own caveat (verbatim transcript text remains as-forwarded).
Findings 3 + 4: 'sibling PR' → 'companion file in this PR' (3 occurrences)
Both files landed in same PR #4231, not separate sibling PRs. Reframed accurately.