Conversation
…ew-DISCLOSURE refinement, 5 threads) #408 is the middle link in the three-PR policy-evolution chain (#407 gate → #408 DISCLOSURE → #410 agent-review-is-enough). All five review threads were about carrying the reframing through the prose consistently: - Codex P2 — contradictory gate wording in disclosure row - Codex P2 — distinct tags per stage (unreviewed vs agent-reviewed) - Copilot — "Peer review is the gate" remnant after refinement - Copilot — "gate state" vs "disclosure state" terminology - Copilot — "External reviewer" criterion captures internal sessions All 5 resolved in single commit e338c69 before auto-merge fired. Drain-log is pedagogically load-bearing: it captures the policy- evolution step where the gate concept got demoted to a disclosure marker. Composes with the #405 Wave 2 log (captured in #414) and the broader Otto-250 preservation discipline. Archive intentionally excluded from markdownlint via the preservation-ignore landed in #409. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Adds a PR-preservation drain log for PR #408 to capture the five resolved review threads and summarize the “gate → disclosure” policy evolution step for the peer-review BACKLOG row.
Changes:
4 tasks
AceHack
added a commit
that referenced
this pull request
Apr 25, 2026
…_TOKEN header doc + grammar (#424) - **#405 P1 (Codex):** empty provenance cone now FAILS G_carrier_overlap (treats missing-lineage as suspicious, not best-case). Prior fix made overlap=0 which let provenance-empty + advisory-evidence-v0 stack into GREEN — the carrier-laundering safeguard would have missed exactly the records that should trigger review. Now the gate definition reads: fail-RED on (overlap > θ_high) OR (cone empty); fail-YELLOW on (overlap > θ_med). - **#411 P1 (Copilot):** gate.yml header 'No secrets referenced' was inaccurate after I added the workflow-level GITHUB_TOKEN env. Updated the header bullet to name the token explicitly + reference its read-only inheritance from permissions: contents: read + the workflow-vs-step-scope trade-off (DRY for ~7 install steps). - **#413 P2 (Copilot):** 'requires any modify' → 'requires any add-or-modify on' grammar fix. Note on #411 P2 (restrict GITHUB_TOKEN to install steps): trade-off documented in the header bullet rather than refactoring 7 install steps to per-step env. Reply explains. Note on #415 (name attribution in drain-log): docs/pr-preservation/ is a HISTORY surface per Otto-279 — names are policy-correct there. Reply explains. Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>
3 tasks
AceHack
added a commit
that referenced
this pull request
Apr 25, 2026
…#453) Otto-268 follow-on: drain-log for the **maximum-multi-parent cascade** observed in this drain wave — #424 was a follow-up to FOUR parent PRs simultaneously (#405 empty-cone + #411 GITHUB_TOKEN header + #413 grammar + #415 Otto-279 policy reply). Composes-vs-serializes tradeoff favored compose: one commit + one merge gate addressed all four parents. Per Otto-250 training-signal discipline. Pattern observations: 1. Maximum-multi-parent cascade: 4 parents in one follow-up. Composes when findings are independent + small. #423 had 2 parents; #424 doubled to 4. 2. fail-YELLOW vs fail-RED on structurally-normal empty-input cases (empty cone, zero qualifying findings, no diff to lint) — over- blocking risk when fail-RED on empty-input. CI-design candidate: every audit script should explicitly classify "empty-input" behavior at design time. 3. GitHub canonical-example form (`Authorization: token $GITHUB_TOKEN`) vs accepted-also (`Authorization: Bearer $GITHUB_TOKEN`); prefer canonical for reader friction reduction. 4. Otto-279 surface-class reply remains stamp-uniform across the corpus regardless of multi-parent grouping; the multi-parent grouping doesn't change per-finding response.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Continues task #268 drain-log backfill. #408 is the middle link in the three-PR policy-evolution chain:
5 review threads, all FIX outcomes, all resolved in single commit `e338c69` before auto-merge fired. Drain-log captures verbatim reviewer text + the policy-evolution arc from gate → disclosure marker.
Test plan
🤖 Generated with Claude Code