docs(archive): Maji PR preservation for PR #4097#4099
Closed
AceHack wants to merge 9 commits into
Closed
Conversation
Reviewer (chatgpt-codex-connector P2) flagged Option B's claim that shopt -s nullglob is portable to zsh. shopt is a bash builtin; zsh uses setopt/unsetopt with NULL_GLOB option. Corrected: - Removed 'portable to zsh too' false claim - Added explicit note: NOT portable to zsh - For zsh, use Option A (compgen — also bash) or Option C (find — fully portable), or substitute setopt -o NULL_GLOB / unsetopt NULL_GLOB Co-Authored-By: Claude <noreply@anthropic.com>
…ity follow-up post PR #4086 merge PR #4086 merged at 14:33:24Z with Option B substrate gap unfixed (thread resolved via mutation alone, substrate not corrected before merge). Authored correction as e254b37 on fresh follow-up branch; peer Otto created parallel branch (otto/b0613-zsh-portability- followup-1443z) with same substance (13f749d) mid-tick. Substrate-discovery lesson: thread-resolve mutations decouple from substrate-fix landings; false claim shipped to main despite reviewer thread marked resolved. Co-Authored-By: Claude <noreply@anthropic.com>
… B-0613 zsh fix follow-up Pure-git tier (378 → 61 GraphQL). Substrate-honest recovery from 1417Z verify-before-fix discipline failure: - Read working-tree state at 1417Z (peer-Otto's not-yet-committed zsh fix was in flight) and conflated with committed state on PR #4086 - FP-resolved a thread that was actually a real bug - Peer-Otto caught it, authored 54ca355 fix locally - This tick: cherry-picked peer's fix onto fresh branch, opened PR #4097 with substrate-honest disclosure Discipline-sharpen learnings: - Verify-before-fix means COMMITTED state (git show <ref>:<path>), not working-tree (sed -n on local file) - Multi-Otto-as-complementary-observer pattern catches errors in both directions PR #4086 + #4091 merged this cycle. PR #4097 open, arm-auto-merge deferred to next tick (rate-limit reset in ~17 min). Co-Authored-By: Claude <noreply@anthropic.com>
…te-limit reset 0 failures + 0 in-progress + BLOCKED suggests unresolved-thread state. GraphQL 4/5000 can't investigate. Reset ~15:00Z (3 min). Co-Authored-By: Claude <noreply@anthropic.com>
…et imminent Co-Authored-By: Claude <noreply@anthropic.com>
Reviewers caught that my prior Option B portability correction (54ca355/13f749d) recommended "use Option A or Option C for zsh" — but Option A (compgen -G) is ALSO a bash builtin, not zsh-valid. Corrected: zsh users should use Option C (find — fully portable) since both Option A and Option B are bash-only. Or substitute the shopt lines with setopt -o NULL_GLOB / unsetopt NULL_GLOB to adapt Option B to zsh directly. Resolves 2 threads (PRRT_kwDOSF9kNM6Cppvx + PRRT_kwDOSF9kNM6Cppwe). Co-Authored-By: Claude <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Archives merged PR #4097 (a follow-up that corrected a zsh portability claim in B-0613) into the PR-discussion preservation surface, along with the tick shards leading up to its merge. Also includes the substantive doc edit cherry-picked from the original branch.
Changes:
- Adds the PR #4097 preservation file under
docs/pr-discussions/. - Adds six hygiene-history tick shards (1443Z–1458Z) documenting the FP-resolve recovery and auto-merge wait.
- Updates B-0613 backlog row line 75 with the corrected zsh portability note.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| docs/pr-discussions/PR-4097-fix-b-0613-correct-option-b-zsh-portability-claim-shopt-is-b.md | PR archive with description, reviews, and resolved review threads |
| docs/hygiene-history/ticks/2026/05/17/1443Z.md | Tick shard: FP-resolve recovery + PR #4097 open |
| docs/hygiene-history/ticks/2026/05/17/1447Z.md | Tick shard: Option B substrate gap discovery |
| docs/hygiene-history/ticks/2026/05/17/1452Z.md | Tick shard: auto-merge SQUASH armed on #4097 |
| docs/hygiene-history/ticks/2026/05/17/1455Z.md | Tick shard: brief-ack #1 awaiting checks |
| docs/hygiene-history/ticks/2026/05/17/1457Z.md | Tick shard: brief-ack #2, BLOCKED state |
| docs/hygiene-history/ticks/2026/05/17/1458Z.md | Tick shard: brief-ack #3, rate-limit reset wait |
| docs/backlog/P3/B-0613-lior-loop-lockfile-probe-hardening-compgen-shopt-nullglob-2026-05-17.md | Corrects Option B zsh portability claim on line 75 |
Member
Author
|
Closing this PR. I cannot approve my own PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preserving merged PR #4097 to repository memory.