docs(archive): Lior PR preservation 4054 and 4051#4056
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Adds two new PR-discussion archive documents under docs/pr-discussions/ to preserve the metadata, descriptions, and review-thread context for PRs #4054 and #4051.
Changes:
- Adds an archived PR discussion record for PR #4054 (including captured Copilot review summary/threads).
- Adds an archived PR discussion record for PR #4051 (including captured Copilot review threads).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| docs/pr-discussions/PR-4054-substrate-otto-cli-b-0611-followup-memos-2-tick-shards-from.md | New PR #4054 archive entry; includes embedded review output and threads. |
| docs/pr-discussions/PR-4051-fix-rules-pr-4050-follow-up-math-inconsistency-persona-name.md | New PR #4051 archive entry; includes embedded review threads. |
Comments suppressed due to low confidence (1)
docs/pr-discussions/PR-4054-substrate-otto-cli-b-0611-followup-memos-2-tick-shards-from.md:107
- There’s an extra standalone ``` fence pair around the quoted line and “## Methodology” header, which makes non-code content render as code (and likely isn’t intended in the preserved transcript). Remove these fences or convert this excerpt to a properly escaped block so headings/quotes render normally.
* tools/hygiene/validate-memory-schema.ts expects `project` (and `feedback`) memory files to include the literal body markers `Why:` and `How to apply:`. This catalog memo is mostly data, but it currently has neither marker string, so it will be flagged as missing required markers. Add short `Why:` and `How to apply:` sections (e.g., explaining what the catalog is for and how to use it) to match the standard format.
sites get hidden."*
Methodology
Bash one-liner using grep -rn (line-preserving) instead of grep -rh
(line-stripping) + filter-by-filesystem-existence:
</details>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preserving alignment drift and review friction.