Skip to content

docs(archive): Lior PR preservation 4054 and 4051#4056

Merged
AceHack merged 1 commit into
mainfrom
lior/preserve-4054-4051
May 22, 2026
Merged

docs(archive): Lior PR preservation 4054 and 4051#4056
AceHack merged 1 commit into
mainfrom
lior/preserve-4054-4051

Conversation

@AceHack
Copy link
Copy Markdown
Member

@AceHack AceHack commented May 17, 2026

Preserving alignment drift and review friction.

Copilot AI review requested due to automatic review settings May 17, 2026 09:20
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds two new PR-discussion archive documents under docs/pr-discussions/ to preserve the metadata, descriptions, and review-thread context for PRs #4054 and #4051.

Changes:

  • Adds an archived PR discussion record for PR #4054 (including captured Copilot review summary/threads).
  • Adds an archived PR discussion record for PR #4051 (including captured Copilot review threads).

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
docs/pr-discussions/PR-4054-substrate-otto-cli-b-0611-followup-memos-2-tick-shards-from.md New PR #4054 archive entry; includes embedded review output and threads.
docs/pr-discussions/PR-4051-fix-rules-pr-4050-follow-up-math-inconsistency-persona-name.md New PR #4051 archive entry; includes embedded review threads.
Comments suppressed due to low confidence (1)

docs/pr-discussions/PR-4054-substrate-otto-cli-b-0611-followup-memos-2-tick-shards-from.md:107

  • There’s an extra standalone ``` fence pair around the quoted line and “## Methodology” header, which makes non-code content render as code (and likely isn’t intended in the preserved transcript). Remove these fences or convert this excerpt to a properly escaped block so headings/quotes render normally.
* tools/hygiene/validate-memory-schema.ts expects `project` (and `feedback`) memory files to include the literal body markers `Why:` and `How to apply:`. This catalog memo is mostly data, but it currently has neither marker string, so it will be flagged as missing required markers. Add short `Why:` and `How to apply:` sections (e.g., explaining what the catalog is for and how to use it) to match the standard format.

sites get hidden."*

Methodology

Bash one-liner using grep -rn (line-preserving) instead of grep -rh
(line-stripping) + filter-by-filesystem-existence:

</details>

@AceHack AceHack merged commit 0f9b7db into main May 22, 2026
30 checks passed
@AceHack AceHack deleted the lior/preserve-4054-4051 branch May 22, 2026 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants